Alexei Svitkine (Gerrit)

unread,

Sep 19, 2025, 11:16:29 AM (3 days ago) Sep 19

to AyeAye, niharm...@google.com, feature-me...@chromium.org, rouslan+au...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, ios-r...@chromium.org, chromiumme...@microsoft.com, christia...@chromium.org, browser-comp...@chromium.org, asvitki...@chromium.org, chrome-intelligence-te...@google.com, gavin...@chromium.org

Alexei Svitkine voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Sep 19, 2025, 11:27:02 AM (3 days ago) Sep 19

to Caitlin Fischer, Chromium LUCI CQ, AyeAye, niharm...@google.com, feature-me...@chromium.org, rouslan+au...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, ios-r...@chromium.org, chromiumme...@microsoft.com, christia...@chromium.org, browser-comp...@chromium.org, asvitki...@chromium.org, chrome-intelligence-te...@google.com, gavin...@chromium.org

Attention needed from Caitlin Fischer

Alexei Svitkine voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

Sep 19, 2025, 12:40:43 PM (3 days ago) Sep 19

to Sylvain Defresne, Avi Drissman, Caitlin Fischer, Chromium LUCI CQ, AyeAye, niharm...@google.com, feature-me...@chromium.org, rouslan+au...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, ios-r...@chromium.org, chromiumme...@microsoft.com, christia...@chromium.org, browser-comp...@chromium.org, asvitki...@chromium.org, chrome-intelligence-te...@google.com, gavin...@chromium.org

Attention needed from Avi Drissman, Caitlin Fischer and Sylvain Defresne

Alexei Svitkine added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Alexei Svitkine . resolved

+avi
+sdefresne

for OWNERS of call sites

Open in Gerrit

Related details

Attention is currently required from:

Avi Drissman
Caitlin Fischer
Sylvain Defresne

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Avi Drissman (Gerrit)

unread,

Sep 19, 2025, 2:06:46 PM (3 days ago) Sep 19

to Alexei Svitkine, Avi Drissman, Sylvain Defresne, Caitlin Fischer, Chromium LUCI CQ, AyeAye, niharm...@google.com, feature-me...@chromium.org, rouslan+au...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, ios-r...@chromium.org, chromiumme...@microsoft.com, christia...@chromium.org, browser-comp...@chromium.org, asvitki...@chromium.org, chrome-intelligence-te...@google.com, gavin...@chromium.org

Attention needed from Alexei Svitkine, Caitlin Fischer and Sylvain Defresne

Avi Drissman voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Caitlin Fischer
Sylvain Defresne

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Sylvain Defresne (Gerrit)

unread,

5:03 AM (13 hours ago) 5:03 AM

to Alexei Svitkine, Avi Drissman, Caitlin Fischer, Chromium LUCI CQ, AyeAye, niharm...@google.com, feature-me...@chromium.org, rouslan+au...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, ios-r...@chromium.org, chromiumme...@microsoft.com, christia...@chromium.org, browser-comp...@chromium.org, asvitki...@chromium.org, chrome-intelligence-te...@google.com, gavin...@chromium.org

Attention needed from Alexei Svitkine and Caitlin Fischer

Sylvain Defresne voted and added 2 comments

Votes added by Sylvain Defresne

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Sylvain Defresne . resolved

lgtm

Commit Message

Line 17, Patchset 7 (Latest):Bug: b/315411418

Sylvain Defresne . unresolved

I think `Bug: 315411418` should work.

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine
Caitlin Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

9:32 AM (9 hours ago) 9:32 AM

to Sylvain Defresne, Avi Drissman, Caitlin Fischer, Chromium LUCI CQ, AyeAye, niharm...@google.com, feature-me...@chromium.org, rouslan+au...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, ios-r...@chromium.org, chromiumme...@microsoft.com, christia...@chromium.org, browser-comp...@chromium.org, asvitki...@chromium.org, chrome-intelligence-te...@google.com, gavin...@chromium.org

Attention needed from Caitlin Fischer

Alexei Svitkine added 1 comment

Commit Message

Line 17, Patchset 7 (Latest):Bug: b/315411418

Sylvain Defresne . resolved

I think `Bug: 315411418` should work.

Alexei Svitkine

Let's see. It's not a Chromium bug tracker bug, though.

Open in Gerrit

Related details

Attention is currently required from:

Caitlin Fischer

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Caitlin Fischer (Gerrit)

unread,

2:29 PM (4 hours ago) 2:29 PM

to Alexei Svitkine, Sylvain Defresne, Avi Drissman, Chromium LUCI CQ, AyeAye, niharm...@google.com, feature-me...@chromium.org, rouslan+au...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, ios-r...@chromium.org, chromiumme...@microsoft.com, christia...@chromium.org, browser-comp...@chromium.org, asvitki...@chromium.org, chrome-intelligence-te...@google.com, gavin...@chromium.org

Attention needed from Alexei Svitkine

Caitlin Fischer voted and added 1 comment

Votes added by Caitlin Fischer

Code-Review

+1

1 comment

File components/variations/variations_ids_provider.h

Line 166, Patchset 8 (Latest):

  // this function. Once that is the case, the above function will be restricted
  // to call sites that are approved to use it.

Caitlin Fischer . unresolved

Optional nit: I could see this part of the comment becoming stale by accident. Instead of adding this comment above ForceVariationIdsForTesting(), I would maybe add a TODO above ForceVariationIds() about restricting its callers.

Open in Gerrit

Related details

Attention is currently required from:

Alexei Svitkine

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexei Svitkine (Gerrit)

unread,

2:56 PM (3 hours ago) 2:56 PM

to Caitlin Fischer, Sylvain Defresne, Avi Drissman, Chromium LUCI CQ, AyeAye, niharm...@google.com, feature-me...@chromium.org, rouslan+au...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, ios-r...@chromium.org, chromiumme...@microsoft.com, christia...@chromium.org, browser-comp...@chromium.org, asvitki...@chromium.org, chrome-intelligence-te...@google.com, gavin...@chromium.org

Alexei Svitkine voted and added 1 comment

Votes added by Alexei Svitkine

Commit-Queue

+2

1 comment

File components/variations/variations_ids_provider.h

Line 166, Patchset 8: // this function. Once that is the case, the above function will be restricted


  // to call sites that are approved to use it.

Caitlin Fischer . resolved

Optional nit: I could see this part of the comment becoming stale by accident. Instead of adding this comment above ForceVariationIdsForTesting(), I would maybe add a TODO above ForceVariationIds() about restricting its callers.

Alexei Svitkine

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

4:20 PM (2 hours ago) 4:20 PM

to Alexei Svitkine, Caitlin Fischer, Sylvain Defresne, Avi Drissman, AyeAye, niharm...@google.com, feature-me...@chromium.org, rouslan+au...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, tburkar...@chromium.org, prerenderi...@chromium.org, omnibox-...@chromium.org, chrome-intell...@chromium.org, ios-r...@chromium.org, chromiumme...@microsoft.com, christia...@chromium.org, browser-comp...@chromium.org, asvitki...@chromium.org, chrome-intelligence-te...@google.com, gavin...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

8 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: components/variations/variations_ids_provider.h
Insertions: 1, Deletions: 0.

@@ -153,6 +153,7 @@
     INVALID_SWITCH_ENTRY,  // Invalid entry in `command_line_variation_ids`.
   };
 
+  // TODO: b/315411418 - Restrict access to approved call sites.
   // Sets *additional* variation ids and trigger variation ids to be encoded in
   // the X-Client-Data request header. This is intended for development use to
   // force a server side experiment id. `variation_ids` should be a list of
```

Change information

Commit message:

Introduce and use `ForceVariationIdsForTesting`.

This change introduces `ForceVariationIdsForTesting` as a test-only
alias for forcing Google Variation IDs. All test-related calls to
`ForceVariationIds` are migrated to use this new function. This helps
in distinguishing between test and production usages of this API.

In the future, we want to lock down the production API to be callable
only from specific call sites.

Bug: 315411418

Change-Id: I9c0a2e61ecce59721a796b98df632431e82a2b43

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6969244

Reviewed-by: Avi Drissman <a...@chromium.org>

Commit-Queue: Alexei Svitkine <asvi...@chromium.org>

Reviewed-by: Caitlin Fischer <caitlin...@google.com>

Reviewed-by: Sylvain Defresne <sdef...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1518909}

Files:

M chrome/browser/metrics/variations/variations_http_headers_browsertest.cc
M chrome/browser/ui/webui/searchbox/searchbox_handler_unittest.cc
M components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_manager_unittest.cc
M components/variations/variations_ids_provider.cc
M components/variations/variations_ids_provider.h
M components/variations/variations_ids_provider_unittest.cc
M content/browser/preloading/prefetch/prefetch_container_unittest.cc
M ios/chrome/browser/lens_overlay/coordinator/lens_result_page_mediator_unittest.mm
M ios/chrome/browser/location_bar/ui_bundled/location_bar_coordinator_unittest.mm
M ios/chrome/browser/omnibox/eg_tests/omnibox_app_interface.mm
M ios/chrome/browser/optimization_guide/model/prediction_manager_browsertest.mm

Change size: M

Delta: 11 files changed, 44 insertions(+), 25 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Caitlin Fischer, +1 by Sylvain Defresne, +1 by Avi Drissman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Introduce and use `ForceVariationIdsForTesting`. [chromium/src : main]

Alexei Svitkine (Gerrit)

Alexei Svitkine voted Commit-Queue+1

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine voted Commit-Queue+1

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine added 1 comment

Related details

Avi Drissman (Gerrit)

Avi Drissman voted Code-Review+1

Related details

Sylvain Defresne (Gerrit)

Sylvain Defresne voted and added 2 comments

Votes added by Sylvain Defresne

2 comments

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine added 1 comment

Related details

Caitlin Fischer (Gerrit)

Caitlin Fischer voted and added 1 comment

Votes added by Caitlin Fischer

1 comment

Related details

Alexei Svitkine (Gerrit)

Alexei Svitkine voted and added 1 comment

Votes added by Alexei Svitkine

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information