[iOS][AIM] Add model picker to context menu in input plate [chromium/src : main]

0 views
Skip to first unread message

Radu Nitescu (Gerrit)

unread,
7:13 AM (3 hours ago) 7:13 AM
to Christian Xu, Ewann Pellé, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Attention needed from Christian Xu and Ewann Pellé

Radu Nitescu voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Christian Xu
  • Ewann Pellé
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6d0655cd0d3c312b0f9b7d56c148fdee00735251
Gerrit-Change-Number: 7505494
Gerrit-PatchSet: 3
Gerrit-Owner: Radu Nitescu <radun...@google.com>
Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
Gerrit-Reviewer: Ewann Pellé <ewa...@chromium.org>
Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
Gerrit-Attention: Ewann Pellé <ewa...@chromium.org>
Gerrit-Attention: Christian Xu <chris...@chromium.org>
Gerrit-Comment-Date: Thu, 22 Jan 2026 12:12:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ewann Pellé (Gerrit)

unread,
7:19 AM (3 hours ago) 7:19 AM
to Radu Nitescu, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Attention needed from Christian Xu and Radu Nitescu

Ewann Pellé voted and added 2 comments

Votes added by Ewann Pellé

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Ewann Pellé . resolved

LGTM with comment.

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
Line 1505, Patchset 3 (Latest): // Model picker
Ewann Pellé . unresolved
```suggestion
  // Model picker.
```
Open in Gerrit

Related details

Attention is currently required from:
  • Christian Xu
  • Radu Nitescu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6d0655cd0d3c312b0f9b7d56c148fdee00735251
Gerrit-Change-Number: 7505494
Gerrit-PatchSet: 3
Gerrit-Owner: Radu Nitescu <radun...@google.com>
Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
Gerrit-Reviewer: Ewann Pellé <ewa...@chromium.org>
Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
Gerrit-Attention: Christian Xu <chris...@chromium.org>
Gerrit-Attention: Radu Nitescu <radun...@google.com>
Gerrit-Comment-Date: Thu, 22 Jan 2026 12:18:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Christian Xu (Gerrit)

unread,
8:39 AM (2 hours ago) 8:39 AM
to Radu Nitescu, Ewann Pellé, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Attention needed from Radu Nitescu

Christian Xu added 3 comments

File ios/chrome/app/strings/ios_google_chrome_strings.grd
Line 262, Patchset 3 (Latest): Gemini 3 models
Christian Xu . unresolved

We should not hardcode the model number here.

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
Christian Xu . unresolved

Add a todo for model/attachments compatibility filtering. (There will be a shared components indicating which attachments are available for which models).

Line 1506, Patchset 3 (Latest): [self.consumer allowModelPicker:ShowComposeboxAdditionalAdvancedTools()];
Christian Xu . unresolved

We will also need to filter out some models depending on the current attachments. Similar to image creation mode.

Open in Gerrit

Related details

Attention is currently required from:
  • Radu Nitescu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6d0655cd0d3c312b0f9b7d56c148fdee00735251
Gerrit-Change-Number: 7505494
Gerrit-PatchSet: 3
Gerrit-Owner: Radu Nitescu <radun...@google.com>
Gerrit-Reviewer: Christian Xu <chris...@chromium.org>
Gerrit-Reviewer: Ewann Pellé <ewa...@chromium.org>
Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
Gerrit-Attention: Radu Nitescu <radun...@google.com>
Gerrit-Comment-Date: Thu, 22 Jan 2026 13:39:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages