Remove bug references from comments in AXMediaAppUntrustedService. [chromium/src : main]
0 views
Skip to first unread message
Ramin Halavati (Gerrit)
Mar 11, 2026, 1:53:21 AMMar 11
to Kyungjun Lee, Ramin Halavati, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, Katie D, Erol Bicioglu, David Tseng, abigailbk...@google.com, kyungjunle...@google.com, nektar...@chromium.org, josiah...@chromium.org, francisjp...@google.com, feature-me...@chromium.org, dtseng...@chromium.org, yuzo+...@chromium.org
Attention needed from Katie D and Kyungjun Lee
Ramin Halavati voted and added 2 comments![]( "Open in Gerrit")
Votes added by Ramin Halavati
| Code-Review | +1 |
2 comments
Patchset-level comments
File chrome/browser/accessibility/media_app/ax_media_app_untrusted_service.cc
Line 1263, Patchset 2 (Latest):
// Refactor this code to support things happening asynchronously - i.e.
// `RequestBitmap` will be async.Ramin Halavati . unresolved
I generally agree with removing TODOs that are so low in priority lists that are never done.
But now that it is not a TODO, it's better to reword the comment to make it information, something that specifies the existing limitation and not an action item.
Related details
Attention is currently required from:
- Katie D
- Kyungjun Lee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyungjun Lee (Gerrit)
Mar 11, 2026, 3:44:10 PMMar 11
to Ramin Halavati, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, Katie D, Erol Bicioglu, David Tseng, abigailbk...@google.com, kyungjunle...@google.com, nektar...@chromium.org, josiah...@chromium.org, francisjp...@google.com, feature-me...@chromium.org, dtseng...@chromium.org, yuzo+...@chromium.org
Attention needed from Katie D
Kyungjun Lee added 1 comment![]( "Open in Gerrit")
File chrome/browser/accessibility/media_app/ax_media_app_untrusted_service.cc
Line 1263, Patchset 2:
// Refactor this code to support things happening asynchronously - i.e.
// `RequestBitmap` will be async.Ramin Halavati . resolved
I generally agree with removing TODOs that are so low in priority lists that are never done.
But now that it is not a TODO, it's better to reword the comment to make it information, something that specifies the existing limitation and not an action item.
Kyungjun Lee
Thanks for the feedback. Updated the comments to make them informational.
Related details
Attention is currently required from:
- Katie D
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Katie D (Gerrit)
Mar 12, 2026, 5:06:42 PMMar 12
to Kyungjun Lee, Ramin Halavati, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, Erol Bicioglu, David Tseng, abigailbk...@google.com, kyungjunle...@google.com, nektar...@chromium.org, josiah...@chromium.org, francisjp...@google.com, feature-me...@chromium.org, dtseng...@chromium.org, yuzo+...@chromium.org
Attention needed from Kyungjun Lee
Katie D voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kyungjun Lee
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kyungjun Lee (Gerrit)
Mar 12, 2026, 5:11:06 PMMar 12
to Katie D, Ramin Halavati, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, Erol Bicioglu, David Tseng, abigailbk...@google.com, kyungjunle...@google.com, nektar...@chromium.org, josiah...@chromium.org, francisjp...@google.com, feature-me...@chromium.org, dtseng...@chromium.org, yuzo+...@chromium.org
Kyungjun Lee voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kyungjun Lee
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kyungjun Lee . resolved
Thanks Ramin and Katie for the review!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 12, 2026, 6:11:56 PMMar 12
to Kyungjun Lee, Katie D, Ramin Halavati, (Julie)Jeongeun Kim, Akihiro Ota, AyeAye, Erol Bicioglu, David Tseng, abigailbk...@google.com, kyungjunle...@google.com, nektar...@chromium.org, josiah...@chromium.org, francisjp...@google.com, feature-me...@chromium.org, dtseng...@chromium.org, yuzo+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove bug references from comments in AXMediaAppUntrustedService.
The comments regarding asynchronous bitmap requests and mocking `screen_ai_annotator_` are updated to remove the associated bug number, converting them from TODOs to general notes.
AX-Relnotes: n/a
Bug: 289012145
Change-Id: Idf08cde13af948474bc5a6a2e7a0390a7e83cdec
Reviewed-by: Katie D <ka...@chromium.org>
Reviewed-by: Ramin Halavati <rhal...@chromium.org>
Commit-Queue: Kyungjun Lee <kyung...@google.com>
Cr-Commit-Position: refs/heads/main@{#1598716}
Files:
- M chrome/browser/accessibility/media_app/ax_media_app_untrusted_service.cc
Change size: S
Delta: 1 file changed, 6 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Katie D, +1 by Ramin Halavati
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages