[iOS] Fix dangling pointers in FeedTopSectionMediatorTest [chromium/src : main]
0 views
Skip to first unread message
Guillem Perez (Gerrit)
Jun 26, 2026, 11:59:06 AM (2 days ago) Jun 26
to Rafał Godlewski, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Attention needed from Rafał Godlewski
Guillem Perez voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rafał Godlewski (Gerrit)
Jun 27, 2026, 5:58:52 AM (21 hours ago) Jun 27
to Guillem Perez, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Rafał Godlewski voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 27, 2026, 6:03:21 AM (21 hours ago) Jun 27
to Rafał Godlewski, Guillem Perez, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Fix dangling pointers in FeedTopSectionMediatorTest
Ensures keyed services are destroyed before profile is.
#codehealth
Change-Id: Idd2d1f714d6fce9ed6caf8f1feed5d6bb641bcad
Reviewed-by: Guillem Perez <guip...@google.com>
Commit-Queue: Rafał Godlewski <rg...@google.com>
Cr-Commit-Position: refs/heads/main@{#1653648}
Files:
- M ios/chrome/browser/ntp/ui_bundled/feed_top_section/feed_top_section_mediator_unittest.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Guillem Perez
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages