[iOS] Fix dangling pointers in FeedTopSectionMediatorTest [chromium/src : main]

0 views
Skip to first unread message

Guillem Perez (Gerrit)

unread,
Jun 26, 2026, 11:59:06 AM (2 days ago) Jun 26
to Rafał Godlewski, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Attention needed from Rafał Godlewski

Guillem Perez voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Rafał Godlewski
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idd2d1f714d6fce9ed6caf8f1feed5d6bb641bcad
Gerrit-Change-Number: 8008317
Gerrit-PatchSet: 2
Gerrit-Owner: Rafał Godlewski <rg...@google.com>
Gerrit-Reviewer: Guillem Perez <guip...@google.com>
Gerrit-Reviewer: Rafał Godlewski <rg...@google.com>
Gerrit-Attention: Rafał Godlewski <rg...@google.com>
Gerrit-Comment-Date: Fri, 26 Jun 2026 15:58:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Rafał Godlewski (Gerrit)

unread,
Jun 27, 2026, 5:58:52 AM (21 hours ago) Jun 27
to Guillem Perez, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Rafał Godlewski voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idd2d1f714d6fce9ed6caf8f1feed5d6bb641bcad
Gerrit-Change-Number: 8008317
Gerrit-PatchSet: 2
Gerrit-Owner: Rafał Godlewski <rg...@google.com>
Gerrit-Reviewer: Guillem Perez <guip...@google.com>
Gerrit-Reviewer: Rafał Godlewski <rg...@google.com>
Gerrit-Comment-Date: Sat, 27 Jun 2026 09:58:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 27, 2026, 6:03:21 AM (21 hours ago) Jun 27
to Rafał Godlewski, Guillem Perez, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[iOS] Fix dangling pointers in FeedTopSectionMediatorTest

Ensures keyed services are destroyed before profile is.

#codehealth
Change-Id: Idd2d1f714d6fce9ed6caf8f1feed5d6bb641bcad
Reviewed-by: Guillem Perez <guip...@google.com>
Commit-Queue: Rafał Godlewski <rg...@google.com>
Cr-Commit-Position: refs/heads/main@{#1653648}
Files:
Change size: XS
Delta: 1 file changed, 2 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Guillem Perez
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Idd2d1f714d6fce9ed6caf8f1feed5d6bb641bcad
Gerrit-Change-Number: 8008317
Gerrit-PatchSet: 3
Gerrit-Owner: Rafał Godlewski <rg...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Guillem Perez <guip...@google.com>
Gerrit-Reviewer: Rafał Godlewski <rg...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages