[iOS] Add room above keyboard for location indicator in Find in Page [chromium/src : main]
0 views
Skip to first unread message
Quentin Pubert (Gerrit)
Jan 21, 2026, 11:41:37 AM (23 hours ago) Jan 21
to Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Quentin Pubert voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
3:31 AM (7 hours ago) 3:31 AM
to Quentin Pubert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Quentin Pubert
Gauthier Ambard voted and added 2 comments![]( "Open in Gerrit")
Votes added by Gauthier Ambard
| Code-Review | +1 |
2 comments
File ios/chrome/browser/toolbar/legacy/ui_bundled/secondary_toolbar_view_controller.mm
Line 227, Patchset 3 (Latest):
if ([self useAccessoryViewPosition]) {Gauthier Ambard . unresolved
What about this case?
Line 235, Patchset 3 (Latest):
if (findNavigatorVisible && shouldConstraintToKeyboard) {Gauthier Ambard . unresolved
You are already in `if (shouldConstraintToKeyboard) `
Related details
Attention is currently required from:
- Quentin Pubert
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Quentin Pubert (Gerrit)
4:13 AM (6 hours ago) 4:13 AM
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Quentin Pubert voted and added 2 comments![]( "Open in Gerrit")
Votes added by Quentin Pubert
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
File ios/chrome/browser/toolbar/legacy/ui_bundled/secondary_toolbar_view_controller.mm
Line 227, Patchset 3:
if ([self useAccessoryViewPosition]) {Gauthier Ambard . resolved
Quentin PubertWhat about this case?
AFAIK the accessory view and Find navigator cannot appear at the same time.
Line 235, Patchset 3:
if (findNavigatorVisible && shouldConstraintToKeyboard) {Gauthier Ambard . resolved
You are already in `if (shouldConstraintToKeyboard) `
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Quentin Pubert (Gerrit)
4:13 AM (6 hours ago) 4:13 AM
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Quentin Pubert voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:20 AM (5 hours ago) 5:20 AM
to Quentin Pubert, Gauthier Ambard, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/toolbar/legacy/ui_bundled/secondary_toolbar_view_controller.mm
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[iOS] Add room above keyboard for location indicator in Find in Page
This CL updates the secondary toolbar's
- (void)constraintToKeyboard:(BOOL)shouldConstraintToKeyboard
withNotification:(NSNotification*)notification
method so it shifts the secondary toolbar location indicator slightly
higher when Find in Page is active in the tab, so the location indicator
is not hidden behind the Find navigator.
Bug: 475843085
Change-Id: Id0333985ac843018a583903729f3a500b023b0eb
Reviewed-by: Gauthier Ambard <gam...@chromium.org>
Auto-Submit: Quentin Pubert <qpu...@google.com>
Commit-Queue: Quentin Pubert <qpu...@google.com>
Cr-Commit-Position: refs/heads/main@{#1572831}
Files:
- M ios/chrome/browser/find_in_page/model/BUILD.gn
- M ios/chrome/browser/find_in_page/model/DEPS
- A ios/chrome/browser/find_in_page/model/find_in_page_util.h
- A ios/chrome/browser/find_in_page/model/find_in_page_util.mm
- M ios/chrome/browser/find_in_page/model/find_tab_helper.h
- M ios/chrome/browser/reader_mode/model/BUILD.gn
- M ios/chrome/browser/reader_mode/model/DEPS
- M ios/chrome/browser/toolbar/legacy/ui_bundled/BUILD.gn
- M ios/chrome/browser/toolbar/legacy/ui_bundled/DEPS
- M ios/chrome/browser/toolbar/legacy/ui_bundled/secondary_toolbar_mediator.mm
- M ios/chrome/browser/toolbar/legacy/ui_bundled/secondary_toolbar_view_controller.mm
Change size: M
Delta: 11 files changed, 55 insertions(+), 7 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gauthier Ambard
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages