Remove obsolete conversion functions [chromium/src : main]
0 views
Skip to first unread message
Avi Drissman (Gerrit)
Oct 9, 2025, 8:33:14 PM (2 days ago) Oct 9
to Avi Drissman, Christine Hollingsworth, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, James Su, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Christine Hollingsworth
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Christine Hollingsworth
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christine Hollingsworth (Gerrit)
Oct 10, 2025, 10:54:46 AM (15 hours ago) Oct 10
to Avi Drissman, Christine Hollingsworth, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, James Su, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Avi Drissman and Christine Hollingsworth
Christine Hollingsworth voted and added 1 comment![]( "Open in Gerrit")
Votes added by Christine Hollingsworth
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Avi Drissman
- Christine Hollingsworth
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
gwsq (Gerrit)
Oct 10, 2025, 1:03:33 PM (13 hours ago) Oct 10
to Avi Drissman, Chromium UI Views Reviews, Keren Zhu, Christine Hollingsworth, Christine Hollingsworth, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, James Su, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Christine Hollingsworth and Keren Zhu
Message from gwsq![]( "Open in Gerrit")
WARNING: gwsq was unable to find a reviewer who is not on vacation. As a fallback, gwsq is ignoring vacations and assigning kere...@chromium.org.
Reviewer source(s):
kere...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)
Related details
Attention is currently required from:
- Christine Hollingsworth
- Keren Zhu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Oct 10, 2025, 4:57:18 PM (9 hours ago) Oct 10
to Avi Drissman, Mike Wasserman, Chromium UI Views Reviews, Keren Zhu, Christine Hollingsworth, Christine Hollingsworth, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, James Su, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Christine Hollingsworth and Keren Zhu
Avi Drissman voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Christine Hollingsworth
- Keren Zhu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Wasserman (Gerrit)
Oct 10, 2025, 4:57:29 PM (9 hours ago) Oct 10
to Avi Drissman, Chromium UI Views Reviews, Keren Zhu, Christine Hollingsworth, Christine Hollingsworth, Chromium LUCI CQ, chromium...@chromium.org, Rijubrata Bhaumik, James Su, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Avi Drissman, Christine Hollingsworth and Keren Zhu
Mike Wasserman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Avi Drissman
- Christine Hollingsworth
- Keren Zhu
Chromium LUCI CQ (Gerrit)
Oct 10, 2025, 5:40:50 PM (8 hours ago) Oct 10
to Avi Drissman, Mike Wasserman, Chromium UI Views Reviews, Keren Zhu, Christine Hollingsworth, Christine Hollingsworth, chromium...@chromium.org, Rijubrata Bhaumik, James Su, alexmo...@chromium.org, chfreme...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, mac-r...@chromium.org, mfoltz+wa...@chromium.org, navigation...@chromium.org, nona+...@chromium.org, roblia...@chromium.org, shuche...@chromium.org, sky+...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove obsolete conversion functions
When macOS was moved to be 64-bit, Apple engineers took the
opportunity, while everyone was forced to rebuild their apps, to
simplify core types. For 64-bit, NSRect/NSPoint/NSSize were typedef-ed
to be their CGRect/CGPoint/CGSize counterparts rather than being
defined equivalently but separately.
Because Chromium is 64-bit only on the Mac, remove old non-needed
conversion functions between these identical types.
Bug: none
Change-Id: I8e2e0d432e59960a625313869ff098253b204421
Reviewed-by: Mike Wasserman <m...@chromium.org>
Reviewed-by: Christine Hollingsworth <chris...@chromium.org>
Commit-Queue: Avi Drissman <a...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1528379}
Files:
- M components/remote_cocoa/app_shim/immersive_mode_controller_cocoa.mm
- M components/remote_cocoa/app_shim/immersive_mode_tabbed_controller_cocoa.mm
- M content/app_shim_remote_cocoa/render_widget_host_view_cocoa.mm
- M content/app_shim_remote_cocoa/web_contents_ns_view_bridge.mm
- M content/browser/media/capture/mouse_cursor_overlay_controller_mac.mm
- M content/browser/renderer_host/render_widget_host_view_mac.mm
- M content/public/test/content_browser_test_utils_mac.mm
- M ui/base/cocoa/base_view.mm
- M ui/base/cocoa/cursor_utils.mm
- M ui/display/mac/screen_mac.mm
- M ui/events/test/cocoa_test_event_utils.mm
- M ui/snapshot/snapshot_mac.mm
- M ui/views/widget/native_widget_mac.mm
Change size: S
Delta: 13 files changed, 21 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Christine Hollingsworth, +1 by Mike Wasserman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages