editor: avoid cache context when getting the context of editor [chromium/src : main]

0 views
Skip to first unread message

Chuong Ho (Gerrit)

unread,
Jul 4, 2024, 9:26:58 PM (7 hours ago) Jul 4
to Erik Chen, Curtis McMullan, AyeAye, chromium...@chromium.org, oshima...@chromium.org, blundell+...@chromium.org, feature-me...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Curtis McMullan and Erik Chen

Chuong Ho voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Curtis McMullan
  • Erik Chen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9143277eade2d5a93952d70680bcfa3bf96d2c10
Gerrit-Change-Number: 5678387
Gerrit-PatchSet: 6
Gerrit-Owner: Chuong Ho <hdch...@chromium.org>
Gerrit-Reviewer: Chuong Ho <hdch...@chromium.org>
Gerrit-Reviewer: Curtis McMullan <curtism...@chromium.org>
Gerrit-Reviewer: Erik Chen <erik...@chromium.org>
Gerrit-Attention: Curtis McMullan <curtism...@chromium.org>
Gerrit-Attention: Erik Chen <erik...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Jul 2024 01:26:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chuong Ho (Gerrit)

unread,
Jul 4, 2024, 9:29:52 PM (7 hours ago) Jul 4
to Scott Violet, Chromium LUCI CQ, Curtis McMullan, AyeAye, chromium...@chromium.org, oshima...@chromium.org, blundell+...@chromium.org, feature-me...@chromium.org, keithle...@chromium.org, nona+...@chromium.org, shuche...@chromium.org, tranbaod...@chromium.org, yhanad...@chromium.org
Attention needed from Curtis McMullan and Scott Violet

Chuong Ho added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Chuong Ho . resolved

This CL spans multiple files,


@s...@chromium.org, could you please review chrome/browser/ui/quick_answers and chrome/browser/renderer_context_menu/?
@curtism...@chromium.org could you please review chrome/browser/ash/input_method/, chrome/browser/ui/views/editor_menu/ and chromeos/components/editor_menu?

Thank you ^^

Open in Gerrit

Related details

Attention is currently required from:
  • Curtis McMullan
  • Scott Violet
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9143277eade2d5a93952d70680bcfa3bf96d2c10
Gerrit-Change-Number: 5678387
Gerrit-PatchSet: 6
Gerrit-Owner: Chuong Ho <hdch...@chromium.org>
Gerrit-Reviewer: Chuong Ho <hdch...@chromium.org>
Gerrit-Reviewer: Curtis McMullan <curtism...@chromium.org>
Gerrit-Reviewer: Scott Violet <s...@chromium.org>
Gerrit-Attention: Curtis McMullan <curtism...@chromium.org>
Gerrit-Attention: Scott Violet <s...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Jul 2024 01:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages