[CP][iOS] Gemini image remix in-product help [chromium/src : refs/branch-heads/7632]
0 views
Skip to first unread message
Adam Arcaro (Gerrit)
2:53 PM (5 hours ago) 2:53 PM
to Nicolas MacBeth, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, feature-me...@chromium.org, estali...@chromium.org, dfried...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, asvitkine...@chromium.org
Attention needed from Nicolas MacBeth
Adam Arcaro voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Nicolas MacBeth
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas MacBeth (Gerrit)
3:09 PM (4 hours ago) 3:09 PM
to Adam Arcaro, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, feature-me...@chromium.org, estali...@chromium.org, dfried...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, asvitkine...@chromium.org
Nicolas MacBeth voted Owners-Override+1![]( "Open in Gerrit")
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas MacBeth (Gerrit)
3:10 PM (4 hours ago) 3:10 PM
to Adam Arcaro, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, feature-me...@chromium.org, estali...@chromium.org, dfried...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, asvitkine...@chromium.org
Nicolas MacBeth voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
3:13 PM (4 hours ago) 3:13 PM
to Nicolas MacBeth, Adam Arcaro, Chromium Metrics Reviews, AyeAye, feature-me...@chromium.org, estali...@chromium.org, dfried...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, asvitkine...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[CP][iOS] Gemini image remix in-product help
Adds an In-Product Help (IPH) bubble to highlight the Gemini Image Remix
feature.
- Defines `kIPHiOSGeminiImageRemixFeature` and configures the trigger
rules in `iOSPromoFeatureConfiguration`.
- Updates `BubblePresenter` to display the bubble pointing to the Page
Action Menu anchor.
- Modifies `BWGTabHelper` to trigger the IPH when conditions are met.
- Plumbs the `ImageRemixIPH` entry point through `BWGMediator` and
`BWGBrowserAgent` to correctly track feature usage initiated from the
IPH.
- Updates relevant metrics and histograms.
(cherry picked from commit c36c91fc8ac8f1455d481f6c39a18ac8a15655cb)
Bug: 463432946, 476991299
Change-Id: I0f7e0eba13a34ca3743944c3576da3e4bff1cbf9
Reviewed-by: Adam Arcaro <ada...@google.com>
Reviewed-by: Robbie Gibson <rkgi...@google.com>
Reviewed-by: Rohit Rao <rohi...@chromium.org>
Commit-Queue: Nicolas MacBeth <nicolas...@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1569264}
Owners-Override: Nicolas MacBeth <nicolas...@google.com>
Cr-Commit-Position: refs/branch-heads/7632@{#470}
Cr-Branched-From: 0bbdf2913883391365383b0a5dfe7bf9fd1a5213-refs/heads/main@{#1568190}
Files:
- M components/feature_engagement/public/event_constants.cc
- M components/feature_engagement/public/event_constants.h
- M components/feature_engagement/public/feature_configurations.cc
- M components/feature_engagement/public/feature_constants.cc
- M components/feature_engagement/public/feature_constants.h
- M components/feature_engagement/public/feature_list.cc
- M components/feature_engagement/public/feature_list.h
- M ios/chrome/browser/browser_view/ui_bundled/tab_lifecycle_mediator.mm
- M ios/chrome/browser/bubble/public/in_product_help_type.h
- M ios/chrome/browser/bubble/ui_bundled/BUILD.gn
- M ios/chrome/browser/bubble/ui_bundled/DEPS
- M ios/chrome/browser/bubble/ui_bundled/bubble_presenter.h
- M ios/chrome/browser/bubble/ui_bundled/bubble_presenter.mm
- M ios/chrome/browser/bubble/ui_bundled/bubble_presenter_coordinator.mm
- M ios/chrome/browser/intelligence/bwg/coordinator/bwg_coordinator.mm
- M ios/chrome/browser/intelligence/bwg/coordinator/bwg_mediator.h
- M ios/chrome/browser/intelligence/bwg/coordinator/bwg_mediator.mm
- M ios/chrome/browser/intelligence/bwg/model/BUILD.gn
- M ios/chrome/browser/intelligence/bwg/model/bwg_browser_agent.h
- M ios/chrome/browser/intelligence/bwg/model/bwg_browser_agent.mm
- M ios/chrome/browser/intelligence/bwg/model/bwg_browser_agent_unittest.mm
- M ios/chrome/browser/intelligence/bwg/model/bwg_tab_helper.h
- M ios/chrome/browser/intelligence/bwg/model/bwg_tab_helper.mm
- M ios/chrome/browser/intelligence/bwg/model/bwg_tab_helper_unittest.mm
- M ios/chrome/browser/intelligence/bwg/model/gemini_configuration.h
- M ios/chrome/browser/intelligence/bwg/utils/bwg_constants.h
- M tools/metrics/actions/actions.xml
- M tools/metrics/histograms/metadata/feature_engagement/histograms.xml
- M tools/metrics/histograms/metadata/ios/enums.xml
Change size: L
Delta: 29 files changed, 299 insertions(+), 29 deletions(-)
Branch: refs/branch-heads/7632
Submit Requirements:
Code-Review: +1 by Adam Arcaro
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages