Remove --force-video-overlays on Android [chromium/src : main]
0 views
Skip to first unread message
Dale Curtis (Gerrit)
Sep 18, 2025, 12:48:37 PMSep 18
to Eugene Zemtsov, Phil Yan, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org
Attention needed from Eugene Zemtsov
Dale Curtis voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dale Curtis
| Auto-Submit | +1 |
| Commit-Queue | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Dale Curtis . resolved
liberato=>cc since we should grow more owners for this area of the code 😊
File third_party/blink/renderer/platform/media/web_media_player_impl.cc
Line 560, Patchset 1 (Parent):
always_enable_overlays_ = base::CommandLine::ForCurrentProcess()->HasSwitch(Dale Curtis . resolved
Note: The variable isn't removed because it can be set to true later based on things I'll clean up in follow-up patch sets.
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frank Liberato (Gerrit)
Sep 18, 2025, 12:52:56 PMSep 18
to Dale Curtis, Eugene Zemtsov, Phil Yan, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org
Attention needed from Dale Curtis and Eugene Zemtsov
Frank Liberato added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Frank Liberato . resolved
unsolicited comments: this might be used by our friends in chromecast. might want to check with halliwell@ if you haven't already.
tahnks
-fl
Related details
Attention is currently required from:
- Dale Curtis
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Sep 18, 2025, 12:56:24 PMSep 18
to Eugene Zemtsov, Phil Yan, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org
Attention needed from Eugene Zemtsov and Frank Liberato
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Auto-Submit | +0 |
| Commit-Queue | +0 |
1 comment
Patchset-level comments
Frank Liberato . unresolved
unsolicited comments: this might be used by our friends in chromecast. might want to check with halliwell@ if you haven't already.
tahnks
-fl
Dale Curtis
Oh, I think you're right, internal code search has some hits. Maybe we can only clean up the gpu side of things then.
Related details
Attention is currently required from:
- Eugene Zemtsov
- Frank Liberato
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Phil Yan (Gerrit)
Sep 18, 2025, 1:20:47 PMSep 18
to Dale Curtis, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org
Attention needed from Dale Curtis
Phil Yan added 1 comment![]( "Open in Gerrit")
File media/gpu/android/surface_chooser_helper.h
Line 30, Patchset 2 (Parent):
// |is_overlay_required| tells us to require overlays(!).Phil Yan . unresolved
Don't forget to update the comment as well
Related details
Attention is currently required from:
- Dale Curtis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Oct 10, 2025, 4:40:44 PM (9 hours ago) Oct 10
to Eugene Zemtsov, Phil Yan, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-...@chromium.org, chromeos-gfx-...@google.com, creis...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, media-cro...@chromium.org, mfoltz...@chromium.org, navigation...@chromium.org
Dale Curtis abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages