[M149] [VCN iOS] Fix virtual card unmasking crash in suggestion flow [chromium/src : refs/branch-heads/7827]

0 views
Skip to first unread message

yiwen qian (Gerrit)

unread,
May 15, 2026, 3:33:15 PM (3 days ago) May 15
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, AyeAye Python Dispatcher, android-bu...@system.gserviceaccount.com, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org

Message from yiwen qian

Set Ready For Review

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7827
Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
Gerrit-Change-Number: 7848205
Gerrit-PatchSet: 3
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-CC: yiwen qian <yiwe...@chromium.org>
Gerrit-Comment-Date: Fri, 15 May 2026 19:33:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
unsatisfied_requirement
satisfied_requirement
open
diffy

yiwen qian (Gerrit)

unread,
May 15, 2026, 4:27:20 PM (3 days ago) May 15
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, Qihui Zhao, Vincent Boisselle, Chromium LUCI CQ, AyeAye Python Dispatcher, android-bu...@system.gserviceaccount.com, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
Attention needed from Christoph Schwering, Qihui Zhao, Vincent Boisselle and yiwen qian

yiwen qian voted and added 1 comment

Votes added by yiwen qian

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
yiwen qian . resolved

Hi Qihui, Vincent and Christoph, could you please review this CL? Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
  • Qihui Zhao
  • Vincent Boisselle
  • yiwen qian
Submit Requirements:
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7827
Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
Gerrit-Change-Number: 7848205
Gerrit-PatchSet: 6
Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
Gerrit-Attention: Vincent Boisselle <vi...@google.com>
Gerrit-Attention: Christoph Schwering <schw...@google.com>
Gerrit-Attention: Qihui Zhao <qihu...@google.com>
Gerrit-Comment-Date: Fri, 15 May 2026 20:27:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
unsatisfied_requirement
satisfied_requirement
open
diffy

Vincent Boisselle (Gerrit)

unread,
May 15, 2026, 4:29:24 PM (3 days ago) May 15
to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, yiwen qian, Qihui Zhao, Chromium LUCI CQ, AyeAye Python Dispatcher, android-bu...@system.gserviceaccount.com, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
Attention needed from Christoph Schwering, Qihui Zhao and yiwen qian

Vincent Boisselle voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Christoph Schwering
  • Qihui Zhao
  • yiwen qian
Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedLint
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7827
    Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
    Gerrit-Change-Number: 7848205
    Gerrit-PatchSet: 6
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
    Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
    Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
    Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
    Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
    Gerrit-Attention: Christoph Schwering <schw...@google.com>
    Gerrit-Attention: Qihui Zhao <qihu...@google.com>
    Gerrit-Comment-Date: Fri, 15 May 2026 20:29:17 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    Vincent Boisselle (Gerrit)

    unread,
    May 15, 2026, 4:51:56 PM (3 days ago) May 15
    to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, yiwen qian, Qihui Zhao, Chromium LUCI CQ, AyeAye Python Dispatcher, android-bu...@system.gserviceaccount.com, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
    Attention needed from Christoph Schwering, Qihui Zhao and yiwen qian

    Vincent Boisselle voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christoph Schwering
    • Qihui Zhao
    • yiwen qian
    Submit Requirements:
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedLint
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7827
    Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
    Gerrit-Change-Number: 7848205
    Gerrit-PatchSet: 8
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
    Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
    Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
    Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
    Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
    Gerrit-Attention: Christoph Schwering <schw...@google.com>
    Gerrit-Attention: Qihui Zhao <qihu...@google.com>
    Gerrit-Comment-Date: Fri, 15 May 2026 20:51:50 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    unsatisfied_requirement
    satisfied_requirement
    open
    diffy

    yiwen qian (Gerrit)

    unread,
    May 15, 2026, 5:06:52 PM (3 days ago) May 15
    to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Vincent Boisselle, Qihui Zhao, Chromium LUCI CQ, AyeAye Python Dispatcher, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
    Attention needed from Christoph Schwering, Qihui Zhao, Vincent Boisselle and yiwen qian

    Message from yiwen qian

    Set Ready For Review

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christoph Schwering
    • Qihui Zhao
    • Vincent Boisselle
    • yiwen qian
    Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedLint
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7827
      Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
      Gerrit-Change-Number: 7848205
      Gerrit-PatchSet: 10
      Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
      Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
      Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
      Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
      Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
      Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
      Gerrit-Attention: Vincent Boisselle <vi...@google.com>
      Gerrit-Attention: Christoph Schwering <schw...@google.com>
      Gerrit-Attention: Qihui Zhao <qihu...@google.com>
      Gerrit-Comment-Date: Fri, 15 May 2026 21:06:33 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      yiwen qian (Gerrit)

      unread,
      May 15, 2026, 5:21:03 PM (3 days ago) May 15
      to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Vincent Boisselle, Qihui Zhao, Chromium LUCI CQ, AyeAye Python Dispatcher, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
      Attention needed from Christoph Schwering, Qihui Zhao, Vincent Boisselle and yiwen qian

      Message from yiwen qian

      Set Ready For Review

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Christoph Schwering
      • Qihui Zhao
      • Vincent Boisselle
      • yiwen qian
      Submit Requirements:
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedLint
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: refs/branch-heads/7827
      Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
      Gerrit-Change-Number: 7848205
      Gerrit-PatchSet: 13
      Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
      Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
      Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
      Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
      Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
      Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
      Gerrit-Attention: Vincent Boisselle <vi...@google.com>
      Gerrit-Attention: Christoph Schwering <schw...@google.com>
      Gerrit-Attention: Qihui Zhao <qihu...@google.com>
      Gerrit-Comment-Date: Fri, 15 May 2026 21:20:49 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      unsatisfied_requirement
      satisfied_requirement
      open
      diffy

      Vincent Boisselle (Gerrit)

      unread,
      May 15, 2026, 5:39:31 PM (3 days ago) May 15
      to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, yiwen qian, android-bu...@system.gserviceaccount.com, Qihui Zhao, Chromium LUCI CQ, AyeAye Python Dispatcher, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
      Attention needed from Christoph Schwering, Qihui Zhao and yiwen qian

      Vincent Boisselle voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Christoph Schwering
      • Qihui Zhao
      • yiwen qian
      Submit Requirements:
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedLint
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: refs/branch-heads/7827
        Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
        Gerrit-Change-Number: 7848205
        Gerrit-PatchSet: 13
        Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
        Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
        Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
        Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
        Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
        Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
        Gerrit-Attention: Christoph Schwering <schw...@google.com>
        Gerrit-Attention: Qihui Zhao <qihu...@google.com>
        Gerrit-Comment-Date: Fri, 15 May 2026 21:39:24 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        unsatisfied_requirement
        satisfied_requirement
        open
        diffy

        Christoph Schwering (Gerrit)

        unread,
        May 17, 2026, 1:55:17 PM (20 hours ago) May 17
        to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, yiwen qian, Vincent Boisselle, android-bu...@system.gserviceaccount.com, Qihui Zhao, Chromium LUCI CQ, AyeAye Python Dispatcher, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
        Attention needed from Qihui Zhao and yiwen qian

        Christoph Schwering added 2 comments

        Patchset-level comments
        File-level comment, Patchset 15 (Latest):
        Christoph Schwering . unresolved

        I'm having trouble understanding the merge conflicts. Is there a second CL that should perhaps also be cherry-picked?

        File ios/chrome/browser/autofill/ui_bundled/manual_fill/BUILD.gn
        Line 223, Patchset 15 (Parent): "manual_fill_virtual_card_cache_unittest.mm",
        Christoph Schwering . unresolved

        How come we need to remove this?

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Qihui Zhao
        • yiwen qian
        Submit Requirements:
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement satisfiedLint
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: refs/branch-heads/7827
          Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
          Gerrit-Change-Number: 7848205
          Gerrit-PatchSet: 15
          Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
          Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
          Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
          Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
          Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
          Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
          Gerrit-Attention: Qihui Zhao <qihu...@google.com>
          Gerrit-Comment-Date: Sun, 17 May 2026 17:54:53 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          unsatisfied_requirement
          satisfied_requirement
          open
          diffy

          yiwen qian (Gerrit)

          unread,
          May 17, 2026, 6:55:33 PM (15 hours ago) May 17
          to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Vincent Boisselle, Qihui Zhao, Chromium LUCI CQ, AyeAye Python Dispatcher, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
          Attention needed from Christoph Schwering, Qihui Zhao and Vincent Boisselle

          yiwen qian added 2 comments

          Patchset-level comments
          File-level comment, Patchset 15:
          Christoph Schwering . resolved

          I'm having trouble understanding the merge conflicts. Is there a second CL that should perhaps also be cherry-picked?

          yiwen qian

          Thank you for this suggestion, I've cherry-picked https://chromium-review.git.corp.google.com/c/chromium/src/+/7853659 and merged this. Now this cl has no conflicts.

          File ios/chrome/browser/autofill/ui_bundled/manual_fill/BUILD.gn
          Christoph Schwering . resolved

          How come we need to remove this?

          yiwen qian

          Marked as resolved.

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Christoph Schwering
          • Qihui Zhao
          • Vincent Boisselle
          Submit Requirements:
            • requirement is not satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement satisfiedLint
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: refs/branch-heads/7827
            Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
            Gerrit-Change-Number: 7848205
            Gerrit-PatchSet: 20
            Gerrit-Attention: Vincent Boisselle <vi...@google.com>
            Gerrit-Attention: Christoph Schwering <schw...@google.com>
            Gerrit-Attention: Qihui Zhao <qihu...@google.com>
            Gerrit-Comment-Date: Sun, 17 May 2026 22:55:20 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            Comment-In-Reply-To: Christoph Schwering <schw...@google.com>
            unsatisfied_requirement
            satisfied_requirement
            open
            diffy

            Christoph Schwering (Gerrit)

            unread,
            6:29 AM (4 hours ago) 6:29 AM
            to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, yiwen qian, android-bu...@system.gserviceaccount.com, Vincent Boisselle, Qihui Zhao, Chromium LUCI CQ, AyeAye Python Dispatcher, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
            Attention needed from Qihui Zhao, Vincent Boisselle and yiwen qian

            Christoph Schwering voted and added 1 comment

            Votes added by Christoph Schwering

            Code-Review+1

            1 comment

            Patchset-level comments
            File-level comment, Patchset 21 (Latest):
            Christoph Schwering . unresolved

            LGTM assuming there are no merge conflicts (I can't confirm that because the base has the merge conflicts)

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Qihui Zhao
            • Vincent Boisselle
            • yiwen qian
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement satisfiedLint
            • requirement is not satisfiedNo-Unresolved-Comments
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: refs/branch-heads/7827
            Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
            Gerrit-Change-Number: 7848205
            Gerrit-PatchSet: 21
            Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
            Gerrit-Attention: Vincent Boisselle <vi...@google.com>
            Gerrit-Attention: Qihui Zhao <qihu...@google.com>
            Gerrit-Comment-Date: Mon, 18 May 2026 10:29:42 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Vincent Boisselle (Gerrit)

            unread,
            6:41 AM (4 hours ago) 6:41 AM
            to chrome-che...@chops-service-accounts.iam.gserviceaccount.com, yiwen qian, android-bu...@system.gserviceaccount.com, Qihui Zhao, Chromium LUCI CQ, AyeAye Python Dispatcher, ios-r...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com, ios-revie...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, ios-rev...@chromium.org, armalhotra+a...@google.com, marq+...@chromium.org, osaul+aut...@google.com, tmartino+tran...@chromium.org, sloboda...@chromium.org, ios-web-view...@google.com, feature-me...@chromium.org, browser-comp...@chromium.org
            Attention needed from Qihui Zhao and yiwen qian

            Vincent Boisselle voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Qihui Zhao
            • yiwen qian
            Submit Requirements:
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            • requirement satisfiedLint
            • requirement is not satisfiedNo-Unresolved-Comments
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: refs/branch-heads/7827
            Gerrit-Change-Id: If0e81862934661e611c83ec39b5a594363598915
            Gerrit-Change-Number: 7848205
            Gerrit-PatchSet: 21
            Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
            Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
            Gerrit-Reviewer: Vincent Boisselle <vi...@google.com>
            Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
            Gerrit-CC: AyeAye Python Dispatcher <android-build-ayeay...@system.gserviceaccount.com>
            Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
            Gerrit-Attention: Qihui Zhao <qihu...@google.com>
            Gerrit-Comment-Date: Mon, 18 May 2026 10:41:04 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages