[Cast Streaming] Disable HiDPI + Mirroring [chromium/src : main]
Jordan Bayles (Gerrit)
Attention is currently required from: Mark Foltz.
Jordan Bayles would like Mark Foltz to review this change.
[Cast Streaming] Disable HiDPI + Mirroring
This patch disables HiDPI during mirroring sessions by default, and puts
this feature behind a new Chrome flag:
\#enable-cast-streaming-with-hidpi
Bug: 1412589
Change-Id: I382c41d638454323fa22af3b0463077d10090a01
---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M components/mirroring/service/mirror_settings.cc
M components/mirroring/service/mirroring_features.cc
M components/mirroring/service/mirroring_features.h
M content/browser/media/capture/web_contents_frame_tracker.cc
M content/browser/media/capture/web_contents_frame_tracker.h
M content/browser/media/capture/web_contents_frame_tracker_unittest.cc
M content/browser/media/capture/web_contents_video_capture_device.cc
M media/capture/video_capture_types.cc
M media/capture/video_capture_types.h
M tools/metrics/histograms/enums.xml
14 files changed, 75 insertions(+), 10 deletions(-)
To view, visit change 4220235. To unsubscribe, or for help writing mail filters, visit settings.
Jordan Bayles (Gerrit)
Attention is currently required from: Mark Foltz.
Patch set 3:Commit-Queue +1
Mark Foltz (Gerrit)
Attention is currently required from: Jordan Bayles.
3 comments:
Patchset:
Overall looks good but I think there are mojo traits that need to be updated for the video capture parameters.
File content/browser/media/capture/web_contents_frame_tracker.cc:
Patch Set #4, Line 272:
if (!is_high_dpi_enabled_) {Should this check go on line 193, where we check the feature flag for HiDPI?
File media/capture/video_capture_types.h:
Patch Set #4, Line 352:
// sessions. Currently only applicable to tab mirroring.The last sentence doesn't quite follow, this flag actually applies to all tab capture sessions.
To view, visit change 4220235. To unsubscribe, or for help writing mail filters, visit settings.
Jordan Bayles (Gerrit)
Attention is currently required from: Mark Foltz.
Patch set 6:Commit-Queue +1
3 comments:
Patchset:
Overall looks good but I think there are mojo traits that need to be updated for the video capture p […]
Yeah definitely.
File content/browser/media/capture/web_contents_frame_tracker.cc:
Patch Set #4, Line 272:
if (!is_high_dpi_enabled_) {Should this check go on line 193, where we check the feature flag for HiDPI?
Yeah, definitely.
File media/capture/video_capture_types.h:
Patch Set #4, Line 352:
// sessions. Currently only applicable to tab mirroring.The last sentence doesn't quite follow, this flag actually applies to all tab capture sessions.
Done
To view, visit change 4220235. To unsubscribe, or for help writing mail filters, visit settings.
Jordan Bayles (Gerrit)
Attention is currently required from: Chromium IPC Reviews, Mark Foltz.
Jordan Bayles would like Chromium IPC Reviews to review this change.
[Cast Streaming] Disable HiDPI + Mirroring
This patch disables HiDPI during mirroring sessions by default, and puts
this feature behind a new Chrome flag:
\#enable-cast-streaming-with-hidpi
Bug: 1412589
Change-Id: I382c41d638454323fa22af3b0463077d10090a01
---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M components/mirroring/service/mirror_settings.cc
M components/mirroring/service/mirroring_features.cc
M components/mirroring/service/mirroring_features.h
M content/browser/media/capture/web_contents_frame_tracker.cc
M content/browser/media/capture/web_contents_frame_tracker.h
M content/browser/media/capture/web_contents_frame_tracker_unittest.cc
M content/browser/media/capture/web_contents_video_capture_device.cc
M media/capture/mojom/video_capture_types.mojom
M media/capture/mojom/video_capture_types_mojom_traits.cc
M media/capture/mojom/video_capture_types_mojom_traits.h
M media/capture/video_capture_types.cc
M media/capture/video_capture_types.h
M tools/metrics/histograms/enums.xml
17 files changed, 83 insertions(+), 11 deletions(-)
Findit (Gerrit)
Attention is currently required from: Chromium IPC Reviews, Mark Foltz.
Patch set 6:Code-Coverage +1
gwsq (Gerrit)
Attention is currently required from: Chromium IPC Reviews, Mark Foltz, Mustafa Emre Acer.
gwsq would like Mustafa Emre Acer to review this change authored by Jordan Bayles.
To view, visit change 4220235. To unsubscribe, or for help writing mail filters, visit settings.
gwsq (Gerrit)
Attention is currently required from: Mark Foltz, Mustafa Emre Acer.
Jordan Bayles has uploaded this change for review.
gwsq (Gerrit)
Attention is currently required from: Mark Foltz, Mustafa Emre Acer.
From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mea...@chromium.org
📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).
IPC reviewer(s): mea...@chromium.org
Reviewer source(s):
mea...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)
Mark Foltz (Gerrit)
Attention is currently required from: Jordan Bayles, Mustafa Emre Acer.
Patch set 6:Code-Review +1
Mustafa Emre Acer (Gerrit)
Attention is currently required from: Jordan Bayles.
Patch set 6:Code-Review +1
To view, visit change 4220235. To unsubscribe, or for help writing mail filters, visit settings.
Jordan Bayles (Gerrit)
Attention is currently required from: Jordan Bayles.
Patch set 6:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
[Cast Streaming] Disable HiDPI + Mirroring
This patch disables HiDPI during mirroring sessions by default, and puts
this feature behind a new Chrome flag:
\#enable-cast-streaming-with-hidpi
Bug: 1412589
Change-Id: I382c41d638454323fa22af3b0463077d10090a01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4220235
Code-Coverage: Findit <findit...@appspot.gserviceaccount.com>
Commit-Queue: Jordan Bayles <jop...@chromium.org>
Reviewed-by: Mark Foltz <mfo...@chromium.org>
Reviewed-by: Mustafa Emre Acer <mea...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1103101}
---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M components/mirroring/service/mirror_settings.cc
M components/mirroring/service/mirroring_features.cc
M components/mirroring/service/mirroring_features.h
M content/browser/media/capture/web_contents_frame_tracker.cc
M content/browser/media/capture/web_contents_frame_tracker.h
M content/browser/media/capture/web_contents_frame_tracker_unittest.cc
M content/browser/media/capture/web_contents_video_capture_device.cc
M media/capture/mojom/video_capture_types.mojom
M media/capture/mojom/video_capture_types_mojom_traits.cc
M media/capture/mojom/video_capture_types_mojom_traits.h
M media/capture/video_capture_types.cc
M media/capture/video_capture_types.h
M tools/metrics/histograms/enums.xml
17 files changed, 89 insertions(+), 11 deletions(-)