ash: Remove a Browser/-List dependency from dlp code [chromium/src : main]

0 views

Skip to first unread message

Georg Neis (Gerrit)

unread,

Dec 22, 2025, 3:00:06 AM (6 days ago) Dec 22

to Hidehiko Abe, Enterprise Policy Reviews, Simon Hangl, Andrew Rayskiy, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, extension...@chromium.org, chfreme...@chromium.org, stluon...@chromium.org, performance-m...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org, chromium-a...@chromium.org, oshima...@chromium.org

Attention needed from Hidehiko Abe

Georg Neis added 1 comment

File chrome/browser/ash/browser_delegate/browser_controller.cc

Line 17, Patchset 8: CHECK(g_browser_controller);

Georg Neis . unresolved

We currently don't need a "has instance?", so I'm adding this CHECK to get better error messages.

Open in Gerrit

Related details

Attention is currently required from:

Hidehiko Abe

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hidehiko Abe (Gerrit)

unread,

Dec 26, 2025, 2:30:46 AM (yesterday) Dec 26

to Georg Neis, Code Review Nudger, Enterprise Policy Reviews, Simon Hangl, Andrew Rayskiy, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, dewitt...@chromium.org, extension...@chromium.org, chfreme...@chromium.org, stluon...@chromium.org, performance-m...@chromium.org, feature-me...@chromium.org, rmcelra...@chromium.org, chromium-a...@chromium.org, oshima...@chromium.org

Attention needed from Georg Neis

Hidehiko Abe added 2 comments

File chrome/browser/ash/browser_delegate/browser_controller.cc

Line 17, Patchset 8: CHECK(g_browser_controller);

Georg Neis . resolved

We currently don't need a "has instance?", so I'm adding this CHECK to get better error messages.

Hidehiko Abe

Acknowledged

File chrome/browser/chromeos/policy/dlp/dlp_content_manager.cc

Line 607, Patchset 9 (Parent):void DlpContentManager::OnBrowserRemoved(Browser* browser) {

Hidehiko Abe . unresolved

clarification: when the added observer should be removed...?