Ravjit Uppal (Gerrit)

unread,

Aug 3, 2026, 8:19:33 AM (2 days ago) Aug 3

to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Ravjit Uppal

Message from Ravjit Uppal

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

Ravjit Uppal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Nguyen (Gerrit)

unread,

Aug 3, 2026, 11:46:29 AM (2 days ago) Aug 3

to Ravjit Uppal, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Ravjit Uppal

Thomas Nguyen added 2 comments

File third_party/blink/web_tests/external/wpt/html/semantics/permission-element/bounded-sizes-reftest.tentative.html

Line 75, Patchset 8 (Latest): document.documentElement.classList.remove('reftest-wait');

Thomas Nguyen . unresolved

Do we need this? I thought that if we have the type = camera + mic from the beginning we should not need this

File third_party/blink/web_tests/external/wpt/html/semantics/permission-element/large-min-size-reftest.tentative.html

Line 36, Patchset 8 (Latest): requestAnimationFrame(() => {

Thomas Nguyen . unresolved

Ditto, and all other places

Open in Gerrit

Related details

Attention is currently required from:

Ravjit Uppal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ravjit Uppal (Gerrit)

unread,

Aug 4, 2026, 10:02:31 AM (21 hours ago) Aug 4

to Thomas Nguyen, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Thomas Nguyen

Ravjit Uppal added 1 comment

File third_party/blink/web_tests/external/wpt/html/semantics/permission-element/bounded-sizes-reftest.tentative.html

Line 75, Patchset 8 (Latest): document.documentElement.classList.remove('reftest-wait');

Thomas Nguyen . unresolved

Do we need this? I thought that if we have the type = camera + mic from the beginning we should not need this

Ravjit Uppal

The permission_descriptors_ are still set asynchronously. That part of the code can only be made synchronous once we remove the type attribute check from the isLegacy() method.
I want to land this first before making that change.

Open in Gerrit

Related details

Attention is currently required from:

Thomas Nguyen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Nguyen (Gerrit)

unread,

5:09 AM (2 hours ago) 5:09 AM

to Ravjit Uppal, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Ravjit Uppal

Thomas Nguyen voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Ravjit Uppal

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Nguyen (Gerrit)

unread,

5:09 AM (2 hours ago) 5:09 AM

to Ravjit Uppal, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, jmedle...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

Attention needed from Ravjit Uppal

Thomas Nguyen added 2 comments

File third_party/blink/web_tests/external/wpt/html/semantics/permission-element/bounded-sizes-reftest.tentative.html

Line 75, Patchset 8 (Latest): document.documentElement.classList.remove('reftest-wait');

Thomas Nguyen . resolved

Do we need this? I thought that if we have the type = camera + mic from the beginning we should not need this

Ravjit Uppal

The permission_descriptors_ are still set asynchronously. That part of the code can only be made synchronous once we remove the type attribute check from the isLegacy() method.
I want to land this first before making that change.

Thomas Nguyen

Thanks

File third_party/blink/web_tests/external/wpt/html/semantics/permission-element/large-min-size-reftest.tentative.html

Line 36, Patchset 8 (Latest): requestAnimationFrame(() => {

Thomas Nguyen . resolved

Ditto, and all other places

Thomas Nguyen

Done

Open in Gerrit

Related details

Attention is currently required from:

Ravjit Uppal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[CE] Run <usermedia> WPTs with the correct feature flags. [chromium/src : main]

Ravjit Uppal (Gerrit)

Message from Ravjit Uppal

Related details

Thomas Nguyen (Gerrit)

Thomas Nguyen added 2 comments

Related details

Ravjit Uppal (Gerrit)

Ravjit Uppal added 1 comment

Related details

Thomas Nguyen (Gerrit)

Thomas Nguyen voted Code-Review+1

Related details

Thomas Nguyen (Gerrit)

Thomas Nguyen added 2 comments

Related details