[contextual_tasks] Added Images section for sources menu [chromium/src : main]

0 views
Skip to first unread message

Shakti Sahu (Gerrit)

unread,
Jan 20, 2026, 7:39:28 PM (7 hours ago) Jan 20
to Kevin Shah, Kentaro Hara, Dirk Schulze, Raphael Kubo da Costa, Menard, Alexis, Mirko Bonadei, Jerome Jiang, Stephen Chenney, Chromium Metrics Reviews, Olga Gerchikov, AyeAye, Demetrios Papadopoulos, Alex Gough, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, drott+bl...@chromium.org, jmedle...@chromium.org, jdonnel...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, bfcach...@chromium.org, feature-v...@chromium.org, feature-me...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, andysjl...@chromium.org, jz...@chromium.org, media-cro...@chromium.org, blink-rev...@chromium.org, dewitt...@chromium.org, loading...@chromium.org, fuzzin...@chromium.org, christia...@chromium.org, niharm...@google.com, blink-reviews-p...@chromium.org, chrome-intelligence-te...@google.com, blink-revie...@chromium.org, csharris...@chromium.org, chromeos-gfx-...@google.com, blink-...@chromium.org, xinghui...@chromium.org, mattreyno...@chromium.org, blink-re...@chromium.org, lwinston+watc...@google.com, speed-metr...@chromium.org, apavlo...@chromium.org, odejesu...@chromium.org, creis...@chromium.org, bmcquad...@chromium.org, blink-revie...@chromium.org, lens-chrome...@google.com, mercer...@google.com, gavinp...@chromium.org, nwoked...@chromium.org, fmalit...@chromium.org, omnibox-...@chromium.org, vakh+safe_br...@chromium.org, blink-re...@chromium.org, zackha...@chromium.org, chrome-intell...@chromium.org, mfoltz+wa...@chromium.org, pdf-r...@chromium.org, stanfie...@google.com, chromotin...@chromium.org, navigation...@chromium.org, jatapiaro+wat...@google.com, loading-rev...@chromium.org, fgal...@chromium.org, fserb...@chromium.org, scheduler...@chromium.org, blink-rev...@chromium.org, asvitki...@chromium.org, mar...@chromium.org, kinuko+...@chromium.org, trewin...@google.com, chikamu...@chromium.org, cros-ed...@google.com, druber...@chromium.org, blink-revie...@chromium.org, performance-m...@chromium.org, kinuko...@chromium.org
Attention needed from Alex Gough and Demetrios Papadopoulos

Shakti Sahu added 1 comment

Patchset-level comments
File-level comment, Patchset 23:
Demetrios Papadopoulos . unresolved

LGTM with nits, but also see CodeCoverage warnings about low coverage.

Demetrios Papadopoulos

Marking this unresolved to make sure it is not missed. Do you plan to address the code coverage warnings? Or did they go away somehow?

Shakti Sahu

Thanks for flagging this. Filed b/477384509 to address this. We can have unit test that direclty instantiate the page handler.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
  • Demetrios Papadopoulos
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0c0d6e2276ffa76b7d42e11bc7c9441c66f289b7
Gerrit-Change-Number: 7369900
Gerrit-PatchSet: 27
Gerrit-Owner: Kevin Shah <kevi...@google.com>
Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Kevin Shah <kevi...@google.com>
Gerrit-Reviewer: Shakti Sahu <shakt...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Attention: Alex Gough <aj...@chromium.org>
Gerrit-Comment-Date: Wed, 21 Jan 2026 00:39:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Demetrios Papadopoulos <dpa...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Demetrios Papadopoulos (Gerrit)

unread,
Jan 20, 2026, 7:45:56 PM (6 hours ago) Jan 20
to Kevin Shah, Kentaro Hara, Dirk Schulze, Raphael Kubo da Costa, Menard, Alexis, Mirko Bonadei, Jerome Jiang, Stephen Chenney, Chromium Metrics Reviews, Olga Gerchikov, AyeAye, Shakti Sahu, Alex Gough, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, drott+bl...@chromium.org, jmedle...@chromium.org, jdonnel...@chromium.org, oshima...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, bfcach...@chromium.org, feature-v...@chromium.org, feature-me...@chromium.org, alexmo...@chromium.org, storage...@chromium.org, andysjl...@chromium.org, jz...@chromium.org, media-cro...@chromium.org, blink-rev...@chromium.org, dewitt...@chromium.org, loading...@chromium.org, fuzzin...@chromium.org, christia...@chromium.org, niharm...@google.com, blink-reviews-p...@chromium.org, chrome-intelligence-te...@google.com, blink-revie...@chromium.org, csharris...@chromium.org, chromeos-gfx-...@google.com, blink-...@chromium.org, xinghui...@chromium.org, mattreyno...@chromium.org, blink-re...@chromium.org, lwinston+watc...@google.com, speed-metr...@chromium.org, apavlo...@chromium.org, odejesu...@chromium.org, creis...@chromium.org, bmcquad...@chromium.org, blink-revie...@chromium.org, lens-chrome...@google.com, mercer...@google.com, gavinp...@chromium.org, nwoked...@chromium.org, fmalit...@chromium.org, omnibox-...@chromium.org, vakh+safe_br...@chromium.org, blink-re...@chromium.org, zackha...@chromium.org, chrome-intell...@chromium.org, mfoltz+wa...@chromium.org, pdf-r...@chromium.org, stanfie...@google.com, chromotin...@chromium.org, navigation...@chromium.org, jatapiaro+wat...@google.com, loading-rev...@chromium.org, fgal...@chromium.org, fserb...@chromium.org, scheduler...@chromium.org, blink-rev...@chromium.org, asvitki...@chromium.org, mar...@chromium.org, kinuko+...@chromium.org, trewin...@google.com, chikamu...@chromium.org, cros-ed...@google.com, druber...@chromium.org, blink-revie...@chromium.org, performance-m...@chromium.org, kinuko...@chromium.org
Attention needed from Alex Gough and Kevin Shah

Demetrios Papadopoulos voted and added 1 comment

Votes added by Demetrios Papadopoulos

Code-Review+1

1 comment

Patchset-level comments
Demetrios Papadopoulos . unresolved

LGTM with nits, but also see CodeCoverage warnings about low coverage.

Demetrios Papadopoulos

Marking this unresolved to make sure it is not missed. Do you plan to address the code coverage warnings? Or did they go away somehow?

Shakti Sahu

Thanks for flagging this. Filed b/477384509 to address this. We can have unit test that direclty instantiate the page handler.

Demetrios Papadopoulos

Thanks for filing. BTW, is there a reason to prefer the internal bug tracker for all things related to this feature? Note that Chromium is primarily an open source project and the open source tracker should be preferred unless there is a good reason.

See https://www.chromium.org/issue-tracking/googler-guidelines/#guidelines and specifically the part that says

**"Bugs should be open by default, unless there is specific information that should be restricted to Googlers. Chromium is an open-source project."**

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
  • Kevin Shah
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Kevin Shah <kevi...@google.com>
    Gerrit-Attention: Alex Gough <aj...@chromium.org>
    Gerrit-Comment-Date: Wed, 21 Jan 2026 00:45:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Shakti Sahu <shakt...@chromium.org>
    Comment-In-Reply-To: Demetrios Papadopoulos <dpa...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages