Add desktop_to_ios_promo_receiving_enabled to DeviceInfo [chromium/src : main]

0 views
Skip to first unread message

Hira Mahmood (Gerrit)

unread,
Dec 22, 2025, 12:49:29 AM (6 days ago) Dec 22
to Chromium Sync Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org, chrome-tab-group-en...@google.com, derinel+wat...@google.com, dfried...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jeffreycohen+watc...@chromium.org, knollr+wat...@chromium.org, marq+...@chromium.org, tgupta...@chromium.org, webauthn...@chromium.org
Attention needed from Chromium Sync Reviews

Hira Mahmood added 1 comment

Patchset-level comments
File-level comment, Patchset 11 (Latest):
Hira Mahmood . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Chromium Sync Reviews
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib51e77f52c181e2eba4b543f81136f4a7ebc5599
Gerrit-Change-Number: 7276213
Gerrit-PatchSet: 11
Gerrit-Owner: Hira Mahmood <hiram...@google.com>
Gerrit-Reviewer: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
Gerrit-Attention: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 05:49:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Dec 22, 2025, 12:52:57 AM (6 days ago) Dec 22
to Hira Mahmood, Chromium Sync Reviews, Jood Hajeer, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org, chrome-tab-group-en...@google.com, derinel+wat...@google.com, dfried...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jeffreycohen+watc...@chromium.org, knollr+wat...@chromium.org, marq+...@chromium.org, tgupta...@chromium.org, webauthn...@chromium.org
Attention needed from Jood Hajeer

Message from gwsq

Reviewer source(s):
jo...@google.com is from context(googleclient/chrome/chromium_gwsq/components/sync/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Jood Hajeer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib51e77f52c181e2eba4b543f81136f4a7ebc5599
Gerrit-Change-Number: 7276213
Gerrit-PatchSet: 11
Gerrit-Owner: Hira Mahmood <hiram...@google.com>
Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
Gerrit-Reviewer: Jood Hajeer <jo...@google.com>
Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Jood Hajeer <jo...@google.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 05:52:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hira Mahmood (Gerrit)

unread,
Dec 22, 2025, 1:00:03 AM (6 days ago) Dec 22
to Chromium Sync Reviews, Jood Hajeer, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org, chrome-tab-group-en...@google.com, derinel+wat...@google.com, dfried...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jeffreycohen+watc...@chromium.org, knollr+wat...@chromium.org, marq+...@chromium.org, tgupta...@chromium.org, webauthn...@chromium.org
Attention needed from Jood Hajeer

Hira Mahmood voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jood Hajeer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib51e77f52c181e2eba4b543f81136f4a7ebc5599
Gerrit-Change-Number: 7276213
Gerrit-PatchSet: 11
Gerrit-Owner: Hira Mahmood <hiram...@google.com>
Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
Gerrit-Reviewer: Jood Hajeer <jo...@google.com>
Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Jood Hajeer <jo...@google.com>
Gerrit-Comment-Date: Mon, 22 Dec 2025 05:59:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jood Hajeer (Gerrit)

unread,
Dec 23, 2025, 10:02:31 AM (4 days ago) Dec 23
to Hira Mahmood, Chromium Sync Reviews, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org, chrome-tab-group-en...@google.com, derinel+wat...@google.com, dfried...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jeffreycohen+watc...@chromium.org, knollr+wat...@chromium.org, marq+...@chromium.org, tgupta...@chromium.org, webauthn...@chromium.org
Attention needed from Hira Mahmood

Jood Hajeer added 2 comments

Patchset-level comments
Jood Hajeer . resolved

Thanks, LGTM, with a request to add a test.

File chrome/browser/ui/promos/ios_promo_controller.cc
Line 131, Patchset 11 (Latest): device->desktop_to_ios_promo_receiving_enabled() &&
Jood Hajeer . unresolved

This logical change to depend on the flag value to display the promos is not tested, could you please add tests for this?

Open in Gerrit

Related details

Attention is currently required from:
  • Hira Mahmood
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib51e77f52c181e2eba4b543f81136f4a7ebc5599
    Gerrit-Change-Number: 7276213
    Gerrit-PatchSet: 11
    Gerrit-Owner: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Jood Hajeer <jo...@google.com>
    Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Hira Mahmood <hiram...@google.com>
    Gerrit-Comment-Date: Tue, 23 Dec 2025 15:02:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hira Mahmood (Gerrit)

    unread,
    Dec 26, 2025, 5:48:02 PM (yesterday) Dec 26
    to Chromium Sync Reviews, Jood Hajeer, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, oshima...@chromium.org, chrome-tab-group-en...@google.com, derinel+wat...@google.com, dfried...@chromium.org, estali...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jeffreycohen+watc...@chromium.org, knollr+wat...@chromium.org, marq+...@chromium.org, tgupta...@chromium.org, webauthn...@chromium.org
    Attention needed from Jood Hajeer

    Hira Mahmood added 1 comment

    File chrome/browser/ui/promos/ios_promo_controller.cc
    Line 131, Patchset 11: device->desktop_to_ios_promo_receiving_enabled() &&
    Jood Hajeer . resolved

    This logical change to depend on the flag value to display the promos is not tested, could you please add tests for this?

    Hira Mahmood

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jood Hajeer
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib51e77f52c181e2eba4b543f81136f4a7ebc5599
    Gerrit-Change-Number: 7276213
    Gerrit-PatchSet: 12
    Gerrit-Owner: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Jood Hajeer <jo...@google.com>
    Gerrit-CC: Chromium Sync Reviews <chromium-s...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Jood Hajeer <jo...@google.com>
    Gerrit-Comment-Date: Fri, 26 Dec 2025 22:47:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jood Hajeer <jo...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages