[CE] Update setConstraints() for single track capability elements [chromium/src : main]

[Ravjit Uppal (Gerrit)]

Attention needed from Joey Arhar and Thomas Nguyen

Ravjit Uppal voted and added 3 comments

Votes added by Ravjit Uppal

Commit-Queue

+1

3 comments

File third_party/blink/renderer/modules/mediastream/html_media_track_element_media_track.h

Line 26, Patchset 3 (Latest): public Supplement<HTMLMediaCaptureElementBase> {

Ravjit Uppal . resolved

Updated this to adhere to Blink's pattern of anchoring supplements to the root Supplementable<T> class.

File third_party/blink/renderer/modules/mediastream/media_capture_element_constraints.h

Line 1, Patchset 3 (Latest):// Copyright 2026 The Chromium Authors

Ravjit Uppal . resolved

Gerrit doesn't pick up but this is just a renamed file.

File third_party/blink/renderer/modules/mediastream/media_capture_element_constraints.cc

Line 130, Patchset 3 (Latest): if (self.DidSetConstraints()) {

Ravjit Uppal . unresolved

@Thomas: Should we allow overwriting constraints_?
If a web developer calls cam.setConstraints(...) multiple times before the user clicks the <usermedia> element (for example, updating { deviceId: ... } when a user selects a different camera in a UI dropdown), any call after the first is silently ignored.

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar
• Thomas Nguyen

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I957025af6202b5541a3de563f66af50e5a4da199

Gerrit-Change-Number: 8142265

Gerrit-PatchSet: 3

Gerrit-Owner: Ravjit Uppal <rav...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Tue, 04 Aug 2026 15:10:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Thomas Nguyen (Gerrit)]

Attention needed from Joey Arhar and Ravjit Uppal

Thomas Nguyen added 1 comment

File third_party/blink/renderer/modules/mediastream/media_capture_element_constraints.cc

Line 130, Patchset 3: if (self.DidSetConstraints()) {

Ravjit Uppal . unresolved

@Thomas: Should we allow overwriting constraints_?
If a web developer calls cam.setConstraints(...) multiple times before the user clicks the <usermedia> element (for example, updating { deviceId: ... } when a user selects a different camera in a UI dropdown), any call after the first is silently ignored.

Thomas Nguyen

Yeah, that make senses, as we moved the filter calling right before handling click

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar
• Ravjit Uppal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I957025af6202b5541a3de563f66af50e5a4da199

Gerrit-Change-Number: 8142265

Gerrit-PatchSet: 4

Gerrit-Owner: Ravjit Uppal <rav...@chromium.org>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>

Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>

Gerrit-CC: Kentaro Hara <har...@chromium.org>

Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>

Gerrit-Attention: Ravjit Uppal <rav...@chromium.org>

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Comment-Date: Wed, 05 Aug 2026 09:11:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ravjit Uppal <rav...@chromium.org>

[Thomas Nguyen (Gerrit)]

Attention needed from Joey Arhar and Ravjit Uppal

Thomas Nguyen added 1 comment

File third_party/blink/renderer/modules/mediastream/media_capture_element_constraints.cc

Line 130, Patchset 3: if (self.DidSetConstraints()) {

Ravjit Uppal . unresolved

@Thomas: Should we allow overwriting constraints_?
If a web developer calls cam.setConstraints(...) multiple times before the user clicks the <usermedia> element (for example, updating { deviceId: ... } when a user selects a different camera in a UI dropdown), any call after the first is silently ignored.

Thomas Nguyen

Yeah, that make senses, as we moved the filter calling right before handling click

Thomas Nguyen

I am open to either doing this now or handling it in a follow-up discussion. It's up to you.

Gerrit-Comment-Date: Wed, 05 Aug 2026 09:12:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Ravjit Uppal <rav...@chromium.org>

Comment-In-Reply-To: Thomas Nguyen <tun...@chromium.org>