Clean up kWebRtcAllowWgcScreenCapturer feature flag [chromium/src : main]
0 views
Skip to first unread message
Steve Becker (Gerrit)
Sep 17, 2025, 2:17:55 PM (3 days ago) Sep 17
to Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Steve Becker voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olga Sharonova (Gerrit)
Sep 18, 2025, 4:26:46 AM (3 days ago) Sep 18
to Steve Becker, Henrik Andreasson, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Attention needed from Henrik Andreasson and Steve Becker
Olga Sharonova added 1 comment![]( "Open in Gerrit")
File media/webrtc/webrtc_features.cc
Line 35, Patchset 1 (Parent):
// This flag only has an effect if kWebRtcAllowWgcWindowCapturer is enabled.
BASE_FEATURE(kWebRtcAllowWgcWindowZeroHz,
"AllowWgcWindowZeroHz",
base::FEATURE_ENABLED_BY_DEFAULT);Olga Sharonova . unresolved
What about this one?
Related details
Attention is currently required from:
- Henrik Andreasson
- Steve Becker
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Henrik Andreasson (Gerrit)
Sep 18, 2025, 5:44:35 AM (3 days ago) Sep 18
to Steve Becker, Olga Sharonova, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Attention needed from Steve Becker
Henrik Andreasson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Henrik Andreasson
| Code-Review | +1 |
1 comment
File media/webrtc/webrtc_features.cc
Line 35, Patchset 1 (Parent):
// This flag only has an effect if kWebRtcAllowWgcWindowCapturer is enabled.
BASE_FEATURE(kWebRtcAllowWgcWindowZeroHz,
"AllowWgcWindowZeroHz",
base::FEATURE_ENABLED_BY_DEFAULT);Olga Sharonova . unresolved
What about this one?
Henrik Andreasson
I'd say it can be removed as well but it is not as trivial as for the other flag which is not used at all.
This flag is used in [1].
I propose to start by removing the "dead" kWebRtcAllowWgcWindowCapturer and then see how complex it is to also remove kWebRtcAllowWgcWindowZeroHz in a separate CL.
Related details
Attention is currently required from:
- Steve Becker
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olga Sharonova (Gerrit)
Sep 18, 2025, 8:46:01 AM (3 days ago) Sep 18
to Steve Becker, Alexander Cooper, Henrik Andreasson, Olga Sharonova, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Attention needed from Alexander Cooper and Steve Becker
Olga Sharonova added 1 comment![]( "Open in Gerrit")
File media/webrtc/webrtc_features.cc
Line 35, Patchset 1 (Parent):
// This flag only has an effect if kWebRtcAllowWgcWindowCapturer is enabled.
BASE_FEATURE(kWebRtcAllowWgcWindowZeroHz,
"AllowWgcWindowZeroHz",
base::FEATURE_ENABLED_BY_DEFAULT);Olga Sharonova . unresolved
Henrik AndreassonWhat about this one?
I'd say it can be removed as well but it is not as trivial as for the other flag which is not used at all.
This flag is used in [1].
I propose to start by removing the "dead" kWebRtcAllowWgcWindowCapturer and then see how complex it is to also remove kWebRtcAllowWgcWindowZeroHz in a separate CL.
Olga Sharonova
How do you suggest to deal with "This flag only has an effect if kWebRtcAllowWgcScreenCapturer is enabled." comment?
Related details
Attention is currently required from:
- Alexander Cooper
- Steve Becker
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Henrik Andreasson (Gerrit)
Sep 18, 2025, 8:49:09 AM (3 days ago) Sep 18
to Steve Becker, Olga Sharonova, Alexander Cooper, Olga Sharonova, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Attention needed from Alexander Cooper and Steve Becker
Henrik Andreasson added 1 comment![]( "Open in Gerrit")
File media/webrtc/webrtc_features.cc
Line 35, Patchset 1 (Parent):
// This flag only has an effect if kWebRtcAllowWgcWindowCapturer is enabled.
BASE_FEATURE(kWebRtcAllowWgcWindowZeroHz,
"AllowWgcWindowZeroHz",
base::FEATURE_ENABLED_BY_DEFAULT);Olga Sharonova . unresolved
Henrik AndreassonWhat about this one?
Olga SharonovaI'd say it can be removed as well but it is not as trivial as for the other flag which is not used at all.
This flag is used in [1].
I propose to start by removing the "dead" kWebRtcAllowWgcWindowCapturer and then see how complex it is to also remove kWebRtcAllowWgcWindowZeroHz in a separate CL.
How do you suggest to deal with "This flag only has an effect if kWebRtcAllowWgcScreenCapturer is enabled." comment?
Henrik Andreasson
Thanks. That comment should be removed.
Alexander Cooper (Gerrit)
Sep 18, 2025, 12:33:31 PM (2 days ago) Sep 18
to Steve Becker, Olga Sharonova, Henrik Andreasson, Olga Sharonova, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Attention needed from Steve Becker
Alexander Cooper voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alexander Cooper
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alexander Cooper . resolved
LGTM w/comment removal per henrik's last comment.
Related details
Attention is currently required from:
- Steve Becker
Steve Becker (Gerrit)
Sep 18, 2025, 1:02:28 PM (2 days ago) Sep 18
to Alexander Cooper, Olga Sharonova, Henrik Andreasson, Olga Sharonova, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Attention needed from Olga Sharonova and Olga Sharonova
Steve Becker voted and added 1 comment![]( "Open in Gerrit")
Votes added by Steve Becker
| Commit-Queue | +2 |
1 comment
File media/webrtc/webrtc_features.cc
Line 35, Patchset 1 (Parent):
// This flag only has an effect if kWebRtcAllowWgcWindowCapturer is enabled.
BASE_FEATURE(kWebRtcAllowWgcWindowZeroHz,
"AllowWgcWindowZeroHz",
base::FEATURE_ENABLED_BY_DEFAULT);Olga Sharonova . resolved
Henrik AndreassonWhat about this one?
Olga SharonovaI'd say it can be removed as well but it is not as trivial as for the other flag which is not used at all.
This flag is used in [1].
I propose to start by removing the "dead" kWebRtcAllowWgcWindowCapturer and then see how complex it is to also remove kWebRtcAllowWgcWindowZeroHz in a separate CL.
Henrik AndreassonHow do you suggest to deal with "This flag only has an effect if kWebRtcAllowWgcScreenCapturer is enabled." comment?
Thanks. That comment should be removed.
Steve Becker
Good catch. I can try to remove kWebRtcAllowWgcWindowCapturer in a separate change.
Related details
Attention is currently required from:
- Olga Sharonova
- Olga Sharonova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olga Sharonova (Gerrit)
Sep 19, 2025, 4:56:33 AM (yesterday) Sep 19
to Steve Becker, Alexander Cooper, Olga Sharonova, Henrik Andreasson, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Attention needed from Olga Sharonova and Steve Becker
Olga Sharonova voted and added 1 comment![]( "Open in Gerrit")
Votes added by Olga Sharonova
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Olga Sharonova . resolved
Apologies for a delay - I though it had all the required approvals!
Related details
Attention is currently required from:
- Olga Sharonova
- Steve Becker
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Steve Becker (Gerrit)
Sep 19, 2025, 1:09:13 PM (yesterday) Sep 19
to Olga Sharonova, Alexander Cooper, Olga Sharonova, Henrik Andreasson, Chromium LUCI CQ, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Attention needed from Olga Sharonova
Steve Becker voted and added 1 comment![]( "Open in Gerrit")
Votes added by Steve Becker
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Steve Becker . resolved
Thanks for the reviews.
Related details
Attention is currently required from:
- Olga Sharonova
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 19, 2025, 2:14:00 PM (yesterday) Sep 19
to Steve Becker, Olga Sharonova, Alexander Cooper, Olga Sharonova, Henrik Andreasson, Ale Bzk, chromium...@chromium.org, Per Åhgren, Sam Zackrisson, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Clean up kWebRtcAllowWgcScreenCapturer feature flag
... since it's unused and on by default.
Bug: 40259177
Change-Id: I05f74b0edb4ec8642ee29d8a1fd6db435a29564e
Reviewed-by: Olga Sharonova <ol...@chromium.org>
Reviewed-by: Alexander Cooper <alco...@chromium.org>
Commit-Queue: Steve Becker <ste...@microsoft.com>
Reviewed-by: Henrik Andreasson <hen...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1518078}
Files:
- M media/webrtc/webrtc_features.cc
- M media/webrtc/webrtc_features.h
Change size: S
Delta: 2 files changed, 0 insertions(+), 10 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Olga Sharonova, +1 by Henrik Andreasson, +1 by Alexander Cooper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages