Added timing tracker for DRM initialization speed test. [chromium/src : main]

0 views
Skip to first unread message

Antonio Rivera (Gerrit)

unread,
Nov 10, 2025, 1:34:00 PM (2 days ago) Nov 10
to Eusden Lin, Shawn Quereshi, chromium...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org
Attention needed from Eusden Lin and Shawn Quereshi

Antonio Rivera voted and added 1 comment

Votes added by Antonio Rivera

Code-Review+1

1 comment

File chromecast/starboard/media/cdm/starboard_drm_wrapper.cc
Line 453, Patchset 2 (Latest):
Antonio Rivera . unresolved

If the intention here is only to measure the initialization time of the SbDrmSystem itself, would it make sense to move the CHROMECAST_TIMING_TRACKER to this line? CreateDrmSystem is what calls Starboard to construct the SbDrmSystem.

If you wanted to be really precise (and avoid the timing of our logging), you could even wrap it in curly braces to trigger destruction early, e.g.
```
{
  CHROMECAST_TIMING_TRACKER;
  drm_system_ = starboard_->CreateDrmSystem(
      /*key_system=*/"com.widevine.alpha",
      /*callback_handler=*/&callback_handler_);
}  // the timing tracker is destructed
```
Open in Gerrit

Related details

Attention is currently required from:
  • Eusden Lin
  • Shawn Quereshi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iffae15d32ee2056d9e3706af22e3b4a8fefc0505
Gerrit-Change-Number: 7138221
Gerrit-PatchSet: 2
Gerrit-Owner: Eusden Lin <eusd...@google.com>
Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Eusden Lin <eusd...@google.com>
Gerrit-Comment-Date: Mon, 10 Nov 2025 18:33:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eusden Lin (Gerrit)

unread,
Nov 11, 2025, 4:52:55 AM (yesterday) Nov 11
to Antonio Rivera, Shawn Quereshi, chromium...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org
Attention needed from Antonio Rivera and Shawn Quereshi

Eusden Lin added 1 comment

File chromecast/starboard/media/cdm/starboard_drm_wrapper.cc
Line 453, Patchset 2:
Antonio Rivera . resolved

If the intention here is only to measure the initialization time of the SbDrmSystem itself, would it make sense to move the CHROMECAST_TIMING_TRACKER to this line? CreateDrmSystem is what calls Starboard to construct the SbDrmSystem.

If you wanted to be really precise (and avoid the timing of our logging), you could even wrap it in curly braces to trigger destruction early, e.g.
```
{
  CHROMECAST_TIMING_TRACKER;
  drm_system_ = starboard_->CreateDrmSystem(
      /*key_system=*/"com.widevine.alpha",
      /*callback_handler=*/&callback_handler_);
}  // the timing tracker is destructed
```
Eusden Lin

Done. Thanks for the clarification.

Open in Gerrit

Related details

Attention is currently required from:
  • Antonio Rivera
  • Shawn Quereshi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iffae15d32ee2056d9e3706af22e3b4a8fefc0505
Gerrit-Change-Number: 7138221
Gerrit-PatchSet: 4
Gerrit-Owner: Eusden Lin <eusd...@google.com>
Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Antonio Rivera <anto...@google.com>
Gerrit-Attention: Shawn Quereshi <sha...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 09:52:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Antonio Rivera <anto...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Antonio Rivera (Gerrit)

unread,
Nov 11, 2025, 1:05:58 PM (yesterday) Nov 11
to Eusden Lin, Shawn Quereshi, chromium...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org
Attention needed from Eusden Lin and Shawn Quereshi

Antonio Rivera voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eusden Lin
  • Shawn Quereshi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iffae15d32ee2056d9e3706af22e3b4a8fefc0505
Gerrit-Change-Number: 7138221
Gerrit-PatchSet: 6
Gerrit-Owner: Eusden Lin <eusd...@google.com>
Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Shawn Quereshi <sha...@google.com>
Gerrit-Attention: Eusden Lin <eusd...@google.com>
Gerrit-Comment-Date: Tue, 11 Nov 2025 18:05:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shawn Quereshi (Gerrit)

unread,
Nov 11, 2025, 7:25:20 PM (23 hours ago) Nov 11
to Eusden Lin, Antonio Rivera, chromium...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org
Attention needed from Eusden Lin

Shawn Quereshi added 1 comment

File chromecast/common/timing_tracker.cc
Line 19, Patchset 6 (Latest): LOG(INFO) << file_ << " " << measured_tag_
<< " start us: " << start_.since_origin().InMicroseconds()
<< " end us: " << end.since_origin().InMicroseconds()
Shawn Quereshi . unresolved

Can we remove these two? I don't recall them being useful.

Open in Gerrit

Related details

Attention is currently required from:
  • Eusden Lin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iffae15d32ee2056d9e3706af22e3b4a8fefc0505
    Gerrit-Change-Number: 7138221
    Gerrit-PatchSet: 6
    Gerrit-Owner: Eusden Lin <eusd...@google.com>
    Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
    Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
    Gerrit-Attention: Eusden Lin <eusd...@google.com>
    Gerrit-Comment-Date: Wed, 12 Nov 2025 00:25:12 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Eusden Lin (Gerrit)

    unread,
    Nov 11, 2025, 8:03:18 PM (22 hours ago) Nov 11
    to Antonio Rivera, Shawn Quereshi, chromium...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org
    Attention needed from Antonio Rivera and Shawn Quereshi

    Eusden Lin added 1 comment

    File chromecast/common/timing_tracker.cc
    Line 19, Patchset 6: LOG(INFO) << file_ << " " << measured_tag_

    << " start us: " << start_.since_origin().InMicroseconds()
    << " end us: " << end.since_origin().InMicroseconds()
    Shawn Quereshi . resolved

    Can we remove these two? I don't recall them being useful.

    Eusden Lin

    Done.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Antonio Rivera
    • Shawn Quereshi
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iffae15d32ee2056d9e3706af22e3b4a8fefc0505
      Gerrit-Change-Number: 7138221
      Gerrit-PatchSet: 7
      Gerrit-Owner: Eusden Lin <eusd...@google.com>
      Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
      Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
      Gerrit-Attention: Antonio Rivera <anto...@google.com>
      Gerrit-Attention: Shawn Quereshi <sha...@google.com>
      Gerrit-Comment-Date: Wed, 12 Nov 2025 01:02:47 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Shawn Quereshi <sha...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Shawn Quereshi (Gerrit)

      unread,
      10:47 AM (8 hours ago) 10:47 AM
      to Eusden Lin, Antonio Rivera, chromium...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org
      Attention needed from Antonio Rivera and Eusden Lin

      Shawn Quereshi voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Antonio Rivera
      • Eusden Lin
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iffae15d32ee2056d9e3706af22e3b4a8fefc0505
        Gerrit-Change-Number: 7138221
        Gerrit-PatchSet: 7
        Gerrit-Owner: Eusden Lin <eusd...@google.com>
        Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
        Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
        Gerrit-Attention: Antonio Rivera <anto...@google.com>
        Gerrit-Attention: Eusden Lin <eusd...@google.com>
        Gerrit-Comment-Date: Wed, 12 Nov 2025 15:46:58 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Antonio Rivera (Gerrit)

        unread,
        1:23 PM (5 hours ago) 1:23 PM
        to Eusden Lin, Shawn Quereshi, chromium...@chromium.org, eme-r...@chromium.org, feature-me...@chromium.org, halliwe...@chromium.org, lcwu+...@chromium.org
        Attention needed from Eusden Lin

        Antonio Rivera voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Eusden Lin
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Iffae15d32ee2056d9e3706af22e3b4a8fefc0505
          Gerrit-Change-Number: 7138221
          Gerrit-PatchSet: 7
          Gerrit-Owner: Eusden Lin <eusd...@google.com>
          Gerrit-Reviewer: Antonio Rivera <anto...@google.com>
          Gerrit-Reviewer: Shawn Quereshi <sha...@google.com>
          Gerrit-Attention: Eusden Lin <eusd...@google.com>
          Gerrit-Comment-Date: Wed, 12 Nov 2025 18:22:58 +0000
          Gerrit-HasComments: No
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          open
          diffy
          Reply all
          Reply to author
          Forward
          0 new messages