[iOS][CX] Add passkey import data item type [chromium/src : main]
0 views
Skip to first unread message
Rafał Godlewski (Gerrit)
Nov 10, 2025, 10:07:25 AM (3 days ago) Nov 10
to Tommy Martino, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Attention needed from Tommy Martino
Rafał Godlewski voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Tommy Martino
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Martino (Gerrit)
Nov 11, 2025, 12:48:41 PM (yesterday) Nov 11
to Rafał Godlewski, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Attention needed from Rafał Godlewski
Tommy Martino voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rafał Godlewski (Gerrit)
Nov 11, 2025, 1:06:42 PM (yesterday) Nov 11
to Ewann Pellé, Tommy Martino, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Attention needed from Ewann Pellé
Rafał Godlewski added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
3:33 AM (19 hours ago) 3:33 AM
to Rafał Godlewski, Tommy Martino, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Attention needed from Rafał Godlewski
Ewann Pellé voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Rafał Godlewski
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rafał Godlewski (Gerrit)
4:20 AM (18 hours ago) 4:20 AM
to Ewann Pellé, Tommy Martino, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Rafał Godlewski voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:36 AM (17 hours ago) 5:36 AM
to Rafał Godlewski, Ewann Pellé, Tommy Martino, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS][CX] Add passkey import data item type
Adds new strings and symbol for the passkey import row.
Mock: https://screenshot.googleplex.com/AzGBLFNy9LMn5e8
Screenshot: https://screenshot.googleplex.com/6KWMEodCXJ4Jmks
Bug: 450982128
Change-Id: I0bfc57adc71752a1378dcfd984739a142a510e29
Reviewed-by: Tommy Martino <tmar...@chromium.org>
Reviewed-by: Ewann Pellé <ewa...@chromium.org>
Commit-Queue: Rafał Godlewski <rg...@google.com>
Cr-Commit-Position: refs/heads/main@{#1543622}
Files:
- M ios/chrome/app/strings/ios_strings.grd
- A ios/chrome/app/strings/ios_strings_grd/IDS_IOS_IMPORT_ITEM_TYPE_IMPORTED_DETAILED_TEXT_PASSKEYS.png.sha1
- A ios/chrome/app/strings/ios_strings_grd/IDS_IOS_IMPORT_ITEM_TYPE_PENDING_DETAILED_TEXT_PASSKEYS.png.sha1
- A ios/chrome/app/strings/ios_strings_grd/IDS_IOS_IMPORT_ITEM_TYPE_TITLE_PASSKEYS.png.sha1
- M ios/chrome/browser/credential_exchange/coordinator/credential_import_mediator.mm
- M ios/chrome/browser/data_import/public/import_data_item.h
- M ios/chrome/browser/data_import/ui/import_data_item_table_view.mm
- M ios/chrome/browser/shared/ui/symbols/symbol_names.h
- M ios/chrome/browser/shared/ui/symbols/symbol_names.mm
Change size: S
Delta: 9 files changed, 32 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ewann Pellé, +1 by Tommy Martino
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages