spanification: automatically spanify .../media_router/common/providers/cast/certificate/cast_crl.cc etc. [chromium/src : main]
Simeon Anfinrud (Gerrit)
Simeon Anfinrud voted and added 3 comments![]( "Open in Gerrit")
Votes added by Simeon Anfinrud
| Code-Review | +1 |
3 comments
const auto kCastFallbackCRLs = std::to_array<unsigned char>({should this be `inline constexpr` and add header guards back? Doing archaeology on https://chromium-review.googlesource.com/c/chromium/src/+/4740976, it seems the lack of header guards was not really for any good reason besides inlining the array in the header file as a `const std::string` (which later became `const unsigned char[]`) tripping up other warnings.
#include <array>nit: remove extraneous newline between includes?
Related details
- Bryan Enrique Gonzalez
- Daniel Angulo
- Roberto Torres
- Sergio Solano
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bryan Enrique Gonzalez (Gerrit)
Bryan Enrique Gonzalez added 2 comments![]( "Open in Gerrit")
const auto kCastFallbackCRLs = std::to_array<unsigned char>({should this be `inline constexpr` and add header guards back? Doing archaeology on https://chromium-review.googlesource.com/c/chromium/src/+/4740976, it seems the lack of header guards was not really for any good reason besides inlining the array in the header file as a `const std::string` (which later became `const unsigned char[]`) tripping up other warnings.
I understand this file has no guards because of the comment on line 4
`// no-include-guard-because-pch-file`
Just to make sure, we should add the header guards and remove that comment?
#include <array>nit: remove extraneous newline between includes?
I think this is part of `git cl format` because every time I try to remove it, gets added back.
Related details
- Daniel Angulo
- Roberto Torres
- Sergio Solano
- Simeon Anfinrud
- Stephen Nusko
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simeon Anfinrud (Gerrit)
Simeon Anfinrud added 2 comments![]( "Open in Gerrit")
const auto kCastFallbackCRLs = std::to_array<unsigned char>({Bryan Enrique Gonzalezshould this be `inline constexpr` and add header guards back? Doing archaeology on https://chromium-review.googlesource.com/c/chromium/src/+/4740976, it seems the lack of header guards was not really for any good reason besides inlining the array in the header file as a `const std::string` (which later became `const unsigned char[]`) tripping up other warnings.
I understand this file has no guards because of the comment on line 4
`// no-include-guard-because-pch-file`
Just to make sure, we should add the header guards and remove that comment?
Yeah, that and make the variables `inline constexpr`. I don't see any reason, based on the way this file is used, for it to be a header file without a header guard anymore as long as the variables are `inline constexpr`.
#include <array>Bryan Enrique Gonzaleznit: remove extraneous newline between includes?
I think this is part of `git cl format` because every time I try to remove it, gets added back.
- Bryan Enrique Gonzalez
- Daniel Angulo
- Roberto Torres
- Sergio Solano
- Stephen Nusko
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Bryan Enrique Gonzalez (Gerrit)
Bryan Enrique Gonzalez added 1 comment![]( "Open in Gerrit")
const auto kCastFallbackCRLs = std::to_array<unsigned char>({Bryan Enrique Gonzalezshould this be `inline constexpr` and add header guards back? Doing archaeology on https://chromium-review.googlesource.com/c/chromium/src/+/4740976, it seems the lack of header guards was not really for any good reason besides inlining the array in the header file as a `const std::string` (which later became `const unsigned char[]`) tripping up other warnings.
Simeon AnfinrudI understand this file has no guards because of the comment on line 4
`// no-include-guard-because-pch-file`
Just to make sure, we should add the header guards and remove that comment?
Yeah, that and make the variables `inline constexpr`. I don't see any reason, based on the way this file is used, for it to be a header file without a header guard anymore as long as the variables are `inline constexpr`.
- Daniel Angulo
- Roberto Torres
- Sergio Solano
- Simeon Anfinrud
- Stephen Nusko
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Simeon Anfinrud (Gerrit)
Simeon Anfinrud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Simeon Anfinrud
| Code-Review | +1 |
1 comment
const auto kCastFallbackCRLs = std::to_array<unsigned char>({Bryan Enrique Gonzalezshould this be `inline constexpr` and add header guards back? Doing archaeology on https://chromium-review.googlesource.com/c/chromium/src/+/4740976, it seems the lack of header guards was not really for any good reason besides inlining the array in the header file as a `const std::string` (which later became `const unsigned char[]`) tripping up other warnings.
Simeon AnfinrudI understand this file has no guards because of the comment on line 4
`// no-include-guard-because-pch-file`
Just to make sure, we should add the header guards and remove that comment?
Bryan Enrique GonzalezYeah, that and make the variables `inline constexpr`. I don't see any reason, based on the way this file is used, for it to be a header file without a header guard anymore as long as the variables are `inline constexpr`.
Done
- Bryan Enrique Gonzalez
- Daniel Angulo
- Roberto Torres
- Sergio Solano
- Stephen Nusko
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |