[Media] Fix crash when handling zero-value discard padding [chromium/src : main]
0 views
Skip to first unread message
Jordan Bayles (Gerrit)
Sep 19, 2025, 7:00:46 PM (16 hours ago) Sep 19
to chromium...@chromium.org, feature-me...@chromium.org
Jordan Bayles voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Frank Liberato (Gerrit)
Sep 19, 2025, 8:19:59 PM (14 hours ago) Sep 19
to Jordan Bayles, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Jordan Bayles
Frank Liberato voted and added 2 comments![]( "Open in Gerrit")
Votes added by Frank Liberato
| Code-Review | +1 |
2 comments
Patchset-level comments
File media/filters/ffmpeg_demuxer.cc
Line 640, Patchset 2 (Latest):
const auto start_padding = buffer->discard_padding()Frank Liberato . unresolved
should this check `discard_padding &&`? no idea if that can happen - it's just a reflexive comment.
Related details
Attention is currently required from:
- Jordan Bayles
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jordan Bayles (Gerrit)
Sep 19, 2025, 9:02:00 PM (14 hours ago) Sep 19
to Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Jordan Bayles voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jordan Bayles
| Commit-Queue | +2 |
1 comment
File media/filters/ffmpeg_demuxer.cc
Line 640, Patchset 2 (Latest):
const auto start_padding = buffer->discard_padding()Frank Liberato . resolved
should this check `discard_padding &&`? no idea if that can happen - it's just a reflexive comment.
Jordan Bayles
no, it shouldn't. At this point `discard_padding` should be ignored in favor of `buffer->discard_padding()`. I also want to move the logic to determine what the discard padding is into its own method so it's a little more clear. This method is massive. But that refactor can come after the crash fix.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages