Dale Curtis (Gerrit)

unread,

Mar 31, 2026, 4:32:07 PM (2 days ago) Mar 31

to Jordan Bayles, chromium...@chromium.org, erickun...@chromium.org, kinuko...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Jordan Bayles

Dale Curtis has uploaded the change for review

Dale Curtis would like Jordan Bayles to review this change.

Commit message

Use InvalidateWeakPtrAndDoom where appropriate in media/

This CL was uploaded by git cl split.

R=jop...@chromium.org

Bug: 498284504

Change-Id: Ia559de422c450446423839b7a7c37bdea5057ae8

Change diff

Change information

Files:

M media/audio/alsa/alsa_output.cc
M media/audio/pulse/pulse_loopback_manager.cc
M media/audio/win/audio_manager_win.cc
M third_party/blink/renderer/platform/media/web_media_player_impl.cc

Change size: XS

Delta: 4 files changed, 3 insertions(+), 4 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Jordan Bayles

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dale Curtis (Gerrit)

unread,

Mar 31, 2026, 4:32:42 PM (2 days ago) Mar 31

to chromium...@chromium.org, feature-me...@chromium.org

Attention needed from Frank Liberato

Dale Curtis has uploaded the change for review

Dale Curtis would like Frank Liberato to review this change.

Commit message

Use InvalidateWeakPtrAndDoom where appropriate in media/

This CL was uploaded by git cl split.

R=libe...@chromium.org

Bug: 498284504

Change-Id: I4a3ad19bb539cd76fba3d19f3d35c1c7ddf91786

Change diff

Change information

Files:

M media/base/android/android_cdm_factory.cc
M media/base/android/android_overlay.cc
M media/filters/demuxer_manager.cc
M media/filters/demuxer_manager.h
M media/filters/ffmpeg_demuxer.cc
M media/filters/hls_manifest_demuxer_engine.cc
M media/filters/manifest_demuxer.cc
M media/mojo/clients/mojo_audio_encoder.cc
M media/mojo/clients/mojo_video_decoder.cc
M media/mojo/services/mojo_video_decoder_service.cc
M media/renderers/renderer_impl.cc
M media/video/fake_video_encode_accelerator.cc

Change size: S

Delta: 12 files changed, 15 insertions(+), 22 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Frank Liberato

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dale Curtis (Gerrit)

unread,

Mar 31, 2026, 4:33:26 PM (2 days ago) Mar 31

to Eugene Zemtsov, chromium...@chromium.org, feature-me...@chromium.org, media-wi...@chromium.org, chromeos-gfx-...@google.com, media-cro...@chromium.org

Attention needed from Eugene Zemtsov

Dale Curtis has uploaded the change for review

Dale Curtis would like Eugene Zemtsov to review this change.

Commit message

Use InvalidateWeakPtrAndDoom where appropriate in media/

This CL was uploaded by git cl split.

R=eug...@chromium.org

Bug: 498284504

Change-Id: Ie0cb1e9f98fb1017173aaaf4695b63daa9728fcb

Change diff

diff --git a/media/gpu/windows/d3d12_video_encode_accelerator.cc b/media/gpu/windows/d3d12_video_encode_accelerator.cc
index 58ddd46..bca7e9f 100644
--- a/media/gpu/windows/d3d12_video_encode_accelerator.cc
+++ b/media/gpu/windows/d3d12_video_encode_accelerator.cc
@@ -513,11 +513,11 @@
   DCHECK_CALLED_ON_VALID_SEQUENCE(child_sequence_checker_);
 
   destroy_requested_ = true;
-  child_weak_this_factory_.InvalidateWeakPtrs();
+  child_weak_this_factory_.InvalidateWeakPtrsAndDoom();
 
   // We're destroying; cancel all callbacks.
   if (client_ptr_factory_) {
-    client_ptr_factory_->InvalidateWeakPtrs();
+    client_ptr_factory_->InvalidateWeakPtrsAndDoom();
   }
 
   encoder_task_runner_->PostTask(
@@ -903,12 +903,6 @@
 void D3D12VideoEncodeAccelerator::DestroyTask() {
   DVLOGF(2);
   DCHECK_CALLED_ON_VALID_SEQUENCE(encoder_sequence_checker_);
-
-  // Invalidate weak pointers created by |encoder_weak_this_factory_| so that
-  // any tasks posted with the encoder weak pointer will safely no-op if they
-  // run after this call.
-  encoder_weak_this_factory_.InvalidateWeakPtrs();
-
   delete this;
 }

Change information

Files:

M media/gpu/windows/d3d12_video_encode_accelerator.cc

Change size: S

Delta: 1 file changed, 2 insertions(+), 8 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Eugene Zemtsov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jordan Bayles (Gerrit)

unread,

Mar 31, 2026, 4:48:01 PM (2 days ago) Mar 31

to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Dale Curtis

Jordan Bayles voted and added 1 comment

Votes added by Jordan Bayles

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Jordan Bayles . resolved

Hadn't see this method before, I'll keep it in mind. LGTM.

Open in Gerrit

Related details

Attention is currently required from:

Dale Curtis

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Dale Curtis (Gerrit)

unread,

Mar 31, 2026, 5:47:25 PM (2 days ago) Mar 31

to Jordan Bayles, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Jordan Bayles

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Dale Curtis . resolved

PTAL, git cl split ended up splitting dependent changes.

Open in Gerrit

Related details

Attention is currently required from:

Jordan Bayles

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jordan Bayles (Gerrit)

unread,

Mar 31, 2026, 8:18:58 PM (2 days ago) Mar 31

to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Dale Curtis

Jordan Bayles voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Dale Curtis

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 31, 2026, 8:22:20 PM (2 days ago) Mar 31

to Dale Curtis, Jordan Bayles, chromium...@chromium.org, blink-...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, kinuko...@chromium.org, mfoltz+wa...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Use InvalidateWeakPtrAndDoom where appropriate in media/

This CL was uploaded by git cl split.

R=jop...@chromium.org

Bug: 498284504

Change-Id: Ia559de422c450446423839b7a7c37bdea5057ae8

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7719302

Auto-Submit: Dale Curtis <dalec...@chromium.org>

Reviewed-by: Jordan Bayles <jop...@chromium.org>

Commit-Queue: Jordan Bayles <jop...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1608203}

Files:

M media/audio/alsa/alsa_output.cc
M media/audio/pulse/pulse_loopback_manager.cc
M media/audio/win/audio_manager_win.cc

M media/filters/demuxer_manager.cc
M media/filters/demuxer_manager.h
M third_party/blink/renderer/platform/media/web_media_player_impl.cc

Change size: S

Delta: 6 files changed, 4 insertions(+), 9 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Jordan Bayles

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Eugene Zemtsov (Gerrit)

unread,

Apr 1, 2026, 8:50:09 PM (23 hours ago) Apr 1

to Dale Curtis, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Attention needed from Dale Curtis

Eugene Zemtsov voted and added 1 comment

Votes added by Eugene Zemtsov

Code-Review

+1

1 comment

File media/gpu/windows/d3d12_video_encode_accelerator.cc

Line 910, Patchset 1 (Parent): encoder_weak_this_factory_.InvalidateWeakPtrs();

Eugene Zemtsov . unresolved

why don't we need it anymore?

Open in Gerrit

Related details

Attention is currently required from:

Dale Curtis

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Frank Liberato (Gerrit)

unread,

11:18 AM (8 hours ago) 11:18 AM

to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org

Attention needed from Dale Curtis

Frank Liberato voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Dale Curtis

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Dale Curtis (Gerrit)

unread,

12:23 PM (7 hours ago) 12:23 PM

to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

Auto-Submit	+0
Commit-Queue	+2

1 comment

File media/gpu/windows/d3d12_video_encode_accelerator.cc

Line 910, Patchset 1 (Parent): encoder_weak_this_factory_.InvalidateWeakPtrs();

Eugene Zemtsov . resolved

why don't we need it anymore?

Dale Curtis

delete this triggers the invalidation immediately, so there's no point.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

1:04 PM (6 hours ago) 1:04 PM

to Dale Curtis, chromium...@chromium.org, feature-me...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Use InvalidateWeakPtrAndDoom where appropriate in media/

This CL was uploaded by git cl split.

R=libe...@chromium.org

Bug: 498284504

Change-Id: I4a3ad19bb539cd76fba3d19f3d35c1c7ddf91786

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7719303

Reviewed-by: Frank Liberato <libe...@chromium.org>

Commit-Queue: Frank Liberato <libe...@chromium.org>

Auto-Submit: Dale Curtis <dalec...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1609301}

Files:

M media/base/android/android_cdm_factory.cc
M media/base/android/android_overlay.cc
M media/filters/ffmpeg_demuxer.cc
M media/filters/manifest_demuxer.cc
M media/mojo/clients/mojo_audio_encoder.cc

M media/mojo/services/mojo_video_decoder_service.cc
M media/renderers/renderer_impl.cc
M media/video/fake_video_encode_accelerator.cc

Change size: S

Delta: 8 files changed, 10 insertions(+), 12 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Frank Liberato

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Chromium LUCI CQ (Gerrit)

unread,

1:33 PM (6 hours ago) 1:33 PM

to Dale Curtis, Eugene Zemtsov, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org, media-wi...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Use InvalidateWeakPtrAndDoom where appropriate in media/

This CL was uploaded by git cl split.

R=eug...@chromium.org

Bug: 498284504

Change-Id: Ie0cb1e9f98fb1017173aaaf4695b63daa9728fcb

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7719381

Reviewed-by: Eugene Zemtsov <eug...@chromium.org>

Commit-Queue: Dale Curtis <dalec...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1609329}

Files:

M media/gpu/windows/d3d12_video_encode_accelerator.cc

Change size: S

Delta: 1 file changed, 2 insertions(+), 8 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Eugene Zemtsov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Dale Curtis (Gerrit)

unread,

3:29 PM (4 hours ago) 3:29 PM

to Thomas Guilbert, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

Attention needed from Thomas Guilbert

Dale Curtis voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Thomas Guilbert

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dale Curtis (Gerrit)

unread,

4:07 PM (3 hours ago) 4:07 PM

to Chromium LUCI CQ, Thomas Guilbert, chromium...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org

Dale Curtis abandoned this change.

View Change

Abandoned

These are actually reusable!

Dale Curtis abandoned this change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Use InvalidateWeakPtrAndDoom where appropriate in media/ [chromium/src : main]

Dale Curtis (Gerrit)

Dale Curtis has uploaded the change for review

Commit message

Change diff

Change information

Related details

Dale Curtis (Gerrit)

Dale Curtis has uploaded the change for review

Commit message

Change diff

Change information

Related details

Dale Curtis (Gerrit)

Dale Curtis has uploaded the change for review

Commit message

Change diff

Change information

Related details

Jordan Bayles (Gerrit)

Jordan Bayles voted and added 1 comment

Votes added by Jordan Bayles

1 comment

Related details

Dale Curtis (Gerrit)

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

1 comment

Related details

Jordan Bayles (Gerrit)

Jordan Bayles voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Eugene Zemtsov (Gerrit)

Eugene Zemtsov voted and added 1 comment

Votes added by Eugene Zemtsov

1 comment

Related details

Frank Liberato (Gerrit)

Frank Liberato voted

Related details

Dale Curtis (Gerrit)

Dale Curtis voted and added 1 comment

Votes added by Dale Curtis

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

Dale Curtis (Gerrit)

Dale Curtis voted

Related details

Dale Curtis (Gerrit)

Dale Curtis abandoned this change

Related details