Also update shared preferences with background media capturing enabled [chromium/src : main]

[Sean Li (Gerrit)]

Sean Li has uploaded the change for review

Commit message

Also update shared preferences with background media capturing enabled

We use shared preferences to determine whether to start media
notification service. In this case, we should also update it when the
background media capturing is enabled.

Bug: 487025385, 489516324, 489653509

Test: Manually on Desktop/Non-desktop builds

Change-Id: I1d783648c8b96476eb8332b9e6f45a501af604ea

Change diff

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationServiceImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationServiceImpl.java
index 7fa35910..aeac097 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationServiceImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationServiceImpl.java
@@ -152,7 +152,7 @@
         if (notificationIds == null) return;
         Iterator<String> iterator = notificationIds.iterator();
         while (iterator.hasNext()) {
-            // When background media capturing is enabled, this operation is a no-op because a
+            // When background media capturing is enabled, this operation is a no-op because the
             // foreground service handles notification updates. We avoid calling
             // isBackgroundMediaCapturingEnabled() here because this code may execute during early
             // startup before the JNI library is initialized.

Change information

Files:

• M chrome/android/java/src/org/chromium/chrome/browser/media/MediaCaptureNotificationServiceImpl.java

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: newchange

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I1d783648c8b96476eb8332b9e6f45a501af604ea

Gerrit-Change-Number: 7638871

Gerrit-PatchSet: 1

Gerrit-Owner: Sean Li <sea...@google.com>

Gerrit-CC: chromium...@chromium.org