ash/fileapi: Simplify constructors and clean up FileAccumulator [chromium/src : main]
0 views
Skip to first unread message
Georg Neis (Gerrit)
Jun 26, 2026, 1:16:49 AM (10 days ago) Jun 26
to Di Wu, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, kinuko+...@chromium.org
Attention needed from Di Wu
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Di Wu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Wu (Gerrit)
Jun 26, 2026, 8:32:51 PM (9 days ago) Jun 26
to Georg Neis, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, kinuko+...@chromium.org
Attention needed from Georg Neis
Di Wu voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Georg Neis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Georg Neis (Gerrit)
Jun 28, 2026, 9:18:09 PM (7 days ago) Jun 28
to android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, kinuko+...@chromium.org
Georg Neis voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 28, 2026, 9:50:22 PM (7 days ago) Jun 28
to Georg Neis, Di Wu, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, kinuko+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
ash/fileapi: Simplify constructors and clean up FileAccumulator
- Default the move constructor for `FileAccumulator` and explicitly
delete unneeded copy/assignment operators.
- Remove the unused `FileAccumulator::Clear()` method (it was only
used in tests).
- Delete move/copy constructors and assignment operators for
`CallContext` structs across recent sources. They are exclusively
heap-allocated and stored via `unique_ptr`, making move/copy
operations unnecessary.
- Fix redundant scope resolution
(`RecentDiskSource::RecentDiskSource::CallContext`).
Change-Id: I0ff26d9072a9f91307c3add98bf6c89b9f03f92f
Reviewed-by: Di Wu <di...@google.com>
Commit-Queue: Georg Neis <ne...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1653830}
Files:
- M chrome/browser/ash/fileapi/file_accumulator.cc
- M chrome/browser/ash/fileapi/file_accumulator.h
- M chrome/browser/ash/fileapi/file_accumulator_unittest.cc
- M chrome/browser/ash/fileapi/recent_arc_media_source.cc
- M chrome/browser/ash/fileapi/recent_arc_media_source.h
- M chrome/browser/ash/fileapi/recent_disk_source.cc
- M chrome/browser/ash/fileapi/recent_disk_source.h
- M chrome/browser/ash/fileapi/recent_drive_source.cc
- M chrome/browser/ash/fileapi/recent_drive_source.h
- M chrome/browser/ash/fileapi/recent_model.cc
- M chrome/browser/ash/fileapi/recent_model.h
Change size: M
Delta: 11 files changed, 31 insertions(+), 58 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Di Wu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages