[ios] Expose more event through TabsDependencyInstaller [chromium/src : main]
0 views
Skip to first unread message
Federica Germinario (Gerrit)
Jul 8, 2025, 4:18:42 AM7/8/25
to Sylvain Defresne, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, dtraino...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sylvain Defresne
Federica Germinario voted and added 1 comment![]( "Open in Gerrit")
Votes added by Federica Germinario
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Sylvain Defresne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
Jul 8, 2025, 5:34:04 AM7/8/25
to Federica Germinario, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, dtraino...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Federica Germinario
Sylvain Defresne voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Federica Germinario
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 8, 2025, 5:36:50 AM7/8/25
to Sylvain Defresne, Federica Germinario, AyeAye, chromium...@chromium.org, feature-me...@chromium.org, dtraino...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[ios] Expose more event through TabsDependencyInstaller
Some of the sub-classes of TabsDependencyInstaller wants to observe
the change of the active WebState or the final destruction of a tab
(to perform some cleanup).
Expose this via two new methods of TabsDependnecyInstaller to limit
the number of code that has to observe WebStateList (i.e. without
this change, the sub-classes would have to observe WebStateList
twice).
Bug: 409299519
Change-Id: If91837e99309eb6b0a1143678ffc0a6ed8bed304
Reviewed-by: Federica Germinario <fede...@google.com>
Auto-Submit: Sylvain Defresne <sdef...@chromium.org>
Commit-Queue: Sylvain Defresne <sdef...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1483638}
Files:
- M ios/chrome/browser/browser_view/ui_bundled/tab_lifecycle_mediator.mm
- M ios/chrome/browser/download/coordinator/ar_quick_look_coordinator.mm
- M ios/chrome/browser/download/coordinator/safari_download_coordinator.mm
- M ios/chrome/browser/download/coordinator/vcard_coordinator.mm
- M ios/chrome/browser/sad_tab/ui_bundled/sad_tab_coordinator.mm
- M ios/chrome/browser/signin/model/account_consistency_browser_agent.h
- M ios/chrome/browser/signin/model/account_consistency_browser_agent.mm
- M ios/chrome/browser/tabs/model/tabs_dependency_installer.h
- M ios/chrome/browser/tabs/model/tabs_dependency_installer.mm
- M ios/chrome/browser/tabs/model/tabs_dependency_installer_bridge.h
- M ios/chrome/browser/tabs/model/tabs_dependency_installer_bridge.mm
- M ios/chrome/browser/tabs/model/tabs_dependency_installer_bridge_unittest.mm
- M ios/chrome/browser/tabs/model/tabs_dependency_installer_unittest.mm
Change size: L
Delta: 13 files changed, 311 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Federica Germinario
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages