Alexandra Pereira (Gerrit)

unread,

Dec 19, 2025, 10:11:49 PM12/19/25

to Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Message from Alexandra Pereira

Set Ready For Review

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexandra Pereira (Gerrit)

unread,

Dec 19, 2025, 10:13:51 PM12/19/25

to Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Alexandra Pereira added 2 comments

File third_party/blink/renderer/core/dom/layout_tree_builder_traversal.cc

Line 126, Patchset 1: size_t pseudo_index = 0;

AI Code Reviewer . resolved

Blink Style Guide: Prefer blink:: types over STL and base types. Use 'wtf_size_t' instead of 'size_t' for indices interacting with Blink collections.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Alexandra Pereira

Done

Line 320, Patchset 1: size_t pseudo_index = 0;

AI Code Reviewer . resolved

Blink Style Guide: Prefer blink:: types over STL and base types. Use 'wtf_size_t' instead of 'size_t' for indices interacting with Blink collections.
To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Alexandra Pereira

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexandra Pereira (Gerrit)

unread,

Jan 5, 2026, 8:12:19 AM (13 days ago) Jan 5

to Vincent Boisselle, Mike Dougherty, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Attention needed from Mike Dougherty and Vincent Boisselle

Alexandra Pereira added 1 comment

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Alexandra Pereira . resolved

Hi, PTAL. Thanks.

Open in Gerrit

Related details

Attention is currently required from:

Mike Dougherty
Vincent Boisselle

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vincent Boisselle (Gerrit)

unread,

Jan 6, 2026, 4:03:58 PM (12 days ago) Jan 6

to Alexandra Pereira, Mike Dougherty, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Attention needed from Alexandra Pereira and Mike Dougherty

Vincent Boisselle voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alexandra Pereira
Mike Dougherty

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mike Dougherty (Gerrit)

unread,

Jan 8, 2026, 4:20:19 PM (10 days ago) Jan 8

to Alexandra Pereira, Vincent Boisselle, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Attention needed from Alexandra Pereira

Mike Dougherty voted and added 6 comments

Votes added by Mike Dougherty

Code-Review

+1

6 comments

Patchset-level comments

File-level comment, Patchset 12 (Latest):

Mike Dougherty . resolved

Thanks! Added a few nits

File ios/web/js_messaging/java_script_feature_unittest.mm

Line 142, Patchset 12 (Latest): "fill_util_test", document_end_injection_time, target_frames_main);

Mike Dougherty . unresolved

is there a different script you can use here instead? Specifically one that is defined in web? You might even be able to just use "gcrweb" here too

File ios/web/public/js_messaging/README.md

Line 98, Patchset 12 (Latest): * Ex: `translate_ios.ts` adds the `__gCrWeb` translate API functions

Mike Dougherty . unresolved

nit: use a feature example from web since this is web documentation. Any from here should be fine: `//ios/web/js_features/`

File ios/web/switches.cc

Line 28, Patchset 12 (Latest):// `--enable-listed-scripts=gcrweb,message,all_frames_context_menu,

Mike Dougherty . unresolved

can you please remove `message` here too as that file no longer exists?

Line 44, Patchset 12 (Latest):// the features returned by `GetBaseJavaScriptFeature()` are always

Mike Dougherty . unresolved

s/are/is

Line 44, Patchset 12 (Latest):// the features returned by `GetBaseJavaScriptFeature()` are always

Mike Dougherty . unresolved

s/features/feature

Open in Gerrit

Related details

Attention is currently required from:

Alexandra Pereira

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexandra Pereira (Gerrit)

unread,

Jan 16, 2026, 12:19:38 PM (2 days ago) Jan 16

to Mike Dougherty, Vincent Boisselle, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Attention needed from Mike Dougherty and Vincent Boisselle

Alexandra Pereira voted and added 5 comments

Votes added by Alexandra Pereira

Commit-Queue

+1

5 comments

File ios/web/js_messaging/java_script_feature_unittest.mm

Line 142, Patchset 12: "fill_util_test", document_end_injection_time, target_frames_main);

Mike Dougherty . resolved

is there a different script you can use here instead? Specifically one that is defined in web? You might even be able to just use "gcrweb" here too

Alexandra Pereira

Done

File ios/web/public/js_messaging/README.md

Line 98, Patchset 12: * Ex: `translate_ios.ts` adds the `__gCrWeb` translate API functions

Mike Dougherty . resolved

nit: use a feature example from web since this is web documentation. Any from here should be fine: `//ios/web/js_features/`

Alexandra Pereira

Done

File ios/web/switches.cc

Line 28, Patchset 12:// `--enable-listed-scripts=gcrweb,message,all_frames_context_menu,

Mike Dougherty . resolved

can you please remove `message` here too as that file no longer exists?

Alexandra Pereira

Done

Line 44, Patchset 12:// the features returned by `GetBaseJavaScriptFeature()` are always

Mike Dougherty . resolved

s/features/feature

Alexandra Pereira

Done

Line 44, Patchset 12:// the features returned by `GetBaseJavaScriptFeature()` are always

Mike Dougherty . resolved

s/are/is

Alexandra Pereira

Done

Open in Gerrit

Related details

Attention is currently required from:

Mike Dougherty
Vincent Boisselle

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vincent Boisselle (Gerrit)

unread,

Jan 16, 2026, 2:00:09 PM (2 days ago) Jan 16

to Alexandra Pereira, Mike Dougherty, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Attention needed from Alexandra Pereira and Mike Dougherty

Vincent Boisselle added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Vincent Boisselle . resolved

+1 for autofill/

I skimmed through ios/web

Open in Gerrit

Related details

Attention is currently required from:

Alexandra Pereira
Mike Dougherty

satisfied_requirement

unsatisfied_requirement

open

diffy

Mike Dougherty (Gerrit)

unread,

Jan 16, 2026, 2:29:46 PM (2 days ago) Jan 16

to Alexandra Pereira, Vincent Boisselle, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Attention needed from Alexandra Pereira

Mike Dougherty voted and added 1 comment

Votes added by Mike Dougherty

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Mike Dougherty . resolved

LGTM! 🎉

Open in Gerrit

Related details

Attention is currently required from:

Alexandra Pereira

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexandra Pereira (Gerrit)

unread,

Jan 16, 2026, 2:41:53 PM (2 days ago) Jan 16

to Mike Dougherty, Vincent Boisselle, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Alexandra Pereira added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Alexandra Pereira . resolved

Hi! Would you RS this CL?

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexandra Pereira (Gerrit)

unread,

Jan 16, 2026, 2:43:38 PM (2 days ago) Jan 16

to Ian Wells, Alexis Hétu, Gauthier Ambard, Mike Dougherty, Vincent Boisselle, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Attention needed from Alexis Hétu, Gauthier Ambard and Ian Wells

Alexandra Pereira added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Alexandra Pereira . resolved

Hi, would you RS this CL?

Open in Gerrit

Related details

Attention is currently required from:

Alexis Hétu
Gauthier Ambard
Ian Wells

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ian Wells (Gerrit)

unread,

Jan 16, 2026, 2:52:47 PM (2 days ago) Jan 16

to Alexandra Pereira, Alexis Hétu, Gauthier Ambard, Mike Dougherty, Vincent Boisselle, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Attention needed from Alexandra Pereira, Alexis Hétu and Gauthier Ambard

Ian Wells voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Alexandra Pereira
Alexis Hétu
Gauthier Ambard

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexis Hétu (Gerrit)

unread,

Jan 16, 2026, 4:42:07 PM (2 days ago) Jan 16

to Alexandra Pereira, Ian Wells, Gauthier Ambard, Mike Dougherty, Vincent Boisselle, Chromium LUCI CQ, Christian Biesinger, Sophie Chang, Chromium Metrics Reviews, Kaan Icer, AyeAye, AI Code Reviewer, AyeAye Python Dispatcher, chromium...@chromium.org, jorgel...@chromium.org, kmg+...@google.com, crmulli...@chromium.org, boujan...@google.com, dewitt...@chromium.org, marinacio...@chromium.org, ramyagopa...@google.com, peilinwa...@google.com, aashna...@google.com, filesapp...@chromium.org, npm+...@chromium.org, kinuko...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, asvitkine...@chromium.org, scheduler-...@chromium.org, navigation...@chromium.org, alexmo...@chromium.org, android-web...@chromium.org, blink-...@chromium.org, jdonnel...@chromium.org, blink-revi...@chromium.org, ntp-dev...@chromium.org, mfoltz+wa...@chromium.org, feature-me...@chromium.org, permissio...@chromium.org, olka+...@chromium.org, asvitki...@chromium.org, jmedle...@chromium.org, chikamu...@chromium.org, mac-r...@chromium.org, creis...@chromium.org, yigu+...@chromium.org, kenok...@google.com, eme-r...@chromium.org, hanxi...@chromium.org, chrstn...@google.com, nicolas...@chromium.org, oshima...@chromium.org, omnibox-...@chromium.org, browser-comp...@chromium.org, derinel+wat...@google.com, gcasto+w...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, language...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, vasilii+watchlis...@chromium.org, webauthn...@chromium.org

Attention needed from Alexandra Pereira and Gauthier Ambard

Alexis Hétu voted and added 1 comment

Votes added by Alexis Hétu

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Alexis Hétu . resolved

components/webauthn/ios/passkey_java_script_feature.mm LGTM

Open in Gerrit

Related details

Attention is currently required from:

Alexandra Pereira
Gauthier Ambard

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

[iOS] Remove legacy common API [chromium/src : main]

Alexandra Pereira (Gerrit)

Message from Alexandra Pereira

Related details

Alexandra Pereira (Gerrit)

Alexandra Pereira added 2 comments

Related details

Alexandra Pereira (Gerrit)

Alexandra Pereira added 1 comment

Related details

Vincent Boisselle (Gerrit)

Vincent Boisselle voted Code-Review+1

Related details

Mike Dougherty (Gerrit)

Mike Dougherty voted and added 6 comments

Votes added by Mike Dougherty

6 comments

Related details

Alexandra Pereira (Gerrit)

Alexandra Pereira voted and added 5 comments

Votes added by Alexandra Pereira

5 comments

Related details

Vincent Boisselle (Gerrit)

Vincent Boisselle added 1 comment

Related details

Mike Dougherty (Gerrit)

Mike Dougherty voted and added 1 comment

Votes added by Mike Dougherty

1 comment

Related details

Alexandra Pereira (Gerrit)

Alexandra Pereira added 1 comment

Related details

Alexandra Pereira (Gerrit)

Alexandra Pereira added 1 comment

Related details

Ian Wells (Gerrit)

Ian Wells voted Code-Review+1

Related details

Alexis Hétu (Gerrit)

Alexis Hétu voted and added 1 comment

Votes added by Alexis Hétu

1 comment

Related details