CL2: Add CameraCaptureDialog for desktop media capture [chromium/src : main]

[Helmut Januschka (Gerrit)]

Attention needed from Chromium UI Views Reviews and Jan Keitel

Helmut Januschka added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Helmut Januschka . resolved

hello reviewers, this is CL2 of 3 (+ one more for final enablement)

design doc is here: https://docs.google.com/document/d/1p2QlRMDbHUc-GneEUuf-yHXRCqWqJijZSFD_KErqdnQ/edit?tab=t.0

also please see: https://chromium-review.googlesource.com/c/chromium/src/+/7594822/comments/304c6eca_e8c8ae30

Open in Gerrit

Related details

Attention is currently required from:

• Chromium UI Views Reviews
• Jan Keitel

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I279a97203b9029f48a6461393b6a8c7d1e35058a

Gerrit-Change-Number: 7647053

Gerrit-PatchSet: 3

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Chromium UI Views Reviews <chromium-ui-...@google.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Jan Keitel <jke...@google.com>

Gerrit-Attention: Chromium UI Views Reviews <chromium-ui-...@google.com>

Gerrit-Comment-Date: Wed, 11 Mar 2026 21:07:14 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[gwsq (Gerrit)]

Attention needed from Jan Keitel and Robert Liao

Message from gwsq

Reviewer source(s):
rob...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ui/views/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:

• Jan Keitel
• Robert Liao

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I279a97203b9029f48a6461393b6a8c7d1e35058a

Gerrit-Change-Number: 7647053

Gerrit-PatchSet: 3

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Robert Liao <rob...@chromium.org>

Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Robert Liao <rob...@chromium.org>

Gerrit-Attention: Jan Keitel <jke...@google.com>

Gerrit-Comment-Date: Wed, 11 Mar 2026 21:11:54 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Robert Liao (Gerrit)]

Attention needed from Helmut Januschka and Jan Keitel

Robert Liao added 1 comment

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Robert Liao . resolved

Sorry about the delay. I just got out of a weeklong summit.

Meta question: What spec are we operating off of for this change? I don't see it referenced in the bug? Have we gone through Chrome UX review for it?

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Jan Keitel

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I279a97203b9029f48a6461393b6a8c7d1e35058a

Gerrit-Change-Number: 7647053

Gerrit-PatchSet: 7

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Robert Liao <rob...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Jan Keitel <jke...@google.com>

Gerrit-Comment-Date: Fri, 13 Mar 2026 17:14:08 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Helmut Januschka (Gerrit)]

Attention needed from Jan Keitel and Robert Liao

Helmut Januschka voted and added 1 comment

Votes added by Helmut Januschka

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 7:

Robert Liao . resolved

Sorry about the delay. I just got out of a weeklong summit.

Meta question: What spec are we operating off of for this change? I don't see it referenced in the bug? Have we gone through Chrome UX review for it?

Helmut Januschka

no worries about delay, i know it will be a longer journey 🥳

here is the docs:

• chromestatus: https://chromestatus.com/feature/5154771310870528
• blink-dev i2p: https://groups.google.com/a/chromium.org/g/blink-dev/c/Z8MK8Q_7DQI/m/7u5tD0JDAQAJ
• design doc: https://docs.google.com/document/d/1p2QlRMDbHUc-GneEUuf-yHXRCqWqJijZSFD_KErqdnQ/edit?usp=sharing
• spec: https://www.w3.org/TR/html-media-capture/
• support matrix: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/capture#browser_compatibility (chromium would be first to deliver capture on desktop)

> Have we gone through Chrome UX review for it?

i kindly ask for help here, as an external i am not 100% aware of the process, could you tell me where/what i should do now?

happy to address any given feedback

Open in Gerrit

Related details

Attention is currently required from:

• Jan Keitel
• Robert Liao

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I279a97203b9029f48a6461393b6a8c7d1e35058a

Gerrit-Change-Number: 7647053

Gerrit-PatchSet: 8

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Robert Liao <rob...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Robert Liao <rob...@chromium.org>

Gerrit-Attention: Jan Keitel <jke...@google.com>

Gerrit-Comment-Date: Fri, 13 Mar 2026 23:02:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Robert Liao <rob...@chromium.org>

[Robert Liao (Gerrit)]

Attention needed from Helmut Januschka and Jan Keitel

Robert Liao added 1 comment

Patchset-level comments

File-level comment, Patchset 7:

Robert Liao . unresolved

Sorry about the delay. I just got out of a weeklong summit.

Meta question: What spec are we operating off of for this change? I don't see it referenced in the bug? Have we gone through Chrome UX review for it?

Helmut Januschka

no worries about delay, i know it will be a longer journey 🥳

here is the docs:

• chromestatus: https://chromestatus.com/feature/5154771310870528
• blink-dev i2p: https://groups.google.com/a/chromium.org/g/blink-dev/c/Z8MK8Q_7DQI/m/7u5tD0JDAQAJ
• design doc: https://docs.google.com/document/d/1p2QlRMDbHUc-GneEUuf-yHXRCqWqJijZSFD_KErqdnQ/edit?usp=sharing
• spec: https://www.w3.org/TR/html-media-capture/
• support matrix: https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Attributes/capture#browser_compatibility (chromium would be first to deliver capture on desktop)

> Have we gone through Chrome UX review for it?
i kindly ask for help here, as an external i am not 100% aware of the process, could you tell me where/what i should do now?

happy to address any given feedback

Robert Liao

>Have we gone through Chrome UX review for it?
>i kindly ask for help here, as an external i am not 100% aware of the process, >could you tell me where/what i should do now?

>happy to address any given feedback

You'll likely want an Chrome sponsor to help guide you through this from the Web Platform team. Who is your main contact over there?

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Jan Keitel

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I279a97203b9029f48a6461393b6a8c7d1e35058a

Gerrit-Change-Number: 7647053

Gerrit-PatchSet: 8

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Robert Liao <rob...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Jan Keitel <jke...@google.com>

Gerrit-Comment-Date: Mon, 16 Mar 2026 18:55:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Helmut Januschka <hel...@januschka.com>

Comment-In-Reply-To: Robert Liao <rob...@chromium.org>

[Ahmed Moussa (Gerrit)]

Attention needed from Helmut Januschka and Jan Keitel

Ahmed Moussa added 1 comment

File chrome/browser/ui/views/media_capture/camera_capture_dialog.cc

Line 425, Patchset 8 (Latest): video_source_provider_.reset();

Ahmed Moussa . unresolved

Have you considered getting rid of `video_source_provider_` and delegate its usage to `camera_mediator`?
`chrome/browser/ui/views/media_preview/camera_preview/camera_mediator.h`

The same for audio as well, `mic_mediator`.
`chrome/browser/ui/views/media_preview/mic_preview/mic_mediator.h`

Open in Gerrit

Related details

Attention is currently required from:

• Helmut Januschka
• Jan Keitel

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I279a97203b9029f48a6461393b6a8c7d1e35058a

Gerrit-Change-Number: 7647053

Gerrit-PatchSet: 8

Gerrit-Owner: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>

Gerrit-Reviewer: Jan Keitel <jke...@google.com>

Gerrit-Reviewer: Robert Liao <rob...@chromium.org>

Gerrit-CC: Ahmed Moussa <ahmed...@google.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: Chromium UI Views Reviews <chromium-ui-...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: gwsq

Gerrit-Attention: Helmut Januschka <hel...@januschka.com>

Gerrit-Attention: Jan Keitel <jke...@google.com>

Gerrit-Comment-Date: Wed, 18 Mar 2026 01:33:27 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No