[MediaCodecUtil] Remove more < Android Q code [chromium/src : main]

0 views
Skip to first unread message

Dale Curtis (Gerrit)

unread,
Oct 10, 2025, 4:41:55 PM (9 hours ago) Oct 10
to Phil Yan, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Phil Yan

Dale Curtis voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Phil Yan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iabfae3d246be83b8a7ce32144c07491f4188261c
Gerrit-Change-Number: 7032445
Gerrit-PatchSet: 1
Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
Gerrit-Reviewer: Phil Yan <phi...@chromium.org>
Gerrit-Attention: Phil Yan <phi...@chromium.org>
Gerrit-Comment-Date: Fri, 10 Oct 2025 20:41:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Phil Yan (Gerrit)

unread,
Oct 10, 2025, 4:45:48 PM (9 hours ago) Oct 10
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dale Curtis

Phil Yan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dale Curtis
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabfae3d246be83b8a7ce32144c07491f4188261c
    Gerrit-Change-Number: 7032445
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Phil Yan <phi...@chromium.org>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Comment-Date: Fri, 10 Oct 2025 20:45:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dale Curtis (Gerrit)

    unread,
    Oct 10, 2025, 4:53:54 PM (9 hours ago) Oct 10
    to Phil Yan, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
    Attention needed from Phil Yan

    Dale Curtis voted and added 1 comment

    Votes added by Dale Curtis

    Auto-Submit+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    Dale Curtis . resolved

    Added a couple more lines Phil, please CQ if it lgty

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Phil Yan
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabfae3d246be83b8a7ce32144c07491f4188261c
    Gerrit-Change-Number: 7032445
    Gerrit-PatchSet: 2
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Phil Yan <phi...@chromium.org>
    Gerrit-Attention: Phil Yan <phi...@chromium.org>
    Gerrit-Comment-Date: Fri, 10 Oct 2025 20:53:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Phil Yan (Gerrit)

    unread,
    Oct 10, 2025, 5:52:05 PM (8 hours ago) Oct 10
    to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
    Attention needed from Dale Curtis

    Phil Yan voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dale Curtis
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabfae3d246be83b8a7ce32144c07491f4188261c
    Gerrit-Change-Number: 7032445
    Gerrit-PatchSet: 3
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Phil Yan <phi...@chromium.org>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Comment-Date: Fri, 10 Oct 2025 21:51:42 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Phil Yan (Gerrit)

    unread,
    Oct 10, 2025, 9:07:42 PM (5 hours ago) Oct 10
    to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
    Attention needed from Dale Curtis

    Phil Yan voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dale Curtis
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabfae3d246be83b8a7ce32144c07491f4188261c
    Gerrit-Change-Number: 7032445
    Gerrit-PatchSet: 4
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Phil Yan <phi...@chromium.org>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Comment-Date: Sat, 11 Oct 2025 01:07:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Oct 10, 2025, 11:07:12 PM (3 hours ago) Oct 10
    to Dale Curtis, Phil Yan, chromium...@chromium.org, feature-me...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [MediaCodecUtil] Remove more < Android Q code

    R=philyan
    Bug: 425948259
    Change-Id: Iabfae3d246be83b8a7ce32144c07491f4188261c
    Commit-Queue: Dale Curtis <dalec...@chromium.org>
    Reviewed-by: Phil Yan <phi...@chromium.org>
    Auto-Submit: Dale Curtis <dalec...@chromium.org>
    Commit-Queue: Phil Yan <phi...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1528485}
    Files:
    • M media/base/android/media_codec_util.cc
    • M media/base/android/media_codec_util_unittest.cc
    Change size: S
    Delta: 2 files changed, 9 insertions(+), 29 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Phil Yan
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iabfae3d246be83b8a7ce32144c07491f4188261c
    Gerrit-Change-Number: 7032445
    Gerrit-PatchSet: 5
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Phil Yan <phi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages