[MiraclePtr] Rewrite templated container fields to raw_ptr [chromium/src : main]
0 views
Skip to first unread message
José Arturo Barrera (Gerrit)
Jun 22, 2026, 5:11:07 PM (9 days ago) Jun 22
to Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Arthur Sonzogni
José Arturo Barrera added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
José Arturo Barrera . unresolved
@arthurs...@chromium.org, do you think we should split this CL? If so, do you have any suggestions, like split by folder?
Related details
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Jun 22, 2026, 6:00:39 PM (9 days ago) Jun 22
to José Arturo Barrera, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Arthur Sonzogni and José Arturo Barrera
Arthur Sonzogni added 2 comments![]( "Open in Gerrit")
Message
**[Early Review]** This is an automated early review generated by an LLM. It is intended to help you catch obvious issues early and **potentially save a round of code review**.
If you find any suggestion irrelevant, please feel free to *ignore* or *close* it.
_I am going to do a manual code review when I wake up._
Please see suggestions below.
2 comments
File chrome/browser/ui/views/tabs/projects/projects_panel_recent_threads_view.h
Line 57, Patchset 5 (Latest):
const std::vector<raw_ptr<ProjectsPanelThreadItemView>>Arthur Sonzogni . unresolved
**[Early Review]**
Returning `std::vector<raw_ptr<T>>` by value causes unnecessary copies of the vector and all its `raw_ptr` elements (which have non-trivial copy constructors/destructors due to MiraclePtr ref-counting). This is especially costly in `projects_panel_recent_threads_view_unittest.cc` where `item_views_for_testing()` is called inside a loop, resulting in O(N^2) copies of the vector. Consider returning by const reference instead: `const std::vector<raw_ptr<ProjectsPanelThreadItemView>>& item_views_for_testing() const`.
File chrome/browser/ui/views/tabs/projects/projects_panel_tab_groups_view.h
Line 95, Patchset 5 (Latest):
std::vector<raw_ptr<ProjectsPanelTabGroupsItemView>> item_views_for_testing()Arthur Sonzogni . unresolved
**[Early Review]**
Returning `std::vector<raw_ptr<T>>` by value causes unnecessary copies of the vector and all its `raw_ptr` elements. Since this just returns a member variable, consider returning by const reference instead: `const std::vector<raw_ptr<ProjectsPanelTabGroupsItemView>>& item_views_for_testing() const`.
Related details
Attention is currently required from:
- Arthur Sonzogni
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Jun 23, 2026, 10:17:55 AM (8 days ago) Jun 23
to José Arturo Barrera, Colin Blundell, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Colin Blundell and José Arturo Barrera
Arthur Sonzogni added 7 comments![]( "Open in Gerrit")
Patchset-level comments
José Arturo Barrera . unresolved
@arthurs...@chromium.org, do you think we should split this CL? If so, do you have any suggestions, like split by folder?
Arthur Sonzogni
Me + @blun...@chromium.org would cover every files, except 1. So 3 reviewers would be enough here.
---
How many patches like this do you think we will be submitted?
Arthur Sonzogni . resolved
Thanks!
File chrome/browser/ui/views/tabs/projects/projects_panel_recent_threads_view.h
Line 57, Patchset 5 (Latest):
const std::vector<raw_ptr<ProjectsPanelThreadItemView>>Arthur Sonzogni . resolved
**[Early Review]**
Returning `std::vector<raw_ptr<T>>` by value causes unnecessary copies of the vector and all its `raw_ptr` elements (which have non-trivial copy constructors/destructors due to MiraclePtr ref-counting). This is especially costly in `projects_panel_recent_threads_view_unittest.cc` where `item_views_for_testing()` is called inside a loop, resulting in O(N^2) copies of the vector. Consider returning by const reference instead: `const std::vector<raw_ptr<ProjectsPanelThreadItemView>>& item_views_for_testing() const`.
Arthur Sonzogni
Acknowledged
File chrome/browser/ui/views/tabs/projects/projects_panel_tab_groups_view.h
Line 95, Patchset 5 (Latest):
std::vector<raw_ptr<ProjectsPanelTabGroupsItemView>> item_views_for_testing()Arthur Sonzogni . resolved
**[Early Review]**
Returning `std::vector<raw_ptr<T>>` by value causes unnecessary copies of the vector and all its `raw_ptr` elements. Since this just returns a member variable, consider returning by const reference instead: `const std::vector<raw_ptr<ProjectsPanelTabGroupsItemView>>& item_views_for_testing() const`.
Arthur Sonzogni
Acknowledged
File chrome/browser/ui/webui/cr_components/searchbox/contextual_searchbox_handler.cc
Line 1626, Patchset 5 (Latest):
std::vector<raw_ptr<const contextual_search::FileInfo>> file_info_list;Arthur Sonzogni . unresolved
Seems unused. Maybe a preliminary CL removing this variable?
File media/filters/manifest_demuxer.cc
Line 88, Patchset 5 (Latest):
std::vector<raw_ptr<DemuxerStream>> ManifestDemuxer::GetAllStreams() {
DCHECK(media_task_runner_->RunsTasksInCurrentSequence());
// For each stream that ChunkDemuxer returns, we need to wrap it so that
// we can grab the timestamp. Chunk demuxer's streams live forever, so
// ours might as well also live forever, even if that leaks a small
// amount of memory.
// TODO(crbug.com/40057824): Rearchitect the demuxer stream ownership
// model to prevent long-lived streams from potentially leaking memory.
std::vector<raw_ptr<DemuxerStream>> streams;
for (DemuxerStream* chunk_demuxer_stream :
impl_->FilterDemuxerStreams(chunk_demuxer_->GetAllStreams())) {
auto it = streams_.find(chunk_demuxer_stream);
if (it != streams_.end()) {
streams.push_back(it->second.get());
continue;
}
auto wrapper = std::make_unique<ManifestDemuxerStream>(
chunk_demuxer_stream,
base::BindRepeating(&ManifestDemuxer::OnDemuxerStreamRead,
weak_factory_.GetWeakPtr()));
streams.push_back(wrapper.get());
streams_[chunk_demuxer_stream] = std::move(wrapper);
}
return streams;
}Arthur Sonzogni . unresolved
Formatting issue here. Could you please re-indent back to its original state?
File third_party/blink/renderer/core/exported/web_media_player_impl_unittest.cc
Line 3404, Patchset 5 (Latest):
decltype(demuxer->GetAllStreams()) streams;Arthur Sonzogni . unresolved
Can we use the real type here?
Related details
Attention is currently required from:
- Colin Blundell
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Arturo Barrera (Gerrit)
Jun 23, 2026, 4:50:56 PM (8 days ago) Jun 23
to Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Arthur Sonzogni and Colin Blundell
José Arturo Barrera added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/exported/web_media_player_impl_unittest.cc
Line 3404, Patchset 5:
decltype(demuxer->GetAllStreams()) streams;Arthur Sonzogni . unresolved
Can we use the real type here?
José Arturo Barrera
The section "Pointers to unprotected memory (performance optimization)" in the file https://source.chromium.org/chromium/chromium/src/+/main:base/memory/raw_ptr.md states that `raw_ptr` is disallowed in `third_party/blink/renderer/core/`. So this change may be discarded
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Arturo Barrera (Gerrit)
Jun 23, 2026, 4:51:41 PM (8 days ago) Jun 23
to Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Arthur Sonzogni and Colin Blundell
José Arturo Barrera added 1 comment![]( "Open in Gerrit")
File media/filters/manifest_demuxer.cc
Line 88, Patchset 5:
std::vector<raw_ptr<DemuxerStream>> ManifestDemuxer::GetAllStreams() {
DCHECK(media_task_runner_->RunsTasksInCurrentSequence());
// For each stream that ChunkDemuxer returns, we need to wrap it so that
// we can grab the timestamp. Chunk demuxer's streams live forever, so
// ours might as well also live forever, even if that leaks a small
// amount of memory.
// TODO(crbug.com/40057824): Rearchitect the demuxer stream ownership
// model to prevent long-lived streams from potentially leaking memory.
std::vector<raw_ptr<DemuxerStream>> streams;
for (DemuxerStream* chunk_demuxer_stream :
impl_->FilterDemuxerStreams(chunk_demuxer_->GetAllStreams())) {
auto it = streams_.find(chunk_demuxer_stream);
if (it != streams_.end()) {
streams.push_back(it->second.get());
continue;
}
auto wrapper = std::make_unique<ManifestDemuxerStream>(
chunk_demuxer_stream,
base::BindRepeating(&ManifestDemuxer::OnDemuxerStreamRead,
weak_factory_.GetWeakPtr()));
streams.push_back(wrapper.get());
streams_[chunk_demuxer_stream] = std::move(wrapper);
}
return streams;
}Arthur Sonzogni . resolved
Formatting issue here. Could you please re-indent back to its original state?
José Arturo Barrera
Marked as resolved.
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Arturo Barrera (Gerrit)
Jun 23, 2026, 5:12:28 PM (8 days ago) Jun 23
to Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Arthur Sonzogni, Colin Blundell and José Arturo Barrera
José Arturo Barrera voted and added 1 comment![]( "Open in Gerrit")
Votes added by José Arturo Barrera
| Commit-Queue | +1 |
1 comment
File chrome/browser/ui/webui/cr_components/searchbox/contextual_searchbox_handler.cc
Line 1626, Patchset 5:
std::vector<raw_ptr<const contextual_search::FileInfo>> file_info_list;Arthur Sonzogni . resolved
Seems unused. Maybe a preliminary CL removing this variable?
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Arturo Barrera (Gerrit)
Jun 24, 2026, 8:56:59 AM (7 days ago) Jun 24
to Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Arthur Sonzogni and Colin Blundell
José Arturo Barrera added 1 comment![]( "Open in Gerrit")
Patchset-level comments
José Arturo Barrera . unresolved
Arthur Sonzogni@arthurs...@chromium.org, do you think we should split this CL? If so, do you have any suggestions, like split by folder?
Me + @blun...@chromium.org would cover every files, except 1. So 3 reviewers would be enough here.
---
How many patches like this do you think we will be submitted?
José Arturo Barrera
by now this CL is the biggest one, but another remains to be worked and may increase its size is https://chromium-review.git.corp.google.com/c/chromium/src/+/7957993
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Arturo Barrera (Gerrit)
Jun 24, 2026, 5:03:02 PM (7 days ago) Jun 24
to Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Arthur Sonzogni and Colin Blundell
José Arturo Barrera added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Arthur Sonzogni@arthurs...@chromium.org, do you think we should split this CL? If so, do you have any suggestions, like split by folder?
José Arturo BarreraMe + @blun...@chromium.org would cover every files, except 1. So 3 reviewers would be enough here.
---
How many patches like this do you think we will be submitted?
by now this CL is the biggest one, but another remains to be worked and may increase its size is https://chromium-review.git.corp.google.com/c/chromium/src/+/7957993
José Arturo Barrera
Done
File third_party/blink/renderer/core/exported/web_media_player_impl_unittest.cc
Line 3404, Patchset 5:
decltype(demuxer->GetAllStreams()) streams;Arthur Sonzogni . resolved
Can we use the real type here?
José Arturo Barrera
The section "Pointers to unprotected memory (performance optimization)" in the file https://source.chromium.org/chromium/chromium/src/+/main:base/memory/raw_ptr.md states that `raw_ptr` is disallowed in `third_party/blink/renderer/core/`. So this change may be discarded
José Arturo Barrera
definition modified to not include `raw_ptr`
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Jun 25, 2026, 5:08:52 AM (6 days ago) Jun 25
to José Arturo Barrera, Colin Blundell, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Colin Blundell and José Arturo Barrera
Arthur Sonzogni added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Arthur Sonzogni . resolved
Thanks!
File components/optimization_guide/core/model_execution/on_device_model_service_controller_unittest.cc
Line 171, Patchset 8 (Latest):
struct InitializeParams {Arthur Sonzogni . unresolved
If this is only parameters, we could add STACK_ALLOCATED and not have to use raw_ptr here. (The clang-plugin knows about STACK_ALLOCATED parameters)
File media/filters/manifest_demuxer.cc
Line 90, Patchset 8 (Latest):
// For each stream that ChunkDemuxer returns, we need to wrap it so that
// we can grab the timestamp. Chunk demuxer's streams live forever, so
// ours might as well also live forever, even if that leaks a small
// amount of memory.
// TODO(crbug.com/40057824): Rearchitect the demuxer stream ownership
// model to prevent long-lived streams from potentially leaking memory.Arthur Sonzogni . unresolved
Why was this comment updated? Can you please revert?
Related details
Attention is currently required from:
- Colin Blundell
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Arturo Barrera (Gerrit)
Jun 25, 2026, 9:58:18 AM (6 days ago) Jun 25
to Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Arthur Sonzogni and Colin Blundell
José Arturo Barrera added 2 comments![]( "Open in Gerrit")
File components/optimization_guide/core/model_execution/on_device_model_service_controller_unittest.cc
If this is only parameters, we could add STACK_ALLOCATED and not have to use raw_ptr here. (The clang-plugin knows about STACK_ALLOCATED parameters)
José Arturo Barrera
yes, it was really stack allocated. However, adding `STACK_ALLOCATED()` to the struct causes the compiler to throw errors, as the macro removes the aggregate status required for designated initializers. For such reason, the modifications on this file were reverted
File media/filters/manifest_demuxer.cc
Line 90, Patchset 8:
// For each stream that ChunkDemuxer returns, we need to wrap it so that
// we can grab the timestamp. Chunk demuxer's streams live forever, so
// ours might as well also live forever, even if that leaks a small
// amount of memory.
// TODO(crbug.com/40057824): Rearchitect the demuxer stream ownership
// model to prevent long-lived streams from potentially leaking memory.Arthur Sonzogni . resolved
Why was this comment updated? Can you please revert?
José Arturo Barrera
Appears it was updated due to the format tool. Reverting it.
Related details
Attention is currently required from:
- Arthur Sonzogni
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Jun 26, 2026, 9:22:05 AM (5 days ago) Jun 26
to José Arturo Barrera, Colin Blundell, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from Colin Blundell and José Arturo Barrera
Arthur Sonzogni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Code-Review | +1 |
Arthur Sonzogni . resolved
Thanks!
Attention is currently required from:
- Colin Blundell
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jun 26, 2026, 9:27:30 AM (5 days ago) Jun 26
to José Arturo Barrera, Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from José Arturo Barrera
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shawn Quereshi (Gerrit)
Jun 26, 2026, 2:26:23 PM (5 days ago) Jun 26
to José Arturo Barrera, Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Attention needed from José Arturo Barrera
Shawn Quereshi voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Arturo Barrera (Gerrit)
Jun 26, 2026, 2:48:30 PM (5 days ago) Jun 26
to Shawn Quereshi, Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
José Arturo Barrera voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Arturo Barrera (Gerrit)
Jun 26, 2026, 5:46:23 PM (5 days ago) Jun 26
to Shawn Quereshi, Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Chromium LUCI CQ (Gerrit)
Jun 26, 2026, 8:44:38 PM (5 days ago) Jun 26
to José Arturo Barrera, Shawn Quereshi, Colin Blundell, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, mfoltz+wa...@chromium.org, jophba...@chromium.org, erickun...@chromium.org, blink-...@chromium.org, halliwe...@chromium.org, asvitki...@chromium.org, browser-comp...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[MiraclePtr] Rewrite templated container fields to raw_ptr
Automates the conversion of raw pointers within templated containers
(e.g., `std::vector`, `std::set`) to `raw_ptr` via the
`rewrite_templated_container_fields` tool, alongside necessary
manual build fixes.
This advances MiraclePtr's expansion to containers and preempts an
upcoming clang-plugin update that will strictly ban these un-rewritten
instances.
Bug: 501142609
Doc: go/miracleptr-in-containers
Change-Id: I4537fdab2e912919249bec9092af4a77afa73343
Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
Reviewed-by: Shawn Quereshi <sha...@google.com>
Commit-Queue: José Arturo Barrera <jabgo...@google.com>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1653559}
Files:
- M chrome/browser/contextual_tasks/contextual_tasks_composebox_handler_browsertest.cc
- M chrome/browser/ui/views/tabs/projects/projects_panel_recent_threads_view.h
- M chrome/browser/ui/views/tabs/projects/projects_panel_recent_threads_view_unittest.cc
- M chrome/browser/ui/views/tabs/projects/projects_panel_tab_groups_view.h
- M chrome/browser/ui/views/tabs/projects/projects_panel_tab_groups_view_unittest.cc
- M chromecast/starboard/media/renderer/starboard_renderer_test.cc
- M components/autofill/core/browser/data_model/addresses/autofill_i18n_api.cc
- M components/autofill/core/browser/data_model/addresses/autofill_structured_address_component.h
- M components/cast_streaming/renderer/frame/frame_injecting_demuxer.cc
- M components/cast_streaming/renderer/frame/frame_injecting_demuxer.h
- M components/contextual_search/contextual_search_context_controller.h
- M components/contextual_search/input_state_model_unittest.cc
- M components/contextual_search/internal/composebox_query_controller.cc
- M components/contextual_search/internal/composebox_query_controller.h
- M components/contextual_search/mock_contextual_search_context_controller.h
- M components/contextual_tasks/public/query_contextualizer.cc
- M components/contextual_tasks/public/query_contextualizer_unittest.cc
- M components/global_media_controls/public/views/media_item_ui_updated_view.h
- M components/heap_profiling/multi_process/test_driver.h
- M components/live_caption/views/translation_view_wrapper_base.h
- M components/variations/variations_ids_provider.cc
- M components/variations/variations_ids_provider.h
- M media/base/fake_demuxer_stream.cc
- M media/base/fake_demuxer_stream.h
- M media/base/media_resource.h
- M media/base/mock_filters.h
- M media/base/pipeline_impl.cc
- M media/base/pipeline_impl_unittest.cc
- M media/filters/chunk_demuxer.cc
- M media/filters/chunk_demuxer.h
- M media/filters/chunk_demuxer_unittest.cc
- M media/filters/decrypting_media_resource.cc
- M media/filters/decrypting_media_resource.h
- M media/filters/decrypting_media_resource_unittest.cc
- M media/filters/demuxer_perftest.cc
- M media/filters/ffmpeg_demuxer.cc
- M media/filters/ffmpeg_demuxer.h
- M media/filters/ffmpeg_demuxer_unittest.cc
- M media/filters/hls_manifest_demuxer_engine.cc
- M media/filters/hls_manifest_demuxer_engine.h
- M media/filters/manifest_demuxer.cc
- M media/filters/manifest_demuxer.h
- M media/filters/manifest_demuxer_unittest.cc
- M media/mojo/clients/mojo_renderer.cc
- M media/mojo/clients/mojo_renderer_unittest.cc
- M media/mojo/services/media_resource_shim.cc
- M media/mojo/services/media_resource_shim.h
- M media/remoting/fake_media_resource.cc
- M media/remoting/fake_media_resource.h
- M media/remoting/stream_provider.cc
- M media/remoting/stream_provider.h
- M media/remoting/stream_provider_unittest.cc
- M media/renderers/decrypting_renderer_unittest.cc
- M media/renderers/renderer_impl.cc
- M media/renderers/renderer_impl_unittest.cc
- M media/renderers/win/media_foundation_renderer_unittest.cc
- M third_party/blink/renderer/core/exported/web_media_player_impl_unittest.cc
Change size: L
Delta: 57 files changed, 172 insertions(+), 133 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell, +1 by Shawn Quereshi, +1 by Arthur Sonzogni
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
José Arturo Barrera (Gerrit)
Jun 30, 2026, 12:32:56 PM (23 hours ago) Jun 30
to Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from José Arturo Barrera
Message from José Arturo Barrera![]( "Open in Gerrit")
Attention is currently required from:
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Jun 30, 2026, 1:00:32 PM (23 hours ago) Jun 30
to José Arturo Barrera, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Arthur Sonzogni and José Arturo Barrera
Arthur Sonzogni added 2 comments![]( "Open in Gerrit")
Message
**[Early Review]** This is an automated early review generated by an LLM. It is intended to help you catch obvious issues early and **potentially save a round of code review**.
If you find any suggestion irrelevant, please feel free to *ignore* or *close* it.
_I am going to take a look immediately._
Please see suggestions below.
2 comments
File media/filters/hls_manifest_demuxer_engine.cc
Line 346, Patchset 8 (Latest):
std::erase_if(all_streams, [](raw_ptr<DemuxerStream> stream) {Arthur Sonzogni . unresolved
**[Early Review]**
Lambda parameters should use raw pointers (e.g., `DemuxerStream*`) instead of `raw_ptr<T>`. Passing `raw_ptr` by value incurs unnecessary ref-counting overhead under BackupRefPtr.
Line 352, Patchset 8 (Latest):
std::erase_if(all_streams, [](raw_ptr<DemuxerStream> stream) {Arthur Sonzogni . unresolved
**[Early Review]**
Lambda parameters should use raw pointers (e.g., `DemuxerStream*`) instead of `raw_ptr<T>`. Passing `raw_ptr` by value incurs unnecessary ref-counting overhead under BackupRefPtr.
Related details
Attention is currently required from:
- Arthur Sonzogni
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
9:35 AM (2 hours ago) 9:35 AM
to José Arturo Barrera, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, erickun...@chromium.org, feature-me...@chromium.org, jophba...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from José Arturo Barrera
Arthur Sonzogni voted and added 3 comments![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Code-Review | +1 |
3 comments
Patchset-level comments
File media/filters/hls_manifest_demuxer_engine.cc
Line 346, Patchset 8 (Latest):
std::erase_if(all_streams, [](raw_ptr<DemuxerStream> stream) {Arthur Sonzogni . resolved
**[Early Review]**
Lambda parameters should use raw pointers (e.g., `DemuxerStream*`) instead of `raw_ptr<T>`. Passing `raw_ptr` by value incurs unnecessary ref-counting overhead under BackupRefPtr.
Arthur Sonzogni
Acknowledged
Line 352, Patchset 8 (Latest):
std::erase_if(all_streams, [](raw_ptr<DemuxerStream> stream) {Arthur Sonzogni . resolved
**[Early Review]**
Lambda parameters should use raw pointers (e.g., `DemuxerStream*`) instead of `raw_ptr<T>`. Passing `raw_ptr` by value incurs unnecessary ref-counting overhead under BackupRefPtr.
Attention is currently required from:
- José Arturo Barrera
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages