Disable Symphonia in ffmpeg tests [chromium/src : main]
0 views
Skip to first unread message
Jordan Bayles (Gerrit)
Jun 26, 2026, 4:31:10 PM (4 days ago) Jun 26
to Eugene Zemtsov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Eugene Zemtsov
Jordan Bayles voted and added 1 comment![]( "Open in Gerrit")
Votes added by Jordan Bayles
| Code-Review | +1 |
1 comment
File media/ffmpeg/ffmpeg_regression_tests.cc
Line 71, Patchset 2 (Latest):
kSymphoniaAudioDecoding,Jordan Bayles . unresolved
Also include `kDirectOpusAudioDecoding` to disable use of the new `OpusAudioDecoder` for testing? It's not Symphonia exactly but it's part of the Symphonia family of experiments.
Related details
Attention is currently required from:
- Eugene Zemtsov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Jun 26, 2026, 4:52:43 PM (4 days ago) Jun 26
to Eugene Zemtsov, Jordan Bayles, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org
Eugene Zemtsov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Eugene Zemtsov
| Commit-Queue | +2 |
1 comment
File media/ffmpeg/ffmpeg_regression_tests.cc
Also include `kDirectOpusAudioDecoding` to disable use of the new `OpusAudioDecoder` for testing? It's not Symphonia exactly but it's part of the Symphonia family of experiments.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 26, 2026, 5:42:55 PM (4 days ago) Jun 26
to Eugene Zemtsov, Jordan Bayles, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: media/ffmpeg/ffmpeg_regression_tests.cc
Insertions: 2, Deletions: 0.
@@ -67,6 +67,7 @@
public:
FFmpegRegressionTest() {
scoped_feature_list_.InitWithFeatures({}, /*disabled_features=*/{
+ kDirectOpusAudioDecoding,
#if BUILDFLAG(ENABLE_SYMPHONIA)
kSymphoniaAudioDecoding,
kSymphoniaMp3Decoding,
@@ -86,6 +87,7 @@
public:
FlakyFFmpegRegressionTest() {
scoped_feature_list_.InitWithFeatures({}, /*disabled_features=*/{
+ kDirectOpusAudioDecoding,
#if BUILDFLAG(ENABLE_SYMPHONIA)
kSymphoniaAudioDecoding,
kSymphoniaMp3Decoding,
```
Change information
Commit message:
Disable Symphonia in ffmpeg tests
Bug: 527501449
Change-Id: I92f1a6b88491c73406cad68a856c5b4e6726ddb5
Commit-Queue: Eugene Zemtsov <eug...@chromium.org>
Reviewed-by: Jordan Bayles <jop...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1653467}
Files:
- M media/ffmpeg/BUILD.gn
- M media/ffmpeg/ffmpeg_regression_tests.cc
Change size: S
Delta: 2 files changed, 33 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Jordan Bayles
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages