[iOS] Add AutofillAIEntityEditMediatorDelegate [chromium/src : main]
0 views
Skip to first unread message
Alexis Hétu (Gerrit)
Apr 17, 2026, 2:04:07 PM (6 days ago) Apr 17
to Vidhan Jain, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Vidhan Jain
Alexis Hétu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Alexis Hétu . unresolved
I'm fine with the change, but you'll need to fix the tests.
Related details
Attention is currently required from:
- Vidhan Jain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vidhan Jain (Gerrit)
9:34 AM (6 hours ago) 9:34 AM
to Alexis Hétu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Alexis Hétu
Vidhan Jain added 1 comment![]( "Open in Gerrit")
Patchset-level comments
I'm fine with the change, but you'll need to fix the tests.
Attention is currently required from:
- Alexis Hétu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexis Hétu (Gerrit)
11:13 AM (4 hours ago) 11:13 AM
to Vidhan Jain, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Vidhan Jain
Alexis Hétu voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Vidhan Jain
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vidhan Jain (Gerrit)
11:17 AM (4 hours ago) 11:17 AM
to Alexis Hétu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Vidhan Jain voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
11:21 AM (4 hours ago) 11:21 AM
to Vidhan Jain, Alexis Hétu, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Add AutofillAIEntityEditMediatorDelegate
Because iOS Settings operate natively outside of a WebState context, the
AutofillAIEntityEditMediator relies on injected KeyedServices and lacks
direct access to a `Profile*`. Therefore, it could not easily evaluate
`autofill::CanPerformAutofillAiAction` to ensure the user is still
eligible to save to Google Wallet.
To resolve this cleanly without coupling the Mediator to the Profile:
1. Introduced `AutofillAIEntityEditMediatorDelegate` with a
`canPerformWalletSaveForType:` method.
2. `AutofillAIEntityEditCoordinator` now conforms to this protocol,
leveraging its access to `Browser` and `Profile` to call
`CanPerformAutofillAiAction`.
3. `AutofillAIEntityEditMediator` queries its delegate immediately
before triggering an asynchronous Wallet save. This guards against
edge cases where the user's eligibility changes (e.g., signing out
in another tab) while the settings view remains open.
Bug: 496450943
Change-Id: I6d7b43ef53f31fb0e58dd4fb94549a387a0fbc0f
Commit-Queue: Vidhan Jain <vid...@google.com>
Reviewed-by: Alexis Hétu <su...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1619535}
Files:
- M ios/chrome/browser/settings/autofill/autofill_ai/coordinator/autofill_ai_entity_edit_coordinator.mm
- M ios/chrome/browser/settings/autofill/autofill_ai/coordinator/autofill_ai_entity_edit_mediator.h
- M ios/chrome/browser/settings/autofill/autofill_ai/coordinator/autofill_ai_entity_edit_mediator.mm
- M ios/chrome/browser/settings/autofill/autofill_ai/coordinator/autofill_ai_entity_edit_mediator_unittest.mm
Change size: M
Delta: 4 files changed, 69 insertions(+), 19 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexis Hétu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages