Remove PlusAddressService::IsPlusAddressCreationEnabled() [chromium/src : main]

0 views
Skip to first unread message

Jihad Hanna (Gerrit)

unread,
8:44 AM (10 hours ago) 8:44 AM
to Jan Keitel, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, bcb+watch-pl...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jkeitel+watch-...@google.com, kaklilu+watch-...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Jan Keitel

Jihad Hanna voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Jan Keitel
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29260304e0578a1a265f7f15ff4d9ecd1cd22d56
Gerrit-Change-Number: 7141784
Gerrit-PatchSet: 5
Gerrit-Owner: Jihad Hanna <jihad...@google.com>
Gerrit-Reviewer: Jan Keitel <jke...@google.com>
Gerrit-Reviewer: Jihad Hanna <jihad...@google.com>
Gerrit-Attention: Jan Keitel <jke...@google.com>
Gerrit-Comment-Date: Wed, 12 Nov 2025 13:44:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jan Keitel (Gerrit)

unread,
10:13 AM (8 hours ago) 10:13 AM
to Jihad Hanna, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, bcb+watch-pl...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jkeitel+watch-...@google.com, kaklilu+watch-...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Jihad Hanna

Jan Keitel voted and added 1 comment

Votes added by Jan Keitel

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Jan Keitel . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Jihad Hanna
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I29260304e0578a1a265f7f15ff4d9ecd1cd22d56
    Gerrit-Change-Number: 7141784
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jihad Hanna <jihad...@google.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Jihad Hanna <jihad...@google.com>
    Gerrit-Attention: Jihad Hanna <jihad...@google.com>
    Gerrit-Comment-Date: Wed, 12 Nov 2025 15:13:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jihad Hanna (Gerrit)

    unread,
    10:19 AM (8 hours ago) 10:19 AM
    to Jan Keitel, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, bcb+watch-pl...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jkeitel+watch-...@google.com, kaklilu+watch-...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Christoph Schwering

    Jihad Hanna voted and added 1 comment

    Votes added by Jihad Hanna

    Auto-Submit+1
    Commit-Queue+1

    1 comment

    Patchset-level comments
    Jihad Hanna . resolved

    Hey Chris, this CL removes a deprecated functionality, and touches some iOS code. Is it okay to ask you to stamp this or should I ask another iOS OWNER? thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Christoph Schwering
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I29260304e0578a1a265f7f15ff4d9ecd1cd22d56
    Gerrit-Change-Number: 7141784
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jihad Hanna <jihad...@google.com>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Jihad Hanna <jihad...@google.com>
    Gerrit-Attention: Christoph Schwering <schw...@google.com>
    Gerrit-Comment-Date: Wed, 12 Nov 2025 15:19:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Christoph Schwering (Gerrit)

    unread,
    10:29 AM (8 hours ago) 10:29 AM
    to Jihad Hanna, Vincent Boisselle, Jan Keitel, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, bcb+watch-pl...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jkeitel+watch-...@google.com, kaklilu+watch-...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Jihad Hanna

    Christoph Schwering voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jihad Hanna
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I29260304e0578a1a265f7f15ff4d9ecd1cd22d56
    Gerrit-Change-Number: 7141784
    Gerrit-PatchSet: 6
    Gerrit-Owner: Jihad Hanna <jihad...@google.com>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Jihad Hanna <jihad...@google.com>
    Gerrit-CC: Vincent Boisselle <vi...@google.com>
    Gerrit-Attention: Jihad Hanna <jihad...@google.com>
    Gerrit-Comment-Date: Wed, 12 Nov 2025 15:28:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    10:31 AM (8 hours ago) 10:31 AM
    to Jihad Hanna, Vincent Boisselle, Jan Keitel, AyeAye, chromium...@chromium.org, gcasto+w...@chromium.org, vasilii+watchlis...@chromium.org, bcb+watch-pl...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, jkeitel+watch-...@google.com, kaklilu+watch-...@chromium.org, marimatthew+watc...@google.com, marq+...@chromium.org, minap+watch-p...@google.com, mreichhoff+watc...@chromium.org, tmartino+tran...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove PlusAddressService::IsPlusAddressCreationEnabled()

    This is part of deprecating the functionality to create a plus address.
    Bug: 456507463
    Change-Id: I29260304e0578a1a265f7f15ff4d9ecd1cd22d56
    Auto-Submit: Jihad Hanna <jihad...@google.com>
    Commit-Queue: Christoph Schwering <schw...@google.com>
    Reviewed-by: Christoph Schwering <schw...@google.com>
    Reviewed-by: Jan Keitel <jke...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1543727}
    Files:
    • M chrome/browser/keyboard_accessory/android/address_accessory_controller_impl.cc
    • M chrome/browser/keyboard_accessory/android/address_accessory_controller_impl_unittest.cc
    • M chrome/browser/keyboard_accessory/android/password_accessory_controller_impl.cc
    • M chrome/browser/keyboard_accessory/android/password_accessory_controller_impl_unittest.cc
    • M components/plus_addresses/core/browser/fake_plus_address_service.cc
    • M components/plus_addresses/core/browser/fake_plus_address_service.h
    • M components/plus_addresses/core/browser/plus_address_service.h
    • M components/plus_addresses/core/browser/plus_address_service_impl.cc
    • M components/plus_addresses/core/browser/plus_address_service_impl.h
    • M components/plus_addresses/core/browser/plus_address_service_impl_unittest.cc
    • M ios/chrome/browser/autofill/ui_bundled/manual_fill/manual_fill_plus_address_mediator.mm
    • M ios/chrome/browser/autofill/ui_bundled/manual_fill/plus_address_manual_fill_egtest.mm
    • M ios/chrome/browser/plus_addresses/ui/plus_address_app_interface.h
    • M ios/chrome/browser/plus_addresses/ui/plus_address_app_interface.mm
    Change size: L
    Delta: 14 files changed, 1 insertion(+), 364 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Christoph Schwering, +1 by Jan Keitel
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I29260304e0578a1a265f7f15ff4d9ecd1cd22d56
    Gerrit-Change-Number: 7141784
    Gerrit-PatchSet: 7
    Gerrit-Owner: Jihad Hanna <jihad...@google.com>
    Gerrit-Reviewer: Christoph Schwering <schw...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-Reviewer: Jihad Hanna <jihad...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages