Adds kCastMirroringPlayoutDelay to flags ui. [chromium/src : main]

george benz (Gerrit)

unread,

May 1, 2023, 8:14:42 PM5/1/23

to asvitki...@chromium.org, cros-ed...@google.com, feature-me...@chromium.org, jmedle...@chromium.org, mfoltz...@chromium.org

george benz uploaded patch set #2 to this change.

View Change

Adds kCastMirroringPlayoutDelay to flags ui.

Adds the kCastMirroringPlayoutDelay switch to flags ui with 400 (default), 350, 200, 150, and 100ms options.

Bug:b/280320030
Change-Id: I125967fb94b4ba5985066fdc2767cee290eb5573
---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M chrome/browser/media/router/providers/cast/mirroring_activity_unittest.cc
5 files changed, 54 insertions(+), 1 deletion(-)

To view, visit change 4496666. To unsubscribe, or for help writing mail filters, visit settings.

george benz (Gerrit)

unread,

May 2, 2023, 3:51:28 PM5/2/23

to Benjamin Zielinski, asvitki...@chromium.org, cros-ed...@google.com, feature-me...@chromium.org, jmedle...@chromium.org, mfoltz...@chromium.org

Attention is currently required from: Benjamin Zielinski.

george benz would like Benjamin Zielinski to review this change.

View Change

Adds kCastMirroringPlayoutDelay to flags ui.

Adds the kCastMirroringPlayoutDelay switch to flags ui with 400 (default), 350, 200, 150, and 100ms options.

Bug:b/280320030
Change-Id: I125967fb94b4ba5985066fdc2767cee290eb5573
---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h

M tools/metrics/histograms/enums.xml
5 files changed, 56 insertions(+), 0 deletions(-)

To view, visit change 4496666. To unsubscribe, or for help writing mail filters, visit settings.

george benz (Gerrit)

unread,

May 2, 2023, 3:51:31 PM5/2/23

to asvitki...@chromium.org, cros-ed...@google.com, feature-me...@chromium.org, jmedle...@chromium.org, mfoltz...@chromium.org, Benjamin Zielinski, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Benjamin Zielinski.

View Change

1 comment:

Patchset:
- Patch Set #4:
  Hi Ben,
  PTAL at flag changes and descriptions for target playout delay. Thanks!

To view, visit change 4496666. To unsubscribe, or for help writing mail filters, visit settings.

Benjamin Zielinski (Gerrit)

unread,

May 2, 2023, 4:41:28 PM5/2/23

to george benz, asvitki...@chromium.org, cros-ed...@google.com, feature-me...@chromium.org, jmedle...@chromium.org, mfoltz...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: george benz.

Patch set 4:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #4:
  👍

To view, visit change 4496666. To unsubscribe, or for help writing mail filters, visit settings.

george benz (Gerrit)

unread,

May 2, 2023, 5:30:29 PM5/2/23

to asvitki...@chromium.org, cros-ed...@google.com, feature-me...@chromium.org, jmedle...@chromium.org, mfoltz...@chromium.org, Benjamin Zielinski, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: george benz.

Patch set 4:Commit-Queue +2

View Change

To view, visit change 4496666. To unsubscribe, or for help writing mail filters, visit settings.

george benz (Gerrit)

unread,

May 2, 2023, 5:53:25 PM5/2/23

to asvitki...@chromium.org, cros-ed...@google.com, feature-me...@chromium.org, jmedle...@chromium.org, mfoltz...@chromium.org, Benjamin Zielinski, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: george benz.

Patch set 5:Commit-Queue +2

View Change

To view, visit change 4496666. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

May 2, 2023, 7:39:28 PM5/2/23

to george benz, asvitki...@chromium.org, cros-ed...@google.com, feature-me...@chromium.org, jmedle...@chromium.org, mfoltz...@chromium.org, Benjamin Zielinski, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change



4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Approvals:
  Benjamin Zielinski: Looks good to me
  george benz: Commit

Adds kCastMirroringPlayoutDelay to flags ui.

Adds the kCastMirroringPlayoutDelay switch to flags ui with 400 (default), 350, 200, 150, and 100ms options.

Bug: b/280320030
Change-Id: I125967fb94b4ba5985066fdc2767cee290eb5573

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4496666
Reviewed-by: Benjamin Zielinski <bziel...@google.com>
Commit-Queue: george benz <g...@google.com>
Cr-Commit-Position: refs/heads/main@{#1138665}


---
M chrome/browser/about_flags.cc
M chrome/browser/flag-metadata.json
M chrome/browser/flag_descriptions.cc
M chrome/browser/flag_descriptions.h
M tools/metrics/histograms/enums.xml
5 files changed, 56 insertions(+), 0 deletions(-)

To view, visit change 4496666. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward