Add @JniType to a batch of files in //components (#1) [chromium/src : main]

0 views
Skip to first unread message

Andrew Grieve (Gerrit)

unread,
Mar 11, 2026, 9:17:49 AMMar 11
to Andrew Grieve, Sam Maier, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, dibyapal+wa...@chromium.org, feature-me...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Sam Maier

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Sam Maier
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2cbd30b0e7af59a29bb9dda484fa6ad52c0a89f0
Gerrit-Change-Number: 7644615
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Sam Maier <sma...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Sam Maier <sma...@google.com>
Gerrit-Comment-Date: Wed, 11 Mar 2026 13:17:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sam Maier (Gerrit)

unread,
Mar 11, 2026, 10:58:29 AMMar 11
to Andrew Grieve, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, dibyapal+wa...@chromium.org, feature-me...@chromium.org, mfoltz+wa...@chromium.org
Attention needed from Andrew Grieve

Sam Maier voted and added 1 comment

Votes added by Sam Maier

Code-Review+1

1 comment

File components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java
Line 182, Patchset 1 (Latest): @JniType("std::string") @Nullable String appId,
Sam Maier . unresolved

Feels like if they are nullable they should be optional?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2cbd30b0e7af59a29bb9dda484fa6ad52c0a89f0
    Gerrit-Change-Number: 7644615
    Gerrit-PatchSet: 1
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Sam Maier <sma...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 14:58:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Grieve (Gerrit)

    unread,
    Mar 11, 2026, 2:03:43 PMMar 11
    to Andrew Grieve, Sam Maier, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, dibyapal+wa...@chromium.org, feature-me...@chromium.org, mfoltz+wa...@chromium.org

    Andrew Grieve voted and added 1 comment

    Votes added by Andrew Grieve

    Commit-Queue+2
    Owners-Override+1

    1 comment

    File components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java
    Line 182, Patchset 1 (Latest): @JniType("std::string") @Nullable String appId,
    Sam Maier . resolved

    Feels like if they are nullable they should be optional?

    Andrew Grieve

    I think it depends on if the native side distinguished between "" and nullopt. If not, then it just forces you to have to check for both instead of just one.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2cbd30b0e7af59a29bb9dda484fa6ad52c0a89f0
    Gerrit-Change-Number: 7644615
    Gerrit-PatchSet: 1
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Sam Maier <sma...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Comment-Date: Wed, 11 Mar 2026 18:03:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Sam Maier <sma...@google.com>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 11, 2026, 3:43:05 PMMar 11
    to Andrew Grieve, Sam Maier, chromium...@chromium.org, Peter Beverloo, dibyapal+wa...@chromium.org, feature-me...@chromium.org, mfoltz+wa...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add @JniType to a batch of files in //components (#1)
    Bug: 491444984
    Change-Id: I2cbd30b0e7af59a29bb9dda484fa6ad52c0a89f0
    Cq-Include-Trybots: luci.chrome.try:android-internal-dbg,android-internal-binary-size
    Reviewed-by: Sam Maier <sma...@google.com>
    Commit-Queue: Andrew Grieve <agr...@chromium.org>
    Owners-Override: Andrew Grieve <agr...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1597928}
    Files:
    • M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java
    • M components/gcm_driver/gcm_driver_android.cc
    • M components/gcm_driver/gcm_driver_android.h
    • M components/media_router/browser/android/java/src/org/chromium/components/media_router/BrowserMediaRouter.java
    • M components/media_router/browser/android/media_router_android_bridge.cc
    • M components/media_router/browser/android/media_router_android_bridge.h
    • M components/segmentation_platform/internal/android/java/src/org/chromium/components/segmentation_platform/SegmentationPlatformServiceImpl.java
    • M components/segmentation_platform/internal/android/segmentation_platform_service_android.cc
    • M components/segmentation_platform/internal/android/segmentation_platform_service_android.h
    Change size: L
    Delta: 9 files changed, 222 insertions(+), 241 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Sam Maier
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2cbd30b0e7af59a29bb9dda484fa6ad52c0a89f0
    Gerrit-Change-Number: 7644615
    Gerrit-PatchSet: 2
    Gerrit-Owner: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Sam Maier <sma...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages