[gDM] DisplayMediaAccessHandler: Use WeakPtr for picker callback [chromium/src : main]
0 views
Skip to first unread message
Guido Urdaneta (Gerrit)
4:35 AM (6 hours ago) 4:35 AM
to Henrik Andreasson, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Henrik Andreasson
Guido Urdaneta added 1 comment![]( "Open in Gerrit")
File chrome/browser/media/webrtc/display_media_access_handler.cc
Line 392, Patchset 4:
if (web_contents->GetLastCommittedURL().GetScheme() !=Guido Urdaneta . unresolved
Add a `DCHECK_CURRENTLY_ON(content::BrowserThread::UI);` for extra clarity.
Related details
Attention is currently required from:
- Henrik Andreasson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Henrik Andreasson (Gerrit)
4:56 AM (6 hours ago) 4:56 AM
to Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Guido Urdaneta
Henrik Andreasson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Henrik Andreasson
| Commit-Queue | +1 |
1 comment
File chrome/browser/media/webrtc/display_media_access_handler.cc
Line 392, Patchset 4:
if (web_contents->GetLastCommittedURL().GetScheme() !=Guido Urdaneta . resolved
Add a `DCHECK_CURRENTLY_ON(content::BrowserThread::UI);` for extra clarity.
Attention is currently required from:
- Guido Urdaneta
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guido Urdaneta (Gerrit)
4:59 AM (6 hours ago) 4:59 AM
to Henrik Andreasson, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org
Attention needed from Henrik Andreasson
Guido Urdaneta voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Henrik Andreasson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Henrik Andreasson (Gerrit)
5:00 AM (6 hours ago) 5:00 AM
to Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org
Henrik Andreasson voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:01 AM (5 hours ago) 6:01 AM
to Henrik Andreasson, Olga Sharonova, Guido Urdaneta, chromium...@chromium.org, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, chfreme...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[gDM] DisplayMediaAccessHandler: Use WeakPtr for picker callback
Replaces base::Unretained(this) with a WeakPtr in the
OnDesktopCaptureDevicesObtainedAfterBypassMediaSelectionDialog callback.
Previously, the code relied on the assumption that the
DisplayMediaAccessHandler (owned by the MediaCaptureDevicesDispatcher
singleton) would always outlive the picker dialog. While this is
currently true due to destruction order, using WeakPtr is safer and
prevents potential Use-After-Free bugs if the ownership model changes or
during complex shutdown scenarios.
Bug: 40947205
Test: Manual verification of screen sharing picker sharing a window and running Chrome with --enable-features=ApplicationAudioCaptureWin
Change-Id: I5c2366fa75d82afb1d481ea0b4da29fa4f7f57d0
Reviewed-by: Guido Urdaneta <gui...@chromium.org>
Commit-Queue: Henrik Andreasson <hen...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572845}
Files:
- M chrome/browser/media/webrtc/display_media_access_handler.cc
- M chrome/browser/media/webrtc/display_media_access_handler.h
Change size: XS
Delta: 2 files changed, 3 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Guido Urdaneta
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages