Revert "Reland "Add LockTopControlsV2 to field trial testing config"" [chromium/src : main]

0 views
Skip to first unread message

Nicola Tommasi (Gerrit)

unread,
Jan 20, 2026, 6:42:04 AM (19 hours ago) Jan 20
to Nicola Tommasi, Rubber Stamper, Sirisha Kavuluru, Chromium LUCI CQ, Theresa Sullivan, Wenyu Fu, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium Metrics Reviews, feature-me...@chromium.org, twelling...@chromium.org, lizeb+watch...@chromium.org, gangwu...@chromium.org, browser-comp...@chromium.org, sloboda...@chromium.org, donnd...@chromium.org, asvitkine...@chromium.org
Attention needed from Sirisha Kavuluru, Theresa Sullivan and Wenyu Fu

Nicola Tommasi voted

Auto-Submit+1
Commit-Queue+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sirisha Kavuluru
  • Theresa Sullivan
  • Wenyu Fu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I863a62398110bc941eed12cc8fa6a8d8205aa2fd
Gerrit-Change-Number: 7497154
Gerrit-PatchSet: 1
Gerrit-Owner: Nicola Tommasi <tomm...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Nicola Tommasi <tomm...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
Gerrit-Attention: Theresa Sullivan <twell...@chromium.org>
Gerrit-Attention: Wenyu Fu <wen...@chromium.org>
Gerrit-Comment-Date: Tue, 20 Jan 2026 11:41:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Jan 20, 2026, 6:42:19 AM (19 hours ago) Jan 20
to Nicola Tommasi, Sirisha Kavuluru, Chromium LUCI CQ, Theresa Sullivan, Wenyu Fu, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium Metrics Reviews, feature-me...@chromium.org, twelling...@chromium.org, lizeb+watch...@chromium.org, gangwu...@chromium.org, browser-comp...@chromium.org, sloboda...@chromium.org, donnd...@chromium.org, asvitkine...@chromium.org
Attention needed from Sirisha Kavuluru, Theresa Sullivan and Wenyu Fu

Rubber Stamper voted

Bot-Commit+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Sirisha Kavuluru
  • Theresa Sullivan
  • Wenyu Fu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I863a62398110bc941eed12cc8fa6a8d8205aa2fd
    Gerrit-Change-Number: 7497154
    Gerrit-PatchSet: 1
    Gerrit-Owner: Nicola Tommasi <tomm...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Nicola Tommasi <tomm...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
    Gerrit-Reviewer: Wenyu Fu <wen...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Sirisha Kavuluru <skav...@google.com>
    Gerrit-Attention: Theresa Sullivan <twell...@chromium.org>
    Gerrit-Attention: Wenyu Fu <wen...@chromium.org>
    Gerrit-Comment-Date: Tue, 20 Jan 2026 11:42:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 20, 2026, 7:27:33 AM (19 hours ago) Jan 20
    to Nicola Tommasi, Rubber Stamper, Sirisha Kavuluru, Theresa Sullivan, Wenyu Fu, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium Metrics Reviews, feature-me...@chromium.org, twelling...@chromium.org, lizeb+watch...@chromium.org, gangwu...@chromium.org, browser-comp...@chromium.org, sloboda...@chromium.org, donnd...@chromium.org, asvitkine...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Revert "Reland "Add LockTopControlsV2 to field trial testing config""

    This reverts commit 4e729ce482b92aaae108b4959ad47e9fc0636d1b.

    Reason for revert: crbug.com/477169539

    Original change's description:
    > Reland "Add LockTopControlsV2 to field trial testing config"
    >
    > This reverts commit a9cce57494a4fa3c9e0cae5b26a84f8a1dab025d.
    >
    > Reason for revert: Disable LTCv2 on the failed test.
    >
    > Skipping new flaky tests since this CL runs on all CI-only tests.
    > android-15-tablet-landscape-x64-rel test run passes correctly.
    >
    > Original change's description:
    > > Revert "Add LockTopControlsV2 to field trial testing config"
    > >
    > > This reverts commit 6e08c5868e1e14dd13c401a82ee6e288d38a81fd.
    > >
    > > Reason for revert: crbug.com/476375461
    > >
    > > Original change's description:
    > > > Add LockTopControlsV2 to field trial testing config
    > > >
    > > > Test that are not compatible with the feature will have the feature
    > > > temporarily disabled.
    > > >
    > > > Include-Ci-Only-Tests: chromium.android.desktop:android-desktop-x64-rel-15-tests|chrome_public_test_apk
    > > > Bug: 450970998, 473893732
    > > > Change-Id: I248bfa8f94f39010b26b8e22374ba512caf88bff
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7458201
    > > > Reviewed-by: Theresa Sullivan <twell...@chromium.org>
    > > > Reviewed-by: Sirisha Kavuluru <skav...@google.com>
    > > > Commit-Queue: Wenyu Fu <wen...@chromium.org>
    > > > Cr-Commit-Position: refs/heads/main@{#1570159}
    > >
    > > Bug: 450970998, 473893732
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Change-Id: Ia0a9947f631bb1a6b98a555317ed49941449cfca
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7487037
    > > Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
    > > Auto-Submit: Egor Pasko <pa...@chromium.org>
    > > Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    > > Owners-Override: Egor Pasko <pa...@chromium.org>
    > > Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
    > > Cr-Commit-Position: refs/heads/main@{#1570346}
    >
    > Bug: 450970998, 473893732
    > Change-Id: If3109ef810b1734bb293d98ad5ff06fa179d8439
    > Include-Ci-Only-Tests: true
    > Validate-Test-Flakiness: skip
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7489272
    > Commit-Queue: Wenyu Fu <wen...@chromium.org>
    > Reviewed-by: Theresa Sullivan <twell...@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#1570714}
    Bug: 450970998, 473893732
    Change-Id: I863a62398110bc941eed12cc8fa6a8d8205aa2fd
    Owners-Override: Nicola Tommasi <tomm...@chromium.org>
    Commit-Queue: Nicola Tommasi <tomm...@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Auto-Submit: Nicola Tommasi <tomm...@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#1571549}
    Files:
    • M chrome/android/BUILD.gn
    • M chrome/android/features/keyboard_accessory/javatests/src/org/chromium/chrome/browser/keyboard_accessory/AutofillKeyboardAccessoryIntegrationTest.java
    • M chrome/android/features/keyboard_accessory/javatests/src/org/chromium/chrome/browser/keyboard_accessory/PasswordGenerationIntegrationTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/PopupMultiwindowPTTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/ViewTransitionPixelTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/autofill/TouchToFillCreditCardTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/TabReparentingTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/fullscreen/FullscreenManagerTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/AutoplayMutedNotificationTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/FullscreenVideoPictureInPictureControllerTest.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestRule.java
    • M chrome/android/javatests/src/org/chromium/chrome/browser/tab/SadTabTest.java
    • M chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
    • M chrome/browser/ui/android/tabstrip/java/src/org/chromium/chrome/browser/tabstrip/TabStripTopControlLayerUnitTest.java
    • M testing/variations/fieldtrial_testing_config.json
    Change size: M
    Delta: 18 files changed, 10 insertions(+), 106 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I863a62398110bc941eed12cc8fa6a8d8205aa2fd
    Gerrit-Change-Number: 7497154
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement

    Wenyu Fu (Gerrit)

    unread,
    12:19 AM (2 hours ago) 12:19 AM
    to Chromium LUCI CQ, Nicola Tommasi, Rubber Stamper, Sirisha Kavuluru, Theresa Sullivan, AyeAye, chromium...@chromium.org, Peter Beverloo, Chromium Metrics Reviews, feature-me...@chromium.org, twelling...@chromium.org, lizeb+watch...@chromium.org, gangwu...@chromium.org, browser-comp...@chromium.org, sloboda...@chromium.org, donnd...@chromium.org, asvitkine...@chromium.org

    Wenyu Fu has created a revert of this change

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: revert
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages