widevine: Remove `enable_media_foundation_widevine_cdm` GN arg [chromium/src : main]

Xiaohan Wang (Gerrit)

unread,

Jun 16, 2021, 5:59:16 PM6/16/21

to John Rummell, eme-r...@chromium.org, feature-me...@chromium.org, Haoming Chen, Xiaohan Wang

Attention is currently required from: John Rummell.

Xiaohan Wang would like John Rummell to review this change.

widevine: Remove `enable_media_foundation_widevine_cdm` GN arg

Remove this GN arg and check the runtime flag instead of the buildflag
check. This would make it easier to test things in Google Chrome builds.

Bug: 1115687
Test: Tested manually.
Change-Id: I8fba88782d3124fbcb260d7011b352eacf0c8a08
---
M chrome/common/media/cdm_registration.cc
M third_party/widevine/cdm/BUILD.gn
M third_party/widevine/cdm/DEPS
M third_party/widevine/cdm/widevine.gni
M third_party/widevine/cdm/widevine_cdm_common.h
5 files changed, 26 insertions(+), 35 deletions(-)

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

Xiaohan Wang (Gerrit)

unread,

Jun 16, 2021, 5:59:22 PM6/16/21

to Xiaohan Wang, eme-r...@chromium.org, feature-me...@chromium.org, John Rummell, Haoming Chen, chromium...@chromium.org

Attention is currently required from: John Rummell.

Patch set 1:Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  PTAL

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

John Rummell (Gerrit)

unread,

Jun 16, 2021, 6:09:54 PM6/16/21

to Xiaohan Wang, eme-r...@chromium.org, feature-me...@chromium.org, John Rummell, Chromium LUCI CQ, Haoming Chen, chromium...@chromium.org

Attention is currently required from: Xiaohan Wang.

Patch set 1:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  LGTM

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

Xiaohan Wang (Gerrit)

unread,

Jun 16, 2021, 6:11:57 PM6/16/21

to Xiaohan Wang, eme-r...@chromium.org, feature-me...@chromium.org, John Rummell, Chromium LUCI CQ, Haoming Chen, chromium...@chromium.org

Attention is currently required from: Xiaohan Wang.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jun 16, 2021, 6:17:39 PM6/16/21

to Xiaohan Wang, eme-r...@chromium.org, feature-me...@chromium.org, John Rummell, Haoming Chen, chromium...@chromium.org

Failed builds:
  luci.chromium.try/chromium_presubmit JOB_FAILED https://cr-buildbucket.appspot.com/build/8844230525243027216
    #### There are 2 error(s), 0 warning(s), and 0 notifications(s). Here are the errors:
    
    **ERROR**
    ```
    You need LGTM from owners of depends-on paths in DEPS that were modified in this CL:
        '+build/build_config.h',
    
    ```
    
    **ERROR**
    ```
    Suggested missing target path OWNERS:
        aeub...@google.com
    
    ```
  luci.chromium.try/chromium_presubmit JOB_FAILED https://cr-buildbucket.appspot.com/build/8844230339264909152
    #### There are 2 error(s), 0 warning(s), and 0 notifications(s). Here are the errors:
    
    **ERROR**
    ```
    You need LGTM from owners of depends-on paths in DEPS that were modified in this CL:
        '+build/build_config.h',
    
    ```
    
    **ERROR**
    ```
    Suggested missing target path OWNERS:
        ha...@chromium.org
    
    ```

View Change

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

Xiaohan Wang (Gerrit)

unread,

Jun 16, 2021, 8:47:20 PM6/16/21

to Bruce Dawson, eme-r...@chromium.org, feature-me...@chromium.org, Xiaohan Wang, John Rummell

Attention is currently required from: Bruce Dawson.

Xiaohan Wang would like Bruce Dawson to review this change.

View Change

widevine: Remove `enable_media_foundation_widevine_cdm` GN arg

Remove this GN arg and check the runtime flag instead of the buildflag
check. This would make it easier to test things in Google Chrome builds.

Bug: 1115687
Test: Tested manually.
Change-Id: I8fba88782d3124fbcb260d7011b352eacf0c8a08
---
M chrome/common/media/cdm_registration.cc
M third_party/widevine/cdm/BUILD.gn
M third_party/widevine/cdm/DEPS
M third_party/widevine/cdm/widevine.gni
M third_party/widevine/cdm/widevine_cdm_common.h
5 files changed, 26 insertions(+), 35 deletions(-)

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

Xiaohan Wang (Gerrit)

unread,

Jun 16, 2021, 8:47:27 PM6/16/21

to Xiaohan Wang, eme-r...@chromium.org, feature-me...@chromium.org, Bruce Dawson, John Rummell, Chromium LUCI CQ, Haoming Chen, chromium...@chromium.org

Attention is currently required from: Bruce Dawson.

View Change

1 comment:

Patchset:
- Patch Set #1:
  Bruce: Could you please review the addition of "build/" in third_party/widevine/cdm/DEPS? Thanks!

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

Bruce Dawson (Gerrit)

unread,

Jun 16, 2021, 8:53:00 PM6/16/21

to Xiaohan Wang, eme-r...@chromium.org, feature-me...@chromium.org, John Rummell, Chromium LUCI CQ, Haoming Chen, chromium...@chromium.org

Attention is currently required from: Xiaohan Wang.

Patch set 1:Code-Review +1

View Change

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

Xiaohan Wang (Gerrit)

unread,

Jun 16, 2021, 9:00:52 PM6/16/21

to Xiaohan Wang, eme-r...@chromium.org, feature-me...@chromium.org, Bruce Dawson, John Rummell, Chromium LUCI CQ, Haoming Chen, chromium...@chromium.org

Attention is currently required from: Xiaohan Wang.

Patch set 1:Commit-Queue +2

View Change

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jun 16, 2021, 9:05:00 PM6/16/21

to Xiaohan Wang, eme-r...@chromium.org, feature-me...@chromium.org, Bruce Dawson, John Rummell, Haoming Chen, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  John Rummell: Looks good to me
  Bruce Dawson: Looks good to me
  Xiaohan Wang: Commit

widevine: Remove `enable_media_foundation_widevine_cdm` GN arg

Remove this GN arg and check the runtime flag instead of the buildflag
check. This would make it easier to test things in Google Chrome builds.

Bug: 1115687
Test: Tested manually.
Change-Id: I8fba88782d3124fbcb260d7011b352eacf0c8a08

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2967052
Reviewed-by: John Rummell <jrum...@chromium.org>
Reviewed-by: Bruce Dawson <bruce...@chromium.org>
Commit-Queue: Xiaohan Wang <xhw...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#893258}


---
M chrome/common/media/cdm_registration.cc
M third_party/widevine/cdm/BUILD.gn
M third_party/widevine/cdm/DEPS
M third_party/widevine/cdm/widevine.gni
M third_party/widevine/cdm/widevine_cdm_common.h
5 files changed, 26 insertions(+), 35 deletions(-)

To view, visit change 2967052. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward