Add new metrics for explain gemini edit menu entry point [chromium/src : main]

0 views
Skip to first unread message

Yasaman Sedaghat (Gerrit)

unread,
Mar 4, 2026, 4:33:51 PM (22 hours ago) Mar 4
to Adam Arcaro, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, christia...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro

Yasaman Sedaghat voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Adam Arcaro
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I83f40ff65db2df28ef793e8e45a1239408b90b15
Gerrit-Change-Number: 7615069
Gerrit-PatchSet: 5
Gerrit-Owner: Yasaman Sedaghat <yasa...@google.com>
Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
Gerrit-Reviewer: Yasaman Sedaghat <yasa...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Adam Arcaro <ada...@google.com>
Gerrit-Comment-Date: Wed, 04 Mar 2026 21:33:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Adam Arcaro (Gerrit)

unread,
Mar 4, 2026, 7:33:41 PM (19 hours ago) Mar 4
to Yasaman Sedaghat, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, christia...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Yasaman Sedaghat

Adam Arcaro added 5 comments

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Adam Arcaro . resolved

Thanks! Please see some comments

Commit Message
Line 15, Patchset 5 (Latest):Big: 485297569
Adam Arcaro . unresolved

Bug

File ios/chrome/browser/intelligence/bwg/metrics/gemini_metrics.mm
Line 79, Patchset 5 (Latest): "IOS.Gemini.EntryPoint.Impression";
Adam Arcaro . unresolved

You'll need a new entry in `histograms.xml` for this too

Line 297, Patchset 5 (Latest): base::UserMetricsAction("MobileGeminiEntryPointImpression "));
Adam Arcaro . unresolved

Please remove the empty space

Line 298, Patchset 5 (Latest): base::UmaHistogramEnumeration(kEntryPointImpressionHistogram, entry_point);
Adam Arcaro . unresolved

What are you trying to achieve with this histogram? This will get logged for each omnibox impression which might not provide much value

Open in Gerrit

Related details

Attention is currently required from:
  • Yasaman Sedaghat
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I83f40ff65db2df28ef793e8e45a1239408b90b15
    Gerrit-Change-Number: 7615069
    Gerrit-PatchSet: 5
    Gerrit-Owner: Yasaman Sedaghat <yasa...@google.com>
    Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
    Gerrit-Reviewer: Yasaman Sedaghat <yasa...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Yasaman Sedaghat <yasa...@google.com>
    Gerrit-Comment-Date: Thu, 05 Mar 2026 00:33:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yasaman Sedaghat (Gerrit)

    unread,
    11:08 AM (3 hours ago) 11:08 AM
    to Adam Arcaro, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, christia...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Adam Arcaro

    Yasaman Sedaghat added 4 comments

    Commit Message
    Line 15, Patchset 5:Big: 485297569
    Adam Arcaro . resolved

    Bug

    Yasaman Sedaghat

    Done

    File ios/chrome/browser/intelligence/bwg/metrics/gemini_metrics.mm
    Line 79, Patchset 5: "IOS.Gemini.EntryPoint.Impression";
    Adam Arcaro . resolved

    You'll need a new entry in `histograms.xml` for this too

    Yasaman Sedaghat

    Done

    Line 297, Patchset 5: base::UserMetricsAction("MobileGeminiEntryPointImpression "));
    Adam Arcaro . resolved

    Please remove the empty space

    Yasaman Sedaghat

    Done

    Line 298, Patchset 5: base::UmaHistogramEnumeration(kEntryPointImpressionHistogram, entry_point);
    Adam Arcaro . unresolved

    What are you trying to achieve with this histogram? This will get logged for each omnibox impression which might not provide much value

    Yasaman Sedaghat

    This is the reason, basically needed for explain with gemini: https://screenshot.googleplex.com/4qSfmdhqGBaxWsd

    I haven't yet figured out where to record it for explain with gemini to make sure it's only logged when the entry point is shown. If you are concerned about extra logging for omnibox (why though? space is a concern?) I can add a new method just for explain with gemini. Thought it would be useful as we add more entry points that might not be visible on all tabs.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Arcaro
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I83f40ff65db2df28ef793e8e45a1239408b90b15
    Gerrit-Change-Number: 7615069
    Gerrit-PatchSet: 7
    Gerrit-Owner: Yasaman Sedaghat <yasa...@google.com>
    Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
    Gerrit-Reviewer: Yasaman Sedaghat <yasa...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Adam Arcaro <ada...@google.com>
    Gerrit-Comment-Date: Thu, 05 Mar 2026 16:08:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Adam Arcaro <ada...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gauthier Ambard (Gerrit)

    unread,
    12:21 PM (2 hours ago) 12:21 PM
    to Yasaman Sedaghat, Sebastien S-G, Adam Arcaro, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, christia...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Adam Arcaro, Sebastien S-G and Yasaman Sedaghat

    Gauthier Ambard voted and added 1 comment

    Votes added by Gauthier Ambard

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 9 (Latest):
    Gauthier Ambard . resolved

    code lgtm, but please wait for Adam review

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Adam Arcaro
    • Sebastien S-G
    • Yasaman Sedaghat
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I83f40ff65db2df28ef793e8e45a1239408b90b15
      Gerrit-Change-Number: 7615069
      Gerrit-PatchSet: 9
      Gerrit-Owner: Yasaman Sedaghat <yasa...@google.com>
      Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
      Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
      Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
      Gerrit-Reviewer: Yasaman Sedaghat <yasa...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Yasaman Sedaghat <yasa...@google.com>
      Gerrit-Attention: Adam Arcaro <ada...@google.com>
      Gerrit-Attention: Sebastien S-G <se...@chromium.org>
      Gerrit-Comment-Date: Thu, 05 Mar 2026 17:21:22 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Adam Arcaro (Gerrit)

      unread,
      2:13 PM (2 minutes ago) 2:13 PM
      to Yasaman Sedaghat, Gauthier Ambard, Sebastien S-G, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, christia...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Sebastien S-G and Yasaman Sedaghat

      Adam Arcaro voted and added 2 comments

      Votes added by Adam Arcaro

      Code-Review+1

      2 comments

      Patchset-level comments
      Adam Arcaro . resolved

      Lgtm thanks!

      File ios/chrome/browser/intelligence/bwg/metrics/gemini_metrics.mm
      Line 298, Patchset 5: base::UmaHistogramEnumeration(kEntryPointImpressionHistogram, entry_point);
      Adam Arcaro . resolved

      What are you trying to achieve with this histogram? This will get logged for each omnibox impression which might not provide much value

      Yasaman Sedaghat

      This is the reason, basically needed for explain with gemini: https://screenshot.googleplex.com/4qSfmdhqGBaxWsd

      I haven't yet figured out where to record it for explain with gemini to make sure it's only logged when the entry point is shown. If you are concerned about extra logging for omnibox (why though? space is a concern?) I can add a new method just for explain with gemini. Thought it would be useful as we add more entry points that might not be visible on all tabs.

      Adam Arcaro

      Acknowledged

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sebastien S-G
      • Yasaman Sedaghat
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I83f40ff65db2df28ef793e8e45a1239408b90b15
        Gerrit-Change-Number: 7615069
        Gerrit-PatchSet: 9
        Gerrit-Owner: Yasaman Sedaghat <yasa...@google.com>
        Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
        Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
        Gerrit-Reviewer: Sebastien S-G <se...@chromium.org>
        Gerrit-Reviewer: Yasaman Sedaghat <yasa...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Attention: Yasaman Sedaghat <yasa...@google.com>
        Gerrit-Attention: Sebastien S-G <se...@chromium.org>
        Gerrit-Comment-Date: Thu, 05 Mar 2026 19:13:15 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Yasaman Sedaghat <yasa...@google.com>
        Comment-In-Reply-To: Adam Arcaro <ada...@google.com>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages