Cleanup now unused flag RequestType::kHitNodeCbWithId [chromium/src : main]

0 views
Skip to first unread message

Philip Rogers (Gerrit)

unread,
Feb 10, 2026, 7:38:03 PM (2 days ago) Feb 10
to Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, zol...@webkit.org
Attention needed from Aaron Leventhal

Philip Rogers voted and added 1 comment

Votes added by Philip Rogers

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Philip Rogers . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Aaron Leventhal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56591e2d047a9c0276c29706886026eb8e228b8e
Gerrit-Change-Number: 7563350
Gerrit-PatchSet: 3
Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Aaron Leventhal <aleve...@google.com>
Gerrit-Comment-Date: Wed, 11 Feb 2026 00:37:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Aaron Leventhal (Gerrit)

unread,
Feb 11, 2026, 8:06:13 PM (11 hours ago) Feb 11
to Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, zol...@webkit.org

Aaron Leventhal voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56591e2d047a9c0276c29706886026eb8e228b8e
Gerrit-Change-Number: 7563350
Gerrit-PatchSet: 3
Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 01:06:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 11, 2026, 9:43:21 PM (9 hours ago) Feb 11
to Aaron Leventhal, Philip Rogers, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Cleanup now unused flag RequestType::kHitNodeCbWithId

Now that APC no longer uses kHitNodeCbWithId, we can remove it, as it
was the last consumer.
Bug: none
Change-Id: I56591e2d047a9c0276c29706886026eb8e228b8e
Commit-Queue: Aaron Leventhal <aleve...@google.com>
Reviewed-by: Philip Rogers <p...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1583687}
Files:
  • M third_party/blink/renderer/core/html/media/media_video_visibility_tracker.cc
  • M third_party/blink/renderer/core/html/media/media_video_visibility_tracker.h
  • M third_party/blink/renderer/core/layout/hit_test_request.cc
  • M third_party/blink/renderer/core/layout/hit_test_request.h
  • M third_party/blink/renderer/core/layout/hit_testing_test.cc
Change size: S
Delta: 5 files changed, 11 insertions(+), 22 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Philip Rogers
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56591e2d047a9c0276c29706886026eb8e228b8e
Gerrit-Change-Number: 7563350
Gerrit-PatchSet: 4
Gerrit-Owner: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Aaron Leventhal <aleve...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages