[iOS] Add file picker to file upload panel [chromium/src : main]

0 views

Skip to first unread message

Quentin Pubert (Gerrit)

unread,

9:25 AM (9 hours ago) 9:25 AM

to Olivier Robin, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Olivier Robin

Quentin Pubert voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Olivier Robin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Olivier Robin (Gerrit)

unread,

12:33 PM (6 hours ago) 12:33 PM

to Quentin Pubert, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Quentin Pubert

Olivier Robin voted and added 6 comments

Votes added by Olivier Robin

Code-Review

6 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Olivier Robin . resolved

can you test in safari and this code selecting directory with a lot of files, or very big files?

File ios/chrome/app/strings/ios_strings.grd

Line 2705, Patchset 7 (Latest): Choose Files

Olivier Robin . unresolved

optional: you can use grit plural syntax to keep only one message. something like
```
      <message name="IDS_IOS_FILE_UPLOAD_PANEL_CHOOSE_FILE_ACTION_LABEL" desc="Title for a single file chooser button used in HTML forms. [iOS only]">
 {count, plural,
   =1 {{Choose File}}
   other {{Choose Files}}}
      </message>
 ```

File ios/chrome/browser/file_upload_panel/coordinator/file_upload_panel_mediator.mm

Line 208, Patchset 7 (Latest): if (self.allowsDirectorySelection) {

Olivier Robin . unresolved

can you have directory and other types?

File ios/chrome/browser/file_upload_panel/coordinator/file_upload_panel_mediator_unittest.mm

Line 350, Patchset 7 (Latest): EXPECT_TRUE(mediator.allowsMultipleSelection);

Olivier Robin . unresolved

should you check allowsMultipleSelection, acceptedDocumentTypes and allowsDirectorySelection on all those tests?

File ios/chrome/browser/file_upload_panel/test/file_upload_panel_egtest.mm

Line 669, Patchset 7 (Latest): [serviceApp.cells[@"On My iPhone"] waitForExistenceWithTimeout:10],

Olivier Robin . unresolved

does this work on iPad?

File tools/metrics/histograms/metadata/ios/histograms.xml

Line 1994, Patchset 7 (Latest): Report whether the user finished picking from the file picker or instead did

Olivier Robin . unresolved

Here and others: add more context (when choosing a file to upload...)

Open in Gerrit

Related details

Attention is currently required from:

Quentin Pubert

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages