Add email indication sentence to Pix account linking prompts [chromium/src : main]

0 views
Skip to first unread message

Longsheng Yin (Gerrit)

unread,
Aug 2, 2026, 4:59:40 PM (3 days ago) Aug 2
to Jerome Jiang, Chromium LUCI CQ, Mirko Bonadei, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, chrome-intell...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, mar...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, grt+...@chromium.org, net-r...@chromium.org, feature-me...@chromium.org, fgal...@chromium.org, jz...@chromium.org, cblume...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, droger+w...@chromium.org
Attention needed from Longsheng Yin

Longsheng Yin removed Jerome Jiang from this change

Deleted Reviewers:
  • Jerome Jiang
Open in Gerrit

Related details

Attention is currently required from:
  • Longsheng Yin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib042c76d459ffb7adb923214f7738ee96772f069
Gerrit-Change-Number: 8180871
Gerrit-PatchSet: 12
Gerrit-Owner: Longsheng Yin <long...@google.com>
Gerrit-Reviewer: Longsheng Yin <long...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-Attention: Longsheng Yin <long...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Longsheng Yin (Gerrit)

unread,
Aug 2, 2026, 4:59:44 PM (3 days ago) Aug 2
to Mirko Bonadei, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, chrome-intell...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, mar...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, grt+...@chromium.org, net-r...@chromium.org, feature-me...@chromium.org, fgal...@chromium.org, jz...@chromium.org, cblume...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, droger+w...@chromium.org
Attention needed from Longsheng Yin

Longsheng Yin removed Mirko Bonadei from this change

Deleted Reviewers:
  • Mirko Bonadei
Open in Gerrit

Related details

Attention is currently required from:
  • Longsheng Yin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteReviewer
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib042c76d459ffb7adb923214f7738ee96772f069
Gerrit-Change-Number: 8180871
Gerrit-PatchSet: 12
Gerrit-Owner: Longsheng Yin <long...@google.com>
Gerrit-Reviewer: Longsheng Yin <long...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Siddharth Shah (Gerrit)

unread,
12:08 AM (7 hours ago) 12:08 AM
to Longsheng Yin, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, chrome-intell...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, mar...@chromium.org, nickdiego+wa...@igalia.com, max+watc...@igalia.com, grt+...@chromium.org, net-r...@chromium.org, feature-me...@chromium.org, fgal...@chromium.org, jz...@chromium.org, cblume...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, droger+w...@chromium.org
Attention needed from Longsheng Yin

Siddharth Shah voted and added 2 comments

Votes added by Siddharth Shah

Code-Review+1

2 comments

File chrome/browser/facilitated_payments/ui/android/internal/java/src/org/chromium/chrome/browser/facilitated_payments/PixAccountLinkingPrompt.java
Line 125, Patchset 18 (Latest): !TextUtils.isEmpty(email)
Siddharth Shah . unresolved

This should never happen. Instead of showing alternative text, we should assert on email not being empty.

File components/facilitated_payments_strings.grdp
Line 168, Patchset 18 (Latest): <message name="IDS_PIX_ACCOUNT_LINKING_PROMPT_SETTINGS_LINK" desc="Text for the settings link in the bottom sheet showing Pix account linking prompt." formatter_data="android_java">
Siddharth Shah . unresolved

Can this be removed?

Open in Gerrit

Related details

Attention is currently required from:
  • Longsheng Yin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib042c76d459ffb7adb923214f7738ee96772f069
Gerrit-Change-Number: 8180871
Gerrit-PatchSet: 18
Gerrit-Owner: Longsheng Yin <long...@google.com>
Gerrit-Reviewer: Longsheng Yin <long...@google.com>
Gerrit-Reviewer: Siddharth Shah <sia...@google.com>
Gerrit-Comment-Date: Wed, 05 Aug 2026 04:08:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages