[Media Indicator] Add test for RECORDING [chromium/src : main]
0 views
Skip to first unread message
Dan Polanco (Gerrit)
Dec 5, 2025, 3:24:29 PM (2 days ago) Dec 5
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Calder Kitagawa
Dan Polanco added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabMediaIndicatorTest.java
Line 201, Patchset 2 (Latest):
IUi2Locator allowButton = Ui2Locators.withText("Allow this time");
UiAutomatorUtils.getInstance().click(allowButton);Dan Polanco . resolved
Not a big fan of this, but I will give it a try.
The other flags that "auto accept" permissions use a Fake class which does not communicate with MediaStreamCaptureIndicator (class needed for getting the media signals).
Related details
Attention is currently required from:
- Calder Kitagawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Calder Kitagawa (Gerrit)
Dec 5, 2025, 3:26:48 PM (2 days ago) Dec 5
to Dan Polanco, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dan Polanco
Calder Kitagawa added 1 comment![]( "Open in Gerrit")
File chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabMediaIndicatorTest.java
Line 201, Patchset 2 (Latest):
IUi2Locator allowButton = Ui2Locators.withText("Allow this time");
UiAutomatorUtils.getInstance().click(allowButton);Dan Polanco . unresolved
Not a big fan of this, but I will give it a try.
The other flags that "auto accept" permissions use a Fake class which does not communicate with MediaStreamCaptureIndicator (class needed for getting the media signals).
Calder Kitagawa
Can you use Espresso for this instead?
`onViewWaiting(withText("Allow this time")).perform(click());`
Related details
Attention is currently required from:
- Dan Polanco
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dan Polanco (Gerrit)
Dec 5, 2025, 4:50:11 PM (2 days ago) Dec 5
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Calder Kitagawa
Dan Polanco added 1 comment![]( "Open in Gerrit")
File chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabMediaIndicatorTest.java
Line 201, Patchset 2:
IUi2Locator allowButton = Ui2Locators.withText("Allow this time");
UiAutomatorUtils.getInstance().click(allowButton);Dan Polanco . resolved
Calder KitagawaNot a big fan of this, but I will give it a try.
The other flags that "auto accept" permissions use a Fake class which does not communicate with MediaStreamCaptureIndicator (class needed for getting the media signals).
Can you use Espresso for this instead?
`onViewWaiting(withText("Allow this time")).perform(click());`
Attention is currently required from:
- Calder Kitagawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Calder Kitagawa (Gerrit)
Dec 5, 2025, 4:58:08 PM (2 days ago) Dec 5
to Dan Polanco, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Attention needed from Dan Polanco
Calder Kitagawa voted and added 1 comment![]( "Open in Gerrit")
Votes added by Calder Kitagawa
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dan Polanco
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dan Polanco (Gerrit)
Dec 5, 2025, 4:59:29 PM (2 days ago) Dec 5
to Calder Kitagawa, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org
Dan Polanco voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 5, 2025, 6:25:05 PM (2 days ago) Dec 5
to Dan Polanco, Calder Kitagawa, chromium...@chromium.org, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Media Indicator] Add test for RECORDING
Bug: 454045510
Change-Id: I36ff55f1447a5d6b181a65685a895ceff06c65ba
Commit-Queue: Dan Polanco <pol...@google.com>
Reviewed-by: Calder Kitagawa <ckit...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1554963}
Files:
- M chrome/android/javatests/src/org/chromium/chrome/browser/tab/TabMediaIndicatorTest.java
- M chrome/test/data/media/tab_media_indicator.html
Change size: M
Delta: 2 files changed, 91 insertions(+), 14 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Calder Kitagawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages