Revert "[m143] media: Fix non-standard url parameter in provisioning" [chromium/src : refs/branch-heads/7499]
0 views
Skip to first unread message
Rubber Stamper (Gerrit)
Nov 12, 2025, 7:32:14 PM (10 hours ago) Nov 12
to Vikram Pasupathy, AyeAye, Chromium LUCI CQ, Vikram Pasupathy, feature-me...@chromium.org
Attention needed from Feras Aldahlawi, Vikram Pasupathy and Xiaohan Wang
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Feras Aldahlawi
- Vikram Pasupathy
- Xiaohan Wang
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaohan Wang (Gerrit)
Nov 12, 2025, 7:39:29 PM (10 hours ago) Nov 12
to Vikram Pasupathy, Rubber Stamper, AyeAye, Chromium LUCI CQ, Vikram Pasupathy, feature-me...@chromium.org
Attention needed from Feras Aldahlawi, Vikram Pasupathy and Vikram Pasupathy
Xiaohan Wang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Xiaohan Wang
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Feras Aldahlawi
- Vikram Pasupathy
- Vikram Pasupathy
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vikram Pasupathy (Gerrit)
Nov 12, 2025, 7:40:54 PM (10 hours ago) Nov 12
to Rubber Stamper, AyeAye, Chromium LUCI CQ, Vikram Pasupathy, feature-me...@chromium.org
Attention needed from Feras Aldahlawi and Vikram Pasupathy
Vikram Pasupathy voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Feras Aldahlawi
- Vikram Pasupathy
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 12, 2025, 9:29:52 PM (8 hours ago) Nov 12
to Vikram Pasupathy, Rubber Stamper, AyeAye, Vikram Pasupathy, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[m143] media: Fix non-standard url parameter in provisioning"
Reason for revert: This modifies the non finch gated feature. Although
this is correct, this is causing issues. Revert and investigate with
the internal team.
Original change's description:
> [m143] media: Fix non-standard url parameter in provisioning
>
> Cherry-pick to M143.
>
> The url parameter was added via an ampersand, when the start of
> parameters should actually include a question mark. This worked because
> of lenient parsing, but should be fixed to match the standard, as the
> question mark is recognized as the start of the query string by all
> servers.
>
> Tested manually with flag enabled to verify it worked.
>
> Media.EME.MediaDrm.Provisioning returns success each time.
> Media.EME.UrlProvisionFetcher.ResponseCode returns 200 each time.
>
> (cherry picked from commit bf3874fe28522965231961d42ce7591df15ed20c)
>
> Bug: 456186326, 456250902
> Change-Id: I21cc325a03d30328cc6b00bb03508e4c18977877
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7097220
> Reviewed-by: Xiaohan Wang <xhw...@chromium.org>
> Commit-Queue: Vikram Pasupathy <vpasu...@chromium.org>
> Cr-Original-Commit-Position: refs/heads/main@{#1537542}
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7102678
> Reviewed-by: Feras Aldahlawi <f...@chromium.org>
> Cr-Commit-Position: refs/branch-heads/7499@{#527}
> Cr-Branched-From: b30439823e5177773584139e72e0593e36863899-refs/heads/main@{#1536371}
Bug: 456186326, 456250902
Change-Id: I639b0ac8da2f1364f01a10567d505d08a76e5781
Reviewed-by: Xiaohan Wang <xhw...@chromium.org>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Vikram Pasupathy <vpasu...@google.com>
Cr-Commit-Position: refs/branch-heads/7499@{#1551}
Cr-Branched-From: b30439823e5177773584139e72e0593e36863899-refs/heads/main@{#1536371}
Files:
- M content/browser/media/url_provision_fetcher.cc
- M content/browser/media/url_provision_fetcher_unittest.cc
Change size: XS
Delta: 2 files changed, 2 insertions(+), 2 deletions(-)
Branch: refs/branch-heads/7499
Submit Requirements:
Code-Review: +1 by Xiaohan Wang, Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages