Revert "spanification: spanify Vp9Parser." [chromium/src : main]
Rubber Stamper (Gerrit)
Rubber Stamper voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
- Weidong Liu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
Message from Rubber Stamper![]( "Open in Gerrit")
Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.
Related details
- Weidong Liu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Thomas Guilbert voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Guilbert
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
There might have been a small functional change in the original CL on [this line](https://chromium-review.googlesource.com/c/chromium/src/+/7281025/6/media/parsers/vp9_parser.cc#569)
Previously, a `stream_ != nullptr` and `bytes_left_ == 0`, `ParseNextFrame()` results in `kInvalidStream`. After the spanification change, `ParseNextFrame()` would result in `kEOStream`.
This small change might be the reason why some tests are now failing.
Related details
- Eugene Zemtsov
- Thomas Guilbert
- Weidong Liu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Eugene Zemtsov voted![]( "Open in Gerrit")
- Thomas Guilbert
- Weidong Liu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eugene Zemtsov (Gerrit)
Eugene Zemtsov voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +2 |
Related details
- Thomas Guilbert
- Weidong Liu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Revert "spanification: spanify Vp9Parser."
This reverts commit 0264452711f099c5deb7e02321ce8c47ee98f6f0.
Reason for revert: Causes test failures due to differences in VP9 checksums --> see crbug.com/475663374
Original change's description:
> spanification: spanify Vp9Parser.
>
> Bug: 40284755
> Change-Id: I62c8367093d928f3a999543aabf9af4a72d8efa7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7281025
> Reviewed-by: Thomas Guilbert <tgui...@chromium.org>
> Commit-Queue: Weidong Liu <weido...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1565390}
- M media/gpu/chromeos/decoder_buffer_transcryptor.cc
- M media/gpu/mac/video_toolbox_vp9_accelerator_unittest.cc
- M media/gpu/v4l2/test/vp9_decoder.cc
- M media/gpu/vaapi/test/vp9_decoder.cc
- M media/gpu/vaapi/vp9_vaapi_video_decoder_delegate.cc
- M media/parsers/vp9_parser.cc
- M media/parsers/vp9_parser.h
- M media/parsers/vp9_parser_unittest.cc
- M media/parsers/vp9_raw_bits_reader.cc
- M media/parsers/vp9_raw_bits_reader.h
- M media/parsers/vp9_raw_bits_reader_unittest.cc
- M media/parsers/vp9_uncompressed_header_parser.cc
- M media/parsers/vp9_uncompressed_header_parser.h
Code-Review: +1 by Eugene Zemtsov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Weidong Liu (Gerrit)
Weidong Liu added 1 comment![]( "Open in Gerrit")
I do not have permission to view this issue. Please CC me.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Thomas Guilbert added 1 comment![]( "Open in Gerrit")
I do not have permission to view this issue. Please CC me.
The bug was created in the internal tracker and requires an @google.com account.
The team that surfaced the issue will take a look, as it's chromeos only. If they don't find a solution, I can copy the relevant bits to a public bug, and continue the investigation from there.
Sorry for the churn, this revert was needed to get the tests passing again.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Weidong Liu (Gerrit)
Weidong Liu added 1 comment![]( "Open in Gerrit")
Thomas GuilbertI do not have permission to view this issue. Please CC me.
The bug was created in the internal tracker and requires an @google.com account.
The team that surfaced the issue will take a look, as it's chromeos only. If they don't find a solution, I can copy the relevant bits to a public bug, and continue the investigation from there.
Sorry for the churn, this revert was needed to get the tests passing again.
Thank you for sharing this information with me. When should I trigger Reland?
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hirokazu Honda (Gerrit)
Hirokazu Honda added 1 comment![]( "Open in Gerrit")
Thomas GuilbertI do not have permission to view this issue. Please CC me.
Weidong LiuThe bug was created in the internal tracker and requires an @google.com account.
The team that surfaced the issue will take a look, as it's chromeos only. If they don't find a solution, I can copy the relevant bits to a public bug, and continue the investigation from there.
Sorry for the churn, this revert was needed to get the tests passing again.
Thank you for sharing this information with me. When should I trigger Reland?
Hi Widong, I will investigate the failure on my side. I hope I can reland the original change with a fix next week or so.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Weidong Liu (Gerrit)
Weidong Liu added 1 comment![]( "Open in Gerrit")
Thomas GuilbertI do not have permission to view this issue. Please CC me.
Weidong LiuThe bug was created in the internal tracker and requires an @google.com account.
The team that surfaced the issue will take a look, as it's chromeos only. If they don't find a solution, I can copy the relevant bits to a public bug, and continue the investigation from there.
Sorry for the churn, this revert was needed to get the tests passing again.
Hirokazu HondaThank you for sharing this information with me. When should I trigger Reland?
Weidong LiuHi Widong, I will investigate the failure on my side. I hope I can reland the original change with a fix next week or so.
Thank you for your reply. Please let me know when it's possible to reland. Thank you very much.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |