Revert "Reland "Reland "Remove callback_helpers.h include from is_callback.h""" [chromium/src : main]

0 views

Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,

Dec 6, 2025, 3:08:15 AM (22 hours ago) Dec 6

to Lei Zhang, Chromium LUCI CQ, Daniel Cheng, AyeAye, chromium...@chromium.org, dmurph+watching...@chromium.org, storage...@chromium.org, halliwe...@chromium.org, feature-me...@chromium.org, cc-...@chromium.org, dmurph+watch...@chromium.org, edgesto...@microsoft.com

Attention needed from Daniel Cheng and Lei Zhang

luci-bi...@appspot.gserviceaccount.com voted

LUCI Bisection is automatically submitting this revert.

Bot-Commit	+1
Commit-Queue	+2
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Dec 6, 2025, 3:08:54 AM (22 hours ago) Dec 6

to luci-bi...@appspot.gserviceaccount.com, Lei Zhang, Daniel Cheng, AyeAye, chromium...@chromium.org, dmurph+watching...@chromium.org, storage...@chromium.org, halliwe...@chromium.org, feature-me...@chromium.org, cc-...@chromium.org, dmurph+watch...@chromium.org, edgesto...@microsoft.com

Chromium LUCI CQ submitted the change

Change information

Commit message:

Revert "Reland "Reland "Remove callback_helpers.h include from is_callback.h"""

This reverts commit 66b0b0da0a649ea029445eee27cfc4ca0986fcde.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8696252169057667761

Sample failed build: https://ci.chromium.org/b/8696252169057667761

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7234714&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8696252169057667761&type=BUG

Original change's description:
> Reland "Reland "Remove callback_helpers.h include from is_callback.h""
>
> This is a reland of commit 9bd2be2d8d0c435542afc2e59f128b8e9ef23496
>
> Added missing include to fix collision with crrev.com/1554986.
>
> Original change's description:
> > Reland "Remove callback_helpers.h include from is_callback.h"
> >
> > This is a reland of commit fab09e07f02d2033bd32ea32758d0f41e8312f51
> >
> > Added more missing includes to fix the Linux CFM bot.
> >
> > Original change's description:
> > > Remove callback_helpers.h include from is_callback.h
> > >
> > > This temporary include existed to help safely land the CL that added
> > > is_callback.h. Now that is_callback.h is in the code base, remove this
> > > crutch.
> > >
> > > Change-Id: I2b457b73e799ee7226c5476cdcc9c48d9c8c3e3d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7224760
> > > Commit-Queue: Daniel Cheng <dch...@chromium.org>
> > > Commit-Queue: Lei Zhang <the...@chromium.org>
> > > Owners-Override: Daniel Cheng <dch...@chromium.org>
> > > Reviewed-by: Daniel Cheng <dch...@chromium.org>
> > > Cr-Commit-Position: refs/heads/main@{#1554466}
> >
> > Change-Id: Ib117b0e6f46c5593b677fbca15d242c9c5e1cadf
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7230701
> > Owners-Override: Daniel Cheng <dch...@chromium.org>
> > Reviewed-by: Daniel Cheng <dch...@chromium.org>
> > Commit-Queue: Lei Zhang <the...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1554999}
>
> Change-Id: Ief251126335eedb9209edcb4b80dd2c504226374
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7234714
> Owners-Override: Daniel Cheng <dch...@chromium.org>
> Reviewed-by: Daniel Cheng <dch...@chromium.org>
> Commit-Queue: Daniel Cheng <dch...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1555060}
>

No-Presubmit: true

No-Tree-Checks: true

No-Try: true

Change-Id: I4b85ca36c4bb87d0c8a6cdd7dcebc63c5b5ebaa4

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7235011

Commit-Queue: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Owners-Override: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Bot-Commit: luci-bi...@appspot.gserviceaccount.com <luci-bi...@appspot.gserviceaccount.com>

Cr-Commit-Position: refs/heads/main@{#1555079}

Files:

M base/functional/is_callback.h
M chrome/browser/ash/chromebox_for_meetings/artemis/local_data_source_unittest.cc
M chrome/browser/ash/chromebox_for_meetings/artemis/log_source_unittest.cc
M chrome/browser/ash/chromebox_for_meetings/artemis/test_data_aggregator_service.cc
M chromecast/cast_core/runtime/browser/message_port_handler.cc
M chromecast/media/audio/cast_audio_manager_android.cc
M components/breadcrumbs/core/application_breadcrumbs_logger_unittest.cc
M components/services/storage/dom_storage/session_storage_namespace_impl.cc
M components/viz/service/transitions/transferable_resource_tracker_unittest.cc

Change size: S

Delta: 9 files changed, 4 insertions(+), 9 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: Bot-Commit+1 by luci-bi...@appspot.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages