[context-input] Add CHECK for enterprise policy checking [chromium/src : refs/branch-heads/7559]

0 views
Skip to first unread message

Justin Donnelly (Gerrit)

unread,
Dec 23, 2025, 7:09:10 PM (4 days ago) Dec 23
to Justin Donnelly, Jason Hu, AyeAye, Sophie Chang, ios-r...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, stanfie...@google.com, marq+...@chromium.org, niharm...@google.com, mercer...@google.com, lens-chrome...@google.com, omnibox-...@chromium.org
Attention needed from Justin Donnelly

Justin Donnelly voted Owners-Override+1

Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Justin Donnelly
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedLint
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7559
Gerrit-Change-Id: I90d6dba87914ca08790649d44d150177e2cb9660
Gerrit-Change-Number: 7313012
Gerrit-PatchSet: 1
Gerrit-Owner: Justin Donnelly <jdon...@chromium.org>
Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
Gerrit-CC: Jason Hu <huja...@google.com>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Justin Donnelly <jdon...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Dec 2025 00:09:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Donnelly (Gerrit)

unread,
Dec 23, 2025, 7:09:45 PM (4 days ago) Dec 23
to Justin Donnelly, Jason Hu, Rubber Stamper, Chromium LUCI CQ, AyeAye, Sophie Chang, ios-r...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, stanfie...@google.com, marq+...@chromium.org, niharm...@google.com, mercer...@google.com, lens-chrome...@google.com, omnibox-...@chromium.org

Justin Donnelly voted

Commit-Queue+1
Owners-Override+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedLint
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7559
    Gerrit-Change-Id: I90d6dba87914ca08790649d44d150177e2cb9660
    Gerrit-Change-Number: 7313012
    Gerrit-PatchSet: 2
    Gerrit-Owner: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-CC: Jason Hu <huja...@google.com>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Dec 2025 00:09:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rubber Stamper (Gerrit)

    unread,
    Dec 23, 2025, 7:10:19 PM (4 days ago) Dec 23
    to Justin Donnelly, Jason Hu, Chromium LUCI CQ, AyeAye, Sophie Chang, ios-r...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, stanfie...@google.com, marq+...@chromium.org, niharm...@google.com, mercer...@google.com, lens-chrome...@google.com, omnibox-...@chromium.org

    Rubber Stamper voted Bot-Commit+1

    Bot-Commit+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedLint
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7559
    Gerrit-Change-Id: I90d6dba87914ca08790649d44d150177e2cb9660
    Gerrit-Change-Number: 7313012
    Gerrit-PatchSet: 2
    Gerrit-Owner: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-CC: Jason Hu <huja...@google.com>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Dec 2025 00:10:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Justin Donnelly (Gerrit)

    unread,
    Dec 23, 2025, 7:11:07 PM (4 days ago) Dec 23
    to Justin Donnelly, Jason Hu, Rubber Stamper, Chromium LUCI CQ, AyeAye, Sophie Chang, ios-r...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, stanfie...@google.com, marq+...@chromium.org, niharm...@google.com, mercer...@google.com, lens-chrome...@google.com, omnibox-...@chromium.org

    Justin Donnelly voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Wed, 24 Dec 2025 00:10:56 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 23, 2025, 9:30:12 PM (4 days ago) Dec 23
    to Justin Donnelly, Jason Hu, Rubber Stamper, AyeAye, Sophie Chang, ios-r...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, stanfie...@google.com, marq+...@chromium.org, niharm...@google.com, mercer...@google.com, lens-chrome...@google.com, omnibox-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [context-input] Add CHECK for enterprise policy checking

    Adds a method to the session handle that checks for the enterprise
    policy. If this method is not called before context is uploaded, this
    will trigger a crash.

    Also adds calls to this new method wherever SessionHandles are created.

    Tested locally with omnibox popup flow, ntp flow, and manual navigation
    to contextual-tasks, and issuing context uploads, without crashes.

    No changes are need on Android because the query controller bridge is
    used, bypassing the session handle.

    (cherry picked from commit 38e7f429963be03ff6705540ca25f880b4db789a)
    Bug: b:469148340, b:469875164, b:469877869, b:469875837, b:469877646, b:469875247, b:469875271, b:470072061, 471210631
    Change-Id: I90d6dba87914ca08790649d44d150177e2cb9660
    Reviewed-by: Christian Xu <chris...@chromium.org>
    Commit-Queue: Jason Hu <huja...@google.com>
    Cr-Original-Commit-Position: refs/heads/main@{#1560682}
    Owners-Override: Justin Donnelly <jdon...@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Commit-Queue: Justin Donnelly <jdon...@chromium.org>
    Cr-Commit-Position: refs/branch-heads/7559@{#2107}
    Cr-Branched-From: 223dfbac1c7542a06b422390d954afe5b560b607-refs/heads/main@{#1552494}
    Files:
    • M chrome/browser/contextual_tasks/contextual_tasks_composebox_handler_unittest.cc
    • M chrome/browser/contextual_tasks/contextual_tasks_ui.cc
    • M chrome/browser/contextual_tasks/contextual_tasks_ui_service.cc
    • M chrome/browser/ui/lens/lens_query_flow_router.cc
    • M chrome/browser/ui/lens/lens_query_flow_router_unittest.cc
    • M chrome/browser/ui/webui/cr_components/composebox/composebox_handler_unittest.cc
    • M chrome/browser/ui/webui/new_tab_page/new_tab_page_ui.cc
    • M chrome/browser/ui/webui/omnibox_popup/omnibox_popup_ui.cc
    • M chrome/browser/ui/webui/searchbox/contextual_searchbox_handler_browsertest.cc
    • M chrome/browser/ui/webui/searchbox/contextual_searchbox_handler_unittest.cc
    • M chrome/browser/ui/webui_browser/webui_browser_ui.cc
    • M components/contextual_search/BUILD.gn
    • M components/contextual_search/contextual_search_service_unittest.cc
    • M components/contextual_search/contextual_search_session_handle.cc
    • M components/contextual_search/contextual_search_session_handle.h
    • M components/contextual_tasks/internal/pending_context_decorator_unittest.cc
    • M ios/chrome/browser/composebox/coordinator/composebox_input_plate_coordinator.mm
    • M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator_unittest.mm
    Change size: M
    Delta: 18 files changed, 133 insertions(+), 19 deletions(-)
    Branch: refs/branch-heads/7559
    Submit Requirements:
    • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: refs/branch-heads/7559
    Gerrit-Change-Id: I90d6dba87914ca08790649d44d150177e2cb9660
    Gerrit-Change-Number: 7313012
    Gerrit-PatchSet: 3
    Gerrit-Owner: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Reviewer: AyeAye <android-bu...@system.gserviceaccount.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Justin Donnelly <jdon...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages