Add first PageActionMenuMediator unit test and necessary scaffolding. [chromium/src : main]
0 views
Skip to first unread message
Yasaman Sedaghat (Gerrit)
3:13 PM (4 hours ago) 3:13 PM
to Sebastien S-G, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sebastien S-G
Yasaman Sedaghat added 3 comments![]( "Open in Gerrit")
File ios/chrome/browser/intelligence/page_action_menu/coordinator/page_action_menu_mediator_unittest.mm
Line 34, Patchset 1 (Latest):
class FakeBwgService : public BwgService {Yasaman Sedaghat . unresolved
Can this exist in its own file? There will be many test classes that would need to depend on it.
Line 96, Patchset 1 (Latest):
builder.AddTestingFactory(Yasaman Sedaghat . unresolved
same here, I think we shouldn't need this since we are faking bwg service.
Line 103, Patchset 1 (Latest):
identity_manager_ =Yasaman Sedaghat . unresolved
seems to be not used?
Related details
Attention is currently required from:
- Sebastien S-G
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yasaman Sedaghat (Gerrit)
3:13 PM (4 hours ago) 3:13 PM
to Sebastien S-G, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Sebastien S-G
Yasaman Sedaghat voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Sebastien S-G
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages