[Android] Merge first run signin test suites [chromium/src : main]

0 views
Skip to first unread message

Boris Sazonov (Gerrit)

unread,
Mar 4, 2026, 8:46:48 AM (yesterday) Mar 4
to Tanmoy Mollik, Boris Sazonov, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, penghuan...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, fuzzin...@chromium.org, jz...@chromium.org, chrome-intelligence-te...@google.com, fgal...@chromium.org, jshin...@chromium.org, mar...@chromium.org, net-r...@chromium.org, feature-me...@chromium.org
Attention needed from Tanmoy Mollik

Boris Sazonov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tanmoy Mollik
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a9b3ccf7fad03a07545e3e6af40a9d251da7ee
Gerrit-Change-Number: 7456251
Gerrit-PatchSet: 22
Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>
Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>
Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-Attention: Tanmoy Mollik <triplo...@google.com>
Gerrit-Comment-Date: Wed, 04 Mar 2026 13:46:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Boris Sazonov (Gerrit)

unread,
11:36 AM (6 hours ago) 11:36 AM
to Tanmoy Mollik, Boris Sazonov, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, penghuan...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, fuzzin...@chromium.org, jz...@chromium.org, chrome-intelligence-te...@google.com, fgal...@chromium.org, jshin...@chromium.org, mar...@chromium.org, net-r...@chromium.org, feature-me...@chromium.org
Attention needed from Tanmoy Mollik

Boris Sazonov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tanmoy Mollik
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia5a9b3ccf7fad03a07545e3e6af40a9d251da7ee
Gerrit-Change-Number: 7456251
Gerrit-PatchSet: 24
Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>
Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>
Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-Attention: Tanmoy Mollik <triplo...@google.com>
Gerrit-Comment-Date: Thu, 05 Mar 2026 16:36:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Boris Sazonov (Gerrit)

unread,
11:37 AM (6 hours ago) 11:37 AM
to Tanmoy Mollik, Boris Sazonov, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, penghuan...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, fuzzin...@chromium.org, jz...@chromium.org, chrome-intelligence-te...@google.com, fgal...@chromium.org, jshin...@chromium.org, mar...@chromium.org, net-r...@chromium.org, feature-me...@chromium.org
Attention needed from Tanmoy Mollik

Boris Sazonov voted Code-Review+0

Code-Review+0
Open in Gerrit

Related details

Attention is currently required from:
  • Tanmoy Mollik
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia5a9b3ccf7fad03a07545e3e6af40a9d251da7ee
    Gerrit-Change-Number: 7456251
    Gerrit-PatchSet: 24
    Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>
    Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>
    Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>
    Gerrit-CC: Jerome Jiang <ji...@chromium.org>
    Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
    Gerrit-Attention: Tanmoy Mollik <triplo...@google.com>
    Gerrit-Comment-Date: Thu, 05 Mar 2026 16:37:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Boris Sazonov (Gerrit)

    unread,
    11:38 AM (6 hours ago) 11:38 AM
    to Tanmoy Mollik, Boris Sazonov, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, penghuan...@chromium.org, chrome-intell...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, fuzzin...@chromium.org, jz...@chromium.org, chrome-intelligence-te...@google.com, fgal...@chromium.org, jshin...@chromium.org, mar...@chromium.org, net-r...@chromium.org, feature-me...@chromium.org
    Attention needed from Tanmoy Mollik

    Boris Sazonov added 1 comment

    File chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
    Line 485, Patchset 24 (Latest):
    if (mNativeInitialized && mNativeInitializationPromise.isPending()) {
    mNativeInitializationPromise.fulfill(null);
    }
    Boris Sazonov . unresolved

    Why do this? It seems like setting the promise in `onNativeDependenciesFullyInitialized` should be enough?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tanmoy Mollik
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia5a9b3ccf7fad03a07545e3e6af40a9d251da7ee
      Gerrit-Change-Number: 7456251
      Gerrit-PatchSet: 24
      Gerrit-Owner: Tanmoy Mollik <triplo...@google.com>
      Gerrit-Reviewer: Boris Sazonov <bsaz...@chromium.org>
      Gerrit-Reviewer: Tanmoy Mollik <triplo...@google.com>
      Gerrit-CC: Jerome Jiang <ji...@chromium.org>
      Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-Attention: Tanmoy Mollik <triplo...@google.com>
      Gerrit-Comment-Date: Thu, 05 Mar 2026 16:38:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages