[WebAuthn] Make immediate get no longer consume user activation [chromium/src : main]

0 views
Skip to first unread message

Ken Buchanan (Gerrit)

unread,
2:28 PM (5 hours ago) 2:28 PM
to Martin Kreichgauer, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Martin Kreichgauer

Ken Buchanan voted and added 1 comment

Votes added by Ken Buchanan

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Ken Buchanan . resolved

PTAL?

Open in Gerrit

Related details

Attention is currently required from:
  • Martin Kreichgauer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie4e9a368a3e29ff1bf86004ec59d647493b09f53
Gerrit-Change-Number: 7719140
Gerrit-PatchSet: 4
Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
Gerrit-Reviewer: Martin Kreichgauer <mart...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-Attention: Martin Kreichgauer <mart...@google.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 18:28:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Martin Kreichgauer (Gerrit)

unread,
6:16 PM (1 hour ago) 6:16 PM
to Ken Buchanan, Martin Kreichgauer, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org
Attention needed from Ken Buchanan

Martin Kreichgauer voted and added 1 comment

Votes added by Martin Kreichgauer

Code-Review+1

1 comment

File chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
Line 895, Patchset 4 (Latest): const url::Origin top_frame_origin =
GetRenderFrameHost()->GetMainFrame()->GetLastCommittedOrigin();
if (!rate_limiter->IsRequestAllowed(top_frame_origin)) {
Martin Kreichgauer . unresolved

Nit: Requests being attributed to the main frame origin seems like an implementation detail. Should IsRequestAllowed() just take the RenderFrameHost reference as an input?

Open in Gerrit

Related details

Attention is currently required from:
  • Ken Buchanan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie4e9a368a3e29ff1bf86004ec59d647493b09f53
    Gerrit-Change-Number: 7719140
    Gerrit-PatchSet: 4
    Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
    Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
    Gerrit-Reviewer: Martin Kreichgauer <mart...@google.com>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 22:16:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ken Buchanan (Gerrit)

    unread,
    6:57 PM (1 hour ago) 6:57 PM
    to Martin Kreichgauer, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, derinel+wat...@google.com, npm+...@chromium.org, webauthn...@chromium.org, yigu+...@chromium.org

    Ken Buchanan added 1 comment

    File chrome/browser/webauthn/chrome_authenticator_request_delegate.cc
    Line 895, Patchset 4: const url::Origin top_frame_origin =

    GetRenderFrameHost()->GetMainFrame()->GetLastCommittedOrigin();
    if (!rate_limiter->IsRequestAllowed(top_frame_origin)) {
    Martin Kreichgauer . resolved

    Nit: Requests being attributed to the main frame origin seems like an implementation detail. Should IsRequestAllowed() just take the RenderFrameHost reference as an input?

    Ken Buchanan

    Done. We need something persistent so using the frame token.

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie4e9a368a3e29ff1bf86004ec59d647493b09f53
      Gerrit-Change-Number: 7719140
      Gerrit-PatchSet: 4
      Gerrit-Owner: Ken Buchanan <ke...@chromium.org>
      Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
      Gerrit-Reviewer: Martin Kreichgauer <mart...@google.com>
      Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 22:57:17 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Martin Kreichgauer <mart...@google.com>
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages