Allow 1 fps in H264RateController for screen sharing [chromium/src : main]
0 views
Skip to first unread message
Eugene Zemtsov (Gerrit)
Feb 11, 2026, 7:07:03 PM (12 hours ago) Feb 11
to Wang, Zhibo1, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Wang, Zhibo1
Eugene Zemtsov voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Wang, Zhibo1
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Wang, Zhibo1 (Gerrit)
Feb 11, 2026, 10:16:33 PM (8 hours ago) Feb 11
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Wang, Zhibo1 voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:23 AM (2 hours ago) 4:23 AM
to Wang, Zhibo1, Eugene Zemtsov, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Allow 1 fps in H264RateController for screen sharing
WebRTC screen sharing can use 1 fps for static content. This CL updates
the DCHECK to allow frame rates greater than or equal to 1 fps, to avoid
crashes for some video encoder.
Change-Id: If6183eaa50c1e100e6c71e4283e714e608e02c57
Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
Commit-Queue: Wang, Zhibo1 <zhibo...@intel.com>
Cr-Commit-Position: refs/heads/main@{#1583815}
Files:
- M media/gpu/h264_rate_controller.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Eugene Zemtsov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages