Allow 1 fps in H264RateController for screen sharing [chromium/src : main]

0 views
Skip to first unread message

Eugene Zemtsov (Gerrit)

unread,
Feb 11, 2026, 7:07:03 PM (12 hours ago) Feb 11
to Wang, Zhibo1, Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Attention needed from Wang, Zhibo1

Eugene Zemtsov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Wang, Zhibo1
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If6183eaa50c1e100e6c71e4283e714e608e02c57
Gerrit-Change-Number: 7543734
Gerrit-PatchSet: 1
Gerrit-Owner: Wang, Zhibo1 <zhibo...@intel.com>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Wang, Zhibo1 <zhibo...@intel.com>
Gerrit-Attention: Wang, Zhibo1 <zhibo...@intel.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 00:06:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Wang, Zhibo1 (Gerrit)

unread,
Feb 11, 2026, 10:16:33 PM (8 hours ago) Feb 11
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org

Wang, Zhibo1 voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If6183eaa50c1e100e6c71e4283e714e608e02c57
Gerrit-Change-Number: 7543734
Gerrit-PatchSet: 1
Gerrit-Owner: Wang, Zhibo1 <zhibo...@intel.com>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Wang, Zhibo1 <zhibo...@intel.com>
Gerrit-Comment-Date: Thu, 12 Feb 2026 03:16:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Wang, Zhibo1 (Gerrit)

unread,
4:19 AM (2 hours ago) 4:19 AM
to Eugene Zemtsov, Chromium LUCI CQ, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org
Gerrit-Comment-Date: Thu, 12 Feb 2026 09:19:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
4:23 AM (2 hours ago) 4:23 AM
to Wang, Zhibo1, Eugene Zemtsov, chromium...@chromium.org, chromeos-gfx-...@google.com, feature-me...@chromium.org, media-cro...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Allow 1 fps in H264RateController for screen sharing

WebRTC screen sharing can use 1 fps for static content. This CL updates
the DCHECK to allow frame rates greater than or equal to 1 fps, to avoid
crashes for some video encoder.
Change-Id: If6183eaa50c1e100e6c71e4283e714e608e02c57
Reviewed-by: Eugene Zemtsov <eug...@chromium.org>
Commit-Queue: Wang, Zhibo1 <zhibo...@intel.com>
Cr-Commit-Position: refs/heads/main@{#1583815}
Files:
  • M media/gpu/h264_rate_controller.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Eugene Zemtsov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If6183eaa50c1e100e6c71e4283e714e608e02c57
Gerrit-Change-Number: 7543734
Gerrit-PatchSet: 2
Gerrit-Owner: Wang, Zhibo1 <zhibo...@intel.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Eugene Zemtsov <eug...@chromium.org>
Gerrit-Reviewer: Wang, Zhibo1 <zhibo...@intel.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages